Change in ovirt-engine[ovirt-engine-3.3]: core: preserve custom db users permissions on...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: preserve custom db users permissions on...
......................................................................
core: preserve custom db users permissions on...
preserve custom db users permissions on upgrade
Up to this patch if custom users were added and assign privileges on DB
objects those privileges were removed when the db was updated or
refreshed.
This patch backups the privileges assigned to custom users and apply
them after the database was upgraded or refreshed.
Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1078129
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunctions.sh
M packaging/dbscripts/refreshStoredProcedures.sh
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: block hot unplug CPU
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: block hot unplug CPU
......................................................................
core: block hot unplug CPU
Currently unplug isn't supported due to libvirt's bug[1]
- added canDo action
- exposed config value via engine-confg for
HotPlugCpuSupported and HotPlugCpuSupported
Change-Id: I32eafdc685198b98005906dc14f6fdc8cc1c7763
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077515
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotSetNumerOfCpusParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/etc/engine-config/engine-config.properties
11 files changed, 73 insertions(+), 9 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32eafdc685198b98005906dc14f6fdc8cc1c7763
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: rerun HA VMs on manual fence using AutoStartVmsRunner
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: rerun HA VMs on manual fence using AutoStartVmsRunner
......................................................................
core: rerun HA VMs on manual fence using AutoStartVmsRunner
Same as 1269b60ae6ab8caf42bc2fb5ff06c0403b0b7562 but for manual fence.
Change-Id: Ia40853abb8b985da93ab1c43146ec5d227c8cf88
Bug-Url: https://bugzilla.redhat.com/1080961
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java
1 file changed, 6 insertions(+), 8 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/26115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia40853abb8b985da93ab1c43146ec5d227c8cf88
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Physically disconnecting blade from chass...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Physically disconnecting blade from chass...
......................................................................
core: Physically disconnecting blade from chass...
Physically disconnecting blade from chassis does not trigger HA VMs to
restart
This patch verifies that if a Stop PM operation fails and the Host on
which the fencing was performed had running VMs, those VMs will be set
to the UNKNOWN status just after the Stop PM operation failed.
This way, the user can confirm manually that Host has been rebooted and
start HA VMs on another host.
Change-Id: I7d638d574bfe9195e56bdc5970544f97af15af6c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063432
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d638d574bfe9195e56bdc5970544f97af15af6c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: rerun HA VMs on automatic fence using AutoStartVmsRunner
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: rerun HA VMs on automatic fence using AutoStartVmsRunner
......................................................................
core: rerun HA VMs on automatic fence using AutoStartVmsRunner
Before the engine sends fence request to VDSM, it tries to rerun the
highly available VMs that ran on the host by invoking RunVmCommand
directly. The problem is that we won't try to rerun the VM again if the
RunVmCommand fails (and in case the host which is being fenced in the
only one that was active in the cluster the command will fail for sure).
The solution is to rerun the highly available VMs using
AutoStartVmsRunner job in this flow as well.
Change-Id: Ic259ff22c4b6f24b09eb973de6e31ebc51aa966b
Bug-Url: https://bugzilla.redhat.com/1077706
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/26049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic259ff22c4b6f24b09eb973de6e31ebc51aa966b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: Fix AuditLog check for existing log entries
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix AuditLog check for existing log entries
......................................................................
core: Fix AuditLog check for existing log entries
The audit log check for existing element in the cache,
If the entry exist, then there is no need for another log message.
This is how the anti flooding mechanism works.
For that we use Infinispan cache and the putIfAbsent method,
which updates the lifespan(time to keep in cache).
For our use of the cache, we don't want this update.
The fix changes the putIfAbsent and replace it with two othe API methods,
Contains and Put.
Change-Id: I94b777911eb1ff667be3dc8362bde5746d84824c
Bug-Url: https://bugzilla.redhat.com/1079920
Signed-off-by: Kobi Ianko <kobi(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
1 file changed, 11 insertions(+), 6 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Kobi Ianko: Verified
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94b777911eb1ff667be3dc8362bde5746d84824c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: make ClearNonResponsiveVdsVms non-transactive
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: make ClearNonResponsiveVdsVms non-transactive
......................................................................
core: make ClearNonResponsiveVdsVms non-transactive
ClearNonResponsiveVdsVmsCommand basically do the following things:
1. Change all the VMs that ran on the host to DOWN
2. Update the VDS attributes as if no VM is running on the host
3. Run HA VMs that ran on the host
Since this command used to be transactive, the DOWN state on the VMs was
not committed at stage #3. The RunVmCommands triggered in stage #3 still
worked because we were doing the canDoAction checks in the same
transaction (in the multiple action runner). If on the other hand we were
just executing the command one-by-one it would not work because
RunVmCommand is non-transactive so in the canDoAction checks we were
thinking the VMs are in UNKNOWN state - and this is wrong.
There is no real reason for this command to be transactive since after
the user confirmed that the host has been booted, we assume the VMs are
DOWN anyway so the right thing to do is changed their status to DOWN.
The only problematic case of changing the status of the VMs outside of a
transaction scope will be if the host was powered off and we didn't
reach stage #3 (run the HA VMs) after doing stage #1 (this is very
unlikely to happen though) - The VMs will be DOWN and their runningOnVds
field will be blank so VURTI won't try to rerun them when the host will
go up. The good side is that the user will be able to run them manually
if the host is not going to restart (as opposed to keep them in UNKNOWN
state).
So for a conclusion: this patch is not ideal, it solved an issue and
creates another minor issue which is very not likely to happen, and
should probably be fixed by another mechanism that will rerun HA VMs
which are DOWN because of an error and AutoStartVmsRunner didn't try
to rerun.
Change-Id: Ia8728e56f21ff6dcf6e103b1d450eecfaa36e809
Bug-Url: https://bugzilla.redhat.com/1080961
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java
1 file changed, 10 insertions(+), 11 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/26153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8728e56f21ff6dcf6e103b1d450eecfaa36e809
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: REST: Adding validation for snapshot id on preview
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: REST: Adding validation for snapshot id on preview
......................................................................
REST: Adding validation for snapshot id on preview
Adding validation for snapshot id, when issuing PREVIEW on a VM.
Change-Id: Ib325c7d1a23eb0558f360cc0916bb0fcca981186
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/26237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib325c7d1a23eb0558f360cc0916bb0fcca981186
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: host-deploy: node-upgrade: apply artificial eof for vdsm-upg...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: node-upgrade: apply artificial eof for vdsm-upgrade
......................................................................
host-deploy: node-upgrade: apply artificial eof for vdsm-upgrade
apply artificial end-of-file.
there is no way in java to use non blocking
InputStream.
there is no way to interrupt the blocking.
and we cannot terminate thread as the connection
pool will get messy.
so we should detect eof based on data.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080594
Change-Id: I093357933d2f10c0d90864f53977b832a58dafbd
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I093357933d2f10c0d90864f53977b832a58dafbd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: fix interface high network use script number
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: fix interface high network use script number
......................................................................
engine: fix interface high network use script number
Change-Id: I65b539a7ad15517c76cb663d9fc02088ea83f530
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
R packaging/dbscripts/upgrade/03_05_0160_add_host_interface_high_network_use_event.sql
1 file changed, 0 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65b539a7ad15517c76cb663d9fc02088ea83f530
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months