March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Disable iSCSI multipathing for datacenters < 3.4
by amureini＠redhat.com 29 Mar '14

29 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Disable iSCSI multipathing for datacenters < 3.4 ...................................................................... engine: Disable iSCSI multipathing for datacenters < 3.4 I had to fix a few issues in VDSM 3.4 in order to support configuration of iSCSI multipathing, therefore this feature should be disabled for earlier datacenter versions. Change-Id: I623cd917ca0871a9d3d09c2d30ec2dfc114d383e Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 44 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I623cd917ca0871a9d3d09c2d30ec2dfc114d383e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Set default tpgt value to 1
by amureini＠redhat.com 29 Mar '14

29 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Set default tpgt value to 1 ...................................................................... engine: Set default tpgt value to 1 Engine uses wrong iSCSI terminology, portal instead of tpgt (target portal group tag) which only purpose at this stage impose iSCSI layer to create node record in the new format supporting multipathing. Tpgt default value in VDSM is 1 so it should be the same here. Change-Id: I7ebfc1335b051e02f62b9544d2500416818940d0 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/StorageDomainHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 5 files changed, 7 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/26050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebfc1335b051e02f62b9544d2500416818940d0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains
by yzaslavs＠redhat.com 28 Mar '14

28 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains ...................................................................... tools: Add --resolve-kdc arg to engine-manage-domains Adds --resolve-kdc argument to engine-mamage-domains which forces discovery of kerberos servers using DNS. This is usefull, when LDAP and Kerberos servers are not provided on same hosts (by default we suppose that LDAP and Kerberos servers are on the same hosts). Change-Id: I7884eae1c67636c7fc4578f7f16358205702ef64 Bug-Url: https://bugzilla.redhat.com/1031778 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java M backend/manager/modules/builtin-extensions/src/main/resources/manage-domains-help.properties M packaging/man/man8/engine-manage-domains.8 4 files changed, 28 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7884eae1c67636c7fc4578f7f16358205702ef64 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: vm type not copied from template to pool
by tjelinek＠redhat.com 28 Mar '14

28 Mar '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: vm type not copied from template to pool ...................................................................... userportal,webadmin: vm type not copied from template to pool Fixed by adding the missing mapping from teplate to pool. Change-Id: I28d022bd00cbf0e56db26451c3941c1eb3608a66 Bug-Url: https://bugzilla.redhat.com/1057036 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28d022bd00cbf0e56db26451c3941c1eb3608a66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: class cast exception in AdElementListModel
by tjelinek＠redhat.com 28 Mar '14

28 Mar '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: class cast exception in AdElementListModel ...................................................................... webadmin: class cast exception in AdElementListModel A regression has been introduced by fc169177820737e984c65d930056be7e2e85d289. If there is no domain configured the search query used to return ArrayList but now it returns a Collections.emptyList() while the AdElementListModel tries to cast it to ArrayList which fails. Fixed by casting it to more general Collection. Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix DbUserCacheManager when to refresh users
by yzaslavs＠redhat.com 28 Mar '14

28 Mar '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix DbUserCacheManager when to refresh users ...................................................................... core: Fix DbUserCacheManager when to refresh users a. firstName of dbUser should be compared & set with firstName of DirectoryUser b. Search for user by user ids did not populate the groups, so the groups per user were removed. Change-Id: Icec0ffa48671e4fed2b631a60db9dd226ad6d347 Bug-Url: https://bugzilla.redhat.com/1081204 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapDirectory.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapGetAdUserByUserIdListCommand.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByIdListParameters.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByQueryParameters.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchByUserIdListParameters.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchUserByQueryCommand.java 7 files changed, 38 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icec0ffa48671e4fed2b631a60db9dd226ad6d347 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sven Kieske <svenkieskemittwald(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Sync engine-config man pages and help
by oourfali＠redhat.com 27 Mar '14

27 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Sync engine-config man pages and help ...................................................................... tools: Sync engine-config man pages and help Synchronizes content of engine-config man page with information displayed by execution 'engine-config -h'. Change-Id: I16e16973cb24e7e6e3209d229e0cdabfd3ffbc84 Bug-Url: https://bugzilla.redhat.com/1074299 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/bin/engine-config.sh M packaging/man/man8/engine-config.8 2 files changed, 106 insertions(+), 61 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16e16973cb24e7e6e3209d229e0cdabfd3ffbc84 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: locale in jsps not used
by oourfali＠redhat.com 27 Mar '14

27 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: locale in jsps not used ...................................................................... engine: locale in jsps not used - Fixed issue where the user selected locale was not being used in the translated messages on the page for non branded messages. Change-Id: Ief357cf989325402d84efe9d786584373566b0fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1017826 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief357cf989325402d84efe9d786584373566b0fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add external user group to Quota consumers
by gchaplik＠redhat.com 27 Mar '14

27 Mar '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add external user group to Quota consumers ...................................................................... webadmin: Add external user group to Quota consumers Admin user cannot add a group of external users to the consumers of a selected Quota. This regression caused by commit: c68c60e153b7ffd1d900af7b00514b7940cceeb0 Change-Id: I1c1d82596c69f1ff4173f02c5dddf60317eeebb7 Bug-Url: https://bugzilla.redhat.com/1081014 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Kobi Ianko: Verified -- To view, visit http://gerrit.ovirt.org/26173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c1d82596c69f1ff4173f02c5dddf60317eeebb7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: filter out unsupported architectures
by oourfali＠redhat.com 27 Mar '14

27 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: filter out unsupported architectures ...................................................................... webadmin: filter out unsupported architectures Unsupported architecture is one that doesn't have a configured cpu to support it (its a vdc_options). Those archs are useless effectively so no point showing them in the dropdown. Bug-Url: https://bugzilla.redhat.com/1081502 Change-Id: I7568e61882478f10bec614ddf514b32d23adc199 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/26105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7568e61882478f10bec614ddf514b32d23adc199 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0