March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: add missing fields to snmp notifier.
by emesika＠redhat.com 30 Mar '14

30 Mar '14

Eli Mesika has submitted this change and it was merged. Change subject: tools: add missing fields to snmp notifier. ...................................................................... tools: add missing fields to snmp notifier. Change-Id: I4f2941a9af206e85fe15f9bb2372f4b44669699e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1081420 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/26152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f2941a9af206e85fe15f9bb2372f4b44669699e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: etl: fixed generated code issue
by ydary＠redhat.com 30 Mar '14

30 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed generated code issue ...................................................................... etl: fixed generated code issue Change-Id: I3132e09d0aaccc0d9899a5408793047b2eaf74b3 Bug-Url: https://bugzilla.redhat.com/1076902 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_4/AggregationToHourly.java 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3132e09d0aaccc0d9899a5408793047b2eaf74b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: post ovirt-engine-dwh-3.4.0
by ydary＠redhat.com 30 Mar '14

30 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.4.0 ...................................................................... build: post ovirt-engine-dwh-3.4.0 Change-Id: I82ec5bc0f9fb819a3a159f92e721e7b169b5ebcd Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M etl_export/ovirt_engine_dwh/minimalversioncheck_3_4/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_3_4/contexts/Default.properties M tos_project/context/connectionJDBC_3.4.item M tos_project/process/HistoryETL_3.4.item M tos_project/process/MinimalVersionCheck_3.4.item M tos_project/process/ParallelRun_3.4.item M version.mak 7 files changed, 9 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82ec5bc0f9fb819a3a159f92e721e7b169b5ebcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: build: post ovirt-engine-reports-3.4.0
by ydary＠redhat.com 30 Mar '14

30 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.4.0 ...................................................................... build: post ovirt-engine-reports-3.4.0 Change-Id: I081371a766a56424322362067f3a01b2bb71044c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I081371a766a56424322362067f3a01b2bb71044c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: added strandard log rotate config file
by ydary＠redhat.com 30 Mar '14

30 Mar '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added strandard log rotate config file ...................................................................... packaging: added strandard log rotate config file removed JRS default log rotation. Change-Id: If78b204a139de079ca9eb70a1341ec0045c064ef Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine-reports.spec.in M packaging/jasper-war-patches/ce/900_004_props_change_logs_location.patch.in M packaging/jasper-war-patches/pro/900_004_props_change_logs_location.patch.in A packaging/sys-etc/logrotate.d/ovirt-engine-reports.in 6 files changed, 47 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If78b204a139de079ca9eb70a1341ec0045c064ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix sysprep architecture values
by rgolan＠redhat.com 30 Mar '14

30 Mar '14

Roy Golan has submitted this change and it was merged. Change subject: core: fix sysprep architecture values ...................................................................... core: fix sysprep architecture values arch values don't match the OS ini question - x86 instead of amd64 for OSs which are 64 bit Change-Id: Id61fea5f128de054bfe143d9888751205fa080e4 Bug-Url: https://bugzilla.redhat.com/1066884 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 2 files changed, 87 insertions(+), 87 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id61fea5f128de054bfe143d9888751205fa080e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Adjust console tooltips
by oourfali＠redhat.com 30 Mar '14

30 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Adjust console tooltips ...................................................................... frontend: Adjust console tooltips Console tooltips for clients are vague and difficult to reach (user needs to hover over the radio button). This patch moves the description from radio button tooltip to explicit InfoIcon widget. Change-Id: I2459521e7ba303918a0992ffd95398b0c42f03df Bug-Url: https://bugzilla.redhat.com/1071894 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/WidgetWithInfo.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/WidgetWithInfo.ui.xml 5 files changed, 156 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/25265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2459521e7ba303918a0992ffd95398b0c42f03df Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: warn when exporting template version if base is mi...
by oourfali＠redhat.com 30 Mar '14

30 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: warn when exporting template version if base is missing ...................................................................... webadmin: warn when exporting template version if base is missing added a warning to the user, if trying to export template version, and the base template is missing on the export domain, because on import the base template must exist, or clone is needed. this is very similar for exporting thin vm when template is missing. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073035 Change-Id: I028f9e98a31cca391e05e2e02c535f5f1b2068cf Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 136 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/26072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028f9e98a31cca391e05e2e02c535f5f1b2068cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel
by oourfali＠redhat.com 30 Mar '14

30 Mar '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: class cast exception in AdElementListModel ...................................................................... webadmin: class cast exception in AdElementListModel A regression has been introduced by fc169177820737e984c65d930056be7e2e85d289. If there is no domain configured the search query used to return ArrayList but now it returns a Collections.emptyList() while the AdElementListModel tries to cast it to ArrayList which fails. Fixed by casting it to more general Collection. Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1081895 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Send ifaceName and tpgt in connectStorageServer
by amureini＠redhat.com 29 Mar '14

29 Mar '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Send ifaceName and tpgt in connectStorageServer ...................................................................... engine: Send ifaceName and tpgt in connectStorageServer Engine mistakenly sent initiatorName instead of ifaceName which overwrote existing initiatorName configured in the host. Wrong initiatorName caused host fail to perform iSCSI connection. In case of tpgt the problem is terminology. Engine sent it as a "portal" and its value is integer, but from the iSCSI perspective portal is an access point to one or more targets, while this integer actually represents a tpgt - target portal group tag which is numeric representation of which IP addresses a target is allowed to bind on. Bug-Url: https://bugzilla.redhat.com/1078137 Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sergey Gotliv: Verified Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife467feb8aad9711da5d6a5df305e50fe6bf51e9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0