Change in ovirt-engine[ovirt-engine-3.4]: engine: Set SinglePCI to false when importing VNC display
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Set SinglePCI to false when importing VNC display
......................................................................
engine: Set SinglePCI to false when importing VNC display
When importing VM the OVF reader (which read from the export domain)
need additional check to remove the default SinglePCI for VNC display.
Bug-Url: https://bugzilla.redhat.com/1075294
Change-Id: I39c4d1dd45f3fa91b5fe3f0a7e786a26eb66fb29
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39c4d1dd45f3fa91b5fe3f0a7e786a26eb66fb29
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.4]: core: Remove domain field from search for Vms and Templates
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Remove domain field from search for Vms and Templates
......................................................................
core: Remove domain field from search for Vms and Templates
Bug-Url: https://bugzilla.redhat.com/1078093
Change-Id: I8d639c7500f1f5448388c959457a9cbb7def1b0e
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java
2 files changed, 0 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25994
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d639c7500f1f5448388c959457a9cbb7def1b0e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[ovirt-engine-3.4]: tools: Domain name should be case insensitive
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: tools: Domain name should be case insensitive
......................................................................
tools: Domain name should be case insensitive
Domain name should be case insensitive. This patch by default converts
domain entered by user to lower case so it can be easily compared and
used as a key in maps.
Change-Id: I2573933e6ded5644f3c0c4c532e2407d753b9f4f
Bug-Url: https://bugzilla.redhat.com/1078147
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java
2 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26064
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2573933e6ded5644f3c0c4c532e2407d753b9f4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: restapi: Return error in replace-brick
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Return error in replace-brick
......................................................................
restapi: Return error in replace-brick
Replace brick rest api is no longer supported in the
underlying glusterfs. Hence changing the rest api
to throw an error advising user to use migrate and
add new brick instead
Change-Id: I72cf2f62c049a0d515ec1f3fde14155b63b9738f
Bug-Url: https://bugzilla.redhat.com/923196
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java
M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java
4 files changed, 13 insertions(+), 38 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/25259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72cf2f62c049a0d515ec1f3fde14155b63b9738f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: frontend: Add console open link to basic UP
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Add console open link to basic UP
......................................................................
frontend: Add console open link to basic UP
This patch adds a link that opens console to details view of vm in UP.
This is useful for tablet browser users (who can't double-click).
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1043559
Change-Id: I758d487360de8812539e98da3fd8eae68b243edf
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
4 files changed, 64 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/26110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I758d487360de8812539e98da3fd8eae68b243edf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: userportal: Check connect availability on doubleclick
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: Check connect availability on doubleclick
......................................................................
userportal: Check connect availability on doubleclick
This small patch adds checking whether user is allowed to connect to
console on doubleclick. (e.g. previously, when user doubleclicked vm
annoying dialog explaining that console isn't available would be
displayed).
Change-Id: I851b93eb8c68713be3c9738da551b59841623aa9
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/26120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I851b93eb8c68713be3c9738da551b59841623aa9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: core: loadbalancing: prevent VM bounces between hosts
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: loadbalancing: prevent VM bounces between hosts
......................................................................
core: loadbalancing: prevent VM bounces between hosts
When balancing a cluster, the balancing logic should return
a VM and acceptable hosts, while filtering those hosts
the scheduler#balance doesn't take into account the predicted VM CPU load.
This may result in a VM bouncing between 2 hosts (if VM consumes
all the CPU resources on both hosts).
Change-Id: I6beebf4324bfa5218d9617619b350fb9a2de56d3
Bug-Url: https://bugzilla.redhat.com/1043233
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java
1 file changed, 38 insertions(+), 6 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jiří Moskovčák: Looks good to me, but someone else must approve
Gilad Chaplik: Verified
Arik Hadas: Looks good to me, approved
Kobi Ianko: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6beebf4324bfa5218d9617619b350fb9a2de56d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: fixed generics in EnumTranslator, fixed typo
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fixed generics in EnumTranslator, fixed typo
......................................................................
webadmin: fixed generics in EnumTranslator, fixed typo
Parameterized EnumTranslator could accept any type, not just Enums,
which is wrong. Constructor accepted also any type, but it was
expected (not reinforced) that this type will be
Class<? extends Enum<?>>.
Change-Id: If835e719a497e7ab1db4fc4f9484354e838c60c5
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Gilad Chaplik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/25605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If835e719a497e7ab1db4fc4f9484354e838c60c5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: Adding remaining system tree elements to cache map
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Adding remaining system tree elements to cache map
......................................................................
webadmin: Adding remaining system tree elements to cache map
Adding remaining system tree elements to the treeItemById map,
this will make all tree elements accessible via
the "SystemTreeItemModel getItemById(Guid id)" method.
Change-Id: I1e92d50ca53891b6c888ce89baf799962d47def3
Signed-off-by: Kobi Ianko <kobi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25135
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e92d50ca53891b6c888ce89baf799962d47def3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in ovirt-engine[master]: webadmin: Adding Quota column to the Disk tab
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Adding Quota column to the Disk tab
......................................................................
webadmin: Adding Quota column to the Disk tab
Adding a new column to the Disk tab, Quota.
the new Quota column will be visible only in case
the user point to a DC in the tree view,
and that DC is not marked as Quota disabled.
The possible value for this column is:
Empty(null) - no Quota was selected for this Disk.
String value - the name of the Quota selected for this Disk.
Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e
Bug-Url: https://bugzilla.redhat.com/949863
Signed-off-by: Kobi Ianko <kobi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
6 files changed, 84 insertions(+), 9 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years