March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Use thread-based workers for GWT compil...
by vszocs＠redhat.com 07 Mar '14

07 Mar '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Use thread-based workers for GWT compilation ...................................................................... webadmin,userportal: Use thread-based workers for GWT compilation This patch ensures that thread-based permutation worker factory (ThreadedPermutationWorkerFactory) is used for GWT compilation. Instead of launching external workers as Java sub-processes (CompilePermsServer) communicating with main GWT Java compiler process via socket, this patch makes GWT Java compiler spawn internal workers as threads. This should reduce overhead when compiling lots of permutations. gwt.jjs.maxThreads is set to 4, which means: max_worker_threads = min(localWorkers, 4) where localWorkers is controlled by gwt.compiler.localWorkers (For details, see ThreadedPermutationWorkerFactory line 84) In practice, this patch means we can have up to 4 internal (thread-based) workers active at the same time during GWT compilation. The actual number of thread-based workers is controlled via gwt.compiler.localWorkers option. Change-Id: Iabdbe43ba186d4fde646b01fee3d5196ff35e8ba Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabdbe43ba186d4fde646b01fee3d5196ff35e8ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: core: extend installed_by column size in schema...
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: extend installed_by column size in schema... ...................................................................... core: extend installed_by column size in schema... Extend installed_by column size in schema version Extend installed_by column size to 64 to match definition in pg_user. Change-Id: I1483f3fb5f4e5945d1b5d26a12fb24c01ac3c08d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070742 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/pre_upgrade/0040_extend_installed_by_column.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1483f3fb5f4e5945d1b5d26a12fb24c01ac3c08d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: extend installed_by column size in schema...
by iheim＠redhat.com 07 Mar '14

07 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: core: extend installed_by column size in schema... ...................................................................... core: extend installed_by column size in schema... Extend installed_by column size in schema version Extend installed_by column size to 64 to match definition in pg_user. Change-Id: I1483f3fb5f4e5945d1b5d26a12fb24c01ac3c08d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1070742 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/pre_upgrade/0040_extend_installed_by_column.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eli Mesika: Verified Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1483f3fb5f4e5945d1b5d26a12fb24c01ac3c08d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: engine: Remove invalid action groups
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: engine: Remove invalid action groups ...................................................................... engine: Remove invalid action groups Invalid action groups were added to various roles for network labels actions. Those action groups aren't being used and have no representation on the engine, therefore they should be removed. Change-Id: I892378087fdbad15b4b1606c9e55c8d86d8503d0 Bug-Url: https://bugzilla.redhat.com/1072501 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0650_delete_network_labels_action_groups.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I892378087fdbad15b4b1606c9e55c8d86d8503d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: webadmin: Saving a dialog pressing ENTER inconsistent with c...
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK ...................................................................... webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK When clicking on OK button (or any other footer button) the view is flushed before the command is executed. Pressing "ESC" or "ENTER" should be consistent with clicking the footer button "CANCEL" or "OK". Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c Bug-Url: https://bugzilla.redhat.com/1059578 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: core: adding missing default to a non-null column
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: adding missing default to a non-null column ...................................................................... core: adding missing default to a non-null column This patch fixes an issue in event_subscriber table that was added a notification_method column which does not allow nulls. If the table has any records before the upgrade, this will fail since the existing records will have NULL for the new added column. Change-Id: Id3c7ce30c32b9b38f08ff6c8c0eb8bfa02cf5066 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072867 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/03_04_0600_event_notification_methods.sql 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eli Mesika: Verified; Looks good to me, approved mooli tayer: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3c7ce30c32b9b38f08ff6c8c0eb8bfa02cf5066 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: Adding config entry for VDSM 4.14
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Adding config entry for VDSM 4.14 ...................................................................... Adding config entry for VDSM 4.14 Update SupportedVDSMVersions config value to support VDSM 4.14 Change-Id: I4e661ad31afb5599d4d7dd6370e5c9fb98e31863 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067096 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e661ad31afb5599d4d7dd6370e5c9fb98e31863 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: restapi: Don't assume that Lists are ArrayLists
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: restapi: Don't assume that Lists are ArrayLists ...................................................................... restapi: Don't assume that Lists are ArrayLists Currently there are a few places where we assume that the result returned by the backend is an ArrayList. This isn't necessary true, in particular it isn't true for lists of users and groups returned by directories, as they will be special empty lists. This patch changes the RESTAPI so that it uses the List interface instead of the ArrayList class. Change-Id: Iff2d2a7b558f111312b6299ce7ed95993deb68ca Bug-Url: https://bugzilla.redhat.com/1073486 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 975457b92d5b6f02d845c5410ae11d3d186a3635) (cherry picked from commit a49cef416fe9638fd916d73cb896e442f4c9873c) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUsersResource.java 3 files changed, 3 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Juan Hernandez: Verified; Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff2d2a7b558f111312b6299ce7ed95993deb68ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: tools: Fix clearing event filters in notifier
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: Fix clearing event filters in notifier ...................................................................... tools: Fix clearing event filters in notifier Fixes clearing event filters in notifier. If you had this configuration FILTERS=exclude:* (default) and after that you add notification to some user in webadmin, no email was sent until notifier is restarted due to inproper clearing of event filters. Change-Id: If665a84b1c18af1318b74bd88d134164f0f3476c Bug-Url: https://bugzilla.redhat.com/1071536 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If665a84b1c18af1318b74bd88d134164f0f3476c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: tools: Match transport names with EventNotificationMethod
by sbonazzo＠redhat.com 07 Mar '14

07 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: Match transport names with EventNotificationMethod ...................................................................... tools: Match transport names with EventNotificationMethod Fixes different names in Smtp/Snmp.getName() and EventNotificationMethod values which represents transport names in db. If those names differ (current state), no events are sent through notifier. Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e Bug-Url: https://bugzilla.redhat.com/1071536 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java A packaging/dbscripts/upgrade/03_04_0650_fix_event_notfication_method.sql 10 files changed, 54 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0