March 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: display only top level setup packages
by sbonazzo＠redhat.com 09 Mar '14

09 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: display only top level setup packages ...................................................................... packaging: setup: display only top level setup packages currently we print a message with entire transaction content of modified packages for setup packages. better to show only setup packages in price of some performance. Change-Id: I3a1f27090aa362882047007416aacff1cb5dbc4c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 6 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a1f27090aa362882047007416aacff1cb5dbc4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4.0]: restapi: set domain for vm-init
by sbonazzo＠redhat.com 09 Mar '14

09 Mar '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: restapi: set domain for vm-init ...................................................................... restapi: set domain for vm-init Wrong check for setting domain for VM Change-Id: Ia3ee9738b4003b1e094d59a21313f6f84e73ce7f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069201 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Shahar Havivi: Verified Juan Hernandez: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3ee9738b4003b1e094d59a21313f6f84e73ce7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: organize vm initialization on run VM
by ofrenkel＠redhat.com 09 Mar '14

09 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: organize vm initialization on run VM ...................................................................... core: organize vm initialization on run VM We can think of the structure of the execute phase of RunVmCommand as follow: 1. initialize VM object (RunVmCommand#initVm) 2. select host (scheduling) 3. initialize VM object (cont) 4. connect luns 5. communicate with VDSM Some of the operations in #3 should move to #1 as there is no need to know the host on which the VM is going to run (and eventually #3 will be dropped). This patch contains the following changes: * Change the place where the last time the VM started is set to the VDS command which is a better place for it * Moved the setting of: boot parameters + CPU name + parameters for external networks + hibernation volumes + guest agent version + VM devices, to initVm method * Change the place where we determine whether the hibernation volume should be cleared after the VM is started or not to the VDS command Note: some of the initialization steps in #1 (initialize VM object) are required for the can-do-action checks, so this step is divided to 2 parts: one which is before the can-do-action checks and one which is after them. Change-Id: I5afa3dc5e94e2d2dbd48ebc95516b04e96ee043d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVmVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 4 files changed, 65 insertions(+), 90 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/22085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5afa3dc5e94e2d2dbd48ebc95516b04e96ee043d Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change vm custom properties validation
by ofrenkel＠redhat.com 09 Mar '14

09 Mar '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: change vm custom properties validation ...................................................................... core: change vm custom properties validation Change the validation of custom properties of VM when we run it, such that it will check also the custom properties that resides within the parameters of RunVm (which are set in run once mode). This change will allow us to set the custom properties which resides in the VM object on RunVmOnceCommand from the parameters after the can do action phase. In addition, minor refactoring was made to the validation of boot sequence on run VM. Change-Id: I66cec8aa76958831924a48b8a7805cf0d181dcf2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java 4 files changed, 22 insertions(+), 36 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/25405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66cec8aa76958831924a48b8a7805cf0d181dcf2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Added external ID to general sub tab
by iheim＠redhat.com 09 Mar '14

09 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added external ID to general sub tab ...................................................................... webadmin: Added external ID to general sub tab Added external ID for external networks to the general sub tab. Change-Id: I434a25f0f3c33f40d88d0054921abca2f6cf415a Bug-Url: https://bugzilla.redhat.com/1067469 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> (cherry picked from commit f8b744420b2e70fd19645a0365c36909427a212f) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java 2 files changed, 29 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I434a25f0f3c33f40d88d0054921abca2f6cf415a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: set domain for vm-init
by iheim＠redhat.com 09 Mar '14

09 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: set domain for vm-init ...................................................................... restapi: set domain for vm-init Wrong check for setting domain for VM Change-Id: Ia3ee9738b4003b1e094d59a21313f6f84e73ce7f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069201 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3ee9738b4003b1e094d59a21313f6f84e73ce7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: [Labels] SetupNetwork emphasize unconfigured inter...
by iheim＠redhat.com 09 Mar '14

09 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: [Labels] SetupNetwork emphasize unconfigured interface ...................................................................... webadmin: [Labels] SetupNetwork emphasize unconfigured interface Network which is in fact not attached to the interface (but has the same label as the interface) looks like attached in Setup Networks dialog. Change-Id: Ifa83ddfd2ceddc8f2227dcc8cc36c721baf8c7bc Bug-Url: https://bugzilla.redhat.com/1067928 Bug-Url: https://bugzilla.redhat.com/1065270 Bug-Url: https://bugzilla.redhat.com/1068267 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 7 files changed, 100 insertions(+), 31 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa83ddfd2ceddc8f2227dcc8cc36c721baf8c7bc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Display network must have boot protocol
by iheim＠redhat.com 09 Mar '14

09 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Display network must have boot protocol ...................................................................... engine: Display network must have boot protocol The scheduler should not select a host which the display network is configured on without a proper settings for IP address (i.e. only DHCP or Static boot protocol are allowed). Change-Id: I14e5a0edae8524a7334609e58934880a722ca87f Bug-Url: https://bugzilla.redhat.com/955429 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 104 insertions(+), 78 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/25528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e5a0edae8524a7334609e58934880a722ca87f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Improve setup networks failure message
by iheim＠redhat.com 09 Mar '14

09 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Improve setup networks failure message ...................................................................... engine: Improve setup networks failure message Adding a message for a failed setup networks command which was invoked with 'check connectivity'. Change-Id: Id25f864970df7e7f420f760fa8e8c78c1104d64e Bug-Url: https://bugzilla.redhat.com/1072794 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 4 files changed, 13 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25f864970df7e7f420f760fa8e8c78c1104d64e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Improve cannot label bond message
by iheim＠redhat.com 09 Mar '14

09 Mar '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Improve cannot label bond message ...................................................................... engine: Improve cannot label bond message Change-Id: I250c56d0f6a70dbe8da89a3aa5b28592f9a0a995 Bug-Url: https://bugzilla.redhat.com/1054187 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 12 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I250c56d0f6a70dbe8da89a3aa5b28592f9a0a995 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0