Change in ovirt-dwh[ovirt-engine-3.4]: Fixed typo that prevents compilation
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: Fixed typo that prevents compilation
......................................................................
Fixed typo that prevents compilation
There was a python syntax error that prevented compilation and execution
of the module
Change-Id: I4b58c696175c12f9a8e6a95f39ca5e63cf1bb622
Signed-off-by: David Caro <dcaroest(a)redhat.com>
(cherry picked from commit 88db624deda0be01e4eaa3deb75b38848b3188f8)
---
M packaging/setup/ovirt_engine_setup/dwhconstants.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b58c696175c12f9a8e6a95f39ca5e63cf1bb622
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-dwh[master]: Fixed typo that prevents compilation
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: Fixed typo that prevents compilation
......................................................................
Fixed typo that prevents compilation
There was a python syntax error that prevented compilation and execution
of the module
Change-Id: I4b58c696175c12f9a8e6a95f39ca5e63cf1bb622
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/dwhconstants.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
David Caro: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b58c696175c12f9a8e6a95f39ca5e63cf1bb622
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in jenkins[master]: Improve cleanup to avoid failures
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: Improve cleanup to avoid failures
......................................................................
Improve cleanup to avoid failures
Change-Id: I9121e0b104a15a67b94f2f17a2827c75e33c576d
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_stable_to_3.4/cleanup.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
David Caro: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9121e0b104a15a67b94f2f17a2827c75e33c576d
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: add host ssh fingerprint to registration protocol
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: host-deploy: add host ssh fingerprint to registration protocol
......................................................................
host-deploy: add host ssh fingerprint to registration protocol
This is required to allow secure call back into node and avoid man in
the middle, we can now do this.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1090168
Change-Id: I1a9af59277b5055453159f002f19046c0051d82f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterVdsParameters.java
M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java
3 files changed, 21 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d82f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-hosted-engine-ha[master]: use monotonic time when checking the timeouts
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: use monotonic time when checking the timeouts
......................................................................
use monotonic time when checking the timeouts
When using the system time the timers are influenced by the time changes
done by user or ntp. So if the time is shifted backwards, the timers are
delayed which can lead to longer downtime of HA VM running the engine.
Using monotonic time makes the timers independent on the system time.
Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2
Bug-Url: https://bugzilla.redhat.com/1036683
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/agent/state_data.py
M ovirt_hosted_engine_ha/agent/state_data_test.py
M ovirt_hosted_engine_ha/agent/state_decorators.py
M ovirt_hosted_engine_ha/agent/state_machine.py
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/listener.py
M ovirt_hosted_engine_ha/broker/storage_broker.py
M ovirt_hosted_engine_ha/client/client.py
M ovirt_hosted_engine_ha/lib/Makefile.am
M ovirt_hosted_engine_ha/lib/brokerlink.py
M ovirt_hosted_engine_ha/lib/metadata.py
A ovirt_hosted_engine_ha/lib/monotonic.py
13 files changed, 184 insertions(+), 26 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/26384
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9794beb4082f52d29835be5b6a182ab448c248f2
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-host-deploy[master]: core: hardware: fix debug message
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: hardware: fix debug message
......................................................................
core: hardware: fix debug message
Change-Id: I41e80c81d8410c0626b0e28b072dd412a857ee9d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/ovirt_host_deploy/hardware.py
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41e80c81d8410c0626b0e28b072dd412a857ee9d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 8 months
Change in ovirt-engine[master]: backend, frontend: warn users that host must be installed be...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: backend, frontend: warn users that host must be installed before upgrade
......................................................................
backend, frontend: warn users that host must be installed before upgrade
In backend we must check if nodeOS is null and in frontend
we should warn users that any node cannot be upgraded before
installed.
Change-Id: If8ad4f88a079c7f25b544320e10f1d2b5c4190b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076221
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26653
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8ad4f88a079c7f25b544320e10f1d2b5c4190b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Respect line break suggestion in CJK locales
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: Respect line break suggestion in CJK locales
......................................................................
webadmin: Respect line break suggestion in CJK locales
Apparently "normal" line break heuristics don't work with CJK
(Chinese, Japanese, Korean) fonts, leading to line breaks between
arbitrary characters rather than on spaces. Adding the "word-break:
keep-all" CSS property should fix this on Firefox and on IE.
Change-Id: Ia7737dfdfc8dc4e6be2dd632f14c022d11cdd976
Bug-Url: https://bugzilla.redhat.com/1001473
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
(cherry picked from commit 1f14faf55714d1067a139ec685f92e061272b993)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.ui.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/26991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7737dfdfc8dc4e6be2dd632f14c022d11cdd976
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: host-deploy: add host ssh fingerprint to registration protocol
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: host-deploy: add host ssh fingerprint to registration protocol
......................................................................
host-deploy: add host ssh fingerprint to registration protocol
This is required to allow secure call back into node and avoid man in
the middle, we can now do this.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1090168
Change-Id: I1a9af59277b5055453159f002f19046c0051d82f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterVdsParameters.java
M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java
3 files changed, 21 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d82f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: Fix FindBugs UuF for SystemTreeSelectionChange
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Fix FindBugs UuF for SystemTreeSelectionChange
......................................................................
webadmin: Fix FindBugs UuF for SystemTreeSelectionChange
Change-Id: I83690424b1a43ddfaebc176d3fd0412c35c8381f
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/exclude-filters.xml
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83690424b1a43ddfaebc176d3fd0412c35c8381f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months