April 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.4]: sdk: No new lines in basic auth token
by juan.hernandez＠redhat.com 16 Apr '14

16 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: No new lines in basic auth token ...................................................................... sdk: No new lines in basic auth token Currently we generate the value of the basic authentication header using the "encodestring" method of the "base64" module, but the output of this method may contain many new lines, depending on the length of the user name and password. When more than one newline is included we only delete the last, and as a result we generate a header with a new line, which is interpreted by the web server as two headers, thus breaking the authentication mechanism. This patch changes the SDK so that all the new lines are removed. Change-Id: I02bb66b5bed9c152fcba95ab577373b66f19be05 Bug-Url: https://bugzilla.redhat.com/1085837 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 080a83202ffa23684d7137c462fc024e8e143859) --- M src/ovirtsdk/web/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02bb66b5bed9c152fcba95ab577373b66f19be05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Check SSL server name
by juan.hernandez＠redhat.com 16 Apr '14

16 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Check SSL server name ...................................................................... sdk: Check SSL server name Currently we don't check that the host name provided in the URL matches the host name contained in the server certificate. This is a common feature of most SSL clients, but it isn't well supported by the SSL implementation in Python 2.6. To improve security this patch explicitly checks the host name given in the URL against the subject common name attribute and the subject alternative names extension. This check will be enabled by default and disabled when using "insecure=True" in the constructor of the entry point object. Change-Id: I3fd771f1fd40e532cf1ca5649c3576e23be5a6dc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 1acc07e8baa14f48fcb88c1b57f382268cc6dc31) --- M src/ovirtsdk/web/connection.py M src/ovirtsdk/web/httpsconnection.py 2 files changed, 107 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd771f1fd40e532cf1ca5649c3576e23be5a6dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Add support for filtering kwargs on collection based pr...
by juan.hernandez＠redhat.com 16 Apr '14

16 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add support for filtering kwargs on collection based properties ...................................................................... sdk: Add support for filtering kwargs on collection based properties Enable filtering of results on restrictions for collections Change-Id: I6bc675ce9653b67396f21dd1726726294dc517d9 Bug-Url: https://bugzilla.redhat.com/902976 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 6917c3bfe44c996534158b1767bb0e3425547e68) --- M src/ovirtsdk/utils/searchhelper.py 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc675ce9653b67396f21dd1726726294dc517d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: No new lines in basic auth token
by juan.hernandez＠redhat.com 16 Apr '14

16 Apr '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: No new lines in basic auth token ...................................................................... sdk: No new lines in basic auth token Currently we generate the value of the basic authentication header using the "encodestring" method of the "base64" module, but the output of this method may contain many new lines, depending on the length of the user name and password. When more than one newline is included we only delete the last, and as a result we generate a header with a new line, which is interpreted by the web server as two headers, thus breaking the authentication mechanism. This patch changes the SDK so that all the new lines are removed. Change-Id: I02bb66b5bed9c152fcba95ab577373b66f19be05 Bug-Url: https://bugzilla.redhat.com/1085837 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/web/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02bb66b5bed9c152fcba95ab577373b66f19be05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: Add runtime log4j setup to engine-manage-domains
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Add runtime log4j setup to engine-manage-domains ...................................................................... tools: Add runtime log4j setup to engine-manage-domains 1) Moves default log4j.xml for engine-manage-domains into tools.jar 2) By default logging is off 3) Adds --log-file which sets file to write logging messages into 4) Adds --log-level which sets logging level for logger specified with --log-file (it's set to INFO by default) 5) Adds --log4j-config which sets filename or URL with custom log4j.xml file to setup logging Change-Id: I0641dd6ce8984504c8c6e97df7b90e81ca5a8c4f Bug-Url: https://bugzilla.redhat.com/1083411 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java A backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java A backend/manager/modules/builtin-extensions/src/main/resources/engine-manage-domains/log4j.xml M backend/manager/modules/builtin-extensions/src/main/resources/manage-domains-help.properties M ovirt-engine.spec.in M packaging/bin/engine-manage-domains.sh D packaging/etc/engine-manage-domains/log4j.xml.in M packaging/man/man8/engine-manage-domains.8 10 files changed, 146 insertions(+), 91 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0641dd6ce8984504c8c6e97df7b90e81ca5a8c4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Remove logging when parsing args in engine-manage-dom...
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Remove logging when parsing args in engine-manage-domains ...................................................................... tools: Remove logging when parsing args in engine-manage-domains Removes log messages when parsing args in engine-manage-domains. This is needed to enable logging setup that uses command line arguments. Change-Id: I3b1c5e76e6dbd2bc2c3d49abac03e10d4dc6faf6 Bug-Url: https://bugzilla.redhat.com/1083411 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b1c5e76e6dbd2bc2c3d49abac03e10d4dc6faf6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Add runtime log4j setup to engine-config
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Add runtime log4j setup to engine-config ...................................................................... tools: Add runtime log4j setup to engine-config 1) Moves default log4j.xml for engine-config into tools.jar 2) By default logging is off 3) Adds --log-file which sets file to write logging messages into 4) Adds --log-level which sets logging level for logger specified with --log-file (it's set to INFO by default) 5) Adds --log4j-config which sets filename or URL with custom log4j.xml file to setup logging Change-Id: I328a018ef1b714c6a90d1b219dcd326a16bcab2d Bug-Url: https://bugzilla.redhat.com/1063901 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/OptionKey.java A backend/manager/tools/src/main/resources/engine-config/log4j.xml M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java M ovirt-engine.spec.in M packaging/bin/engine-config.sh D packaging/etc/engine-config/log4j.xml.in M packaging/man/man8/engine-config.8 12 files changed, 137 insertions(+), 76 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I328a018ef1b714c6a90d1b219dcd326a16bcab2d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Remove debug log when parsing args in engine-config
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Remove debug log when parsing args in engine-config ...................................................................... tools: Remove debug log when parsing args in engine-config Removes debug log messages when parsing args in engine-config. This is needed to enable logging setup that uses command line arguments. Change-Id: I3b549b8216c3e1af2cf167fac978673c9528894d Bug-Url: https://bugzilla.redhat.com/1063901 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b549b8216c3e1af2cf167fac978673c9528894d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Remove EngineConfigCLIParser instance variable from E...
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Remove EngineConfigCLIParser instance variable from EngineConfig ...................................................................... tools: Remove EngineConfigCLIParser instance variable from EngineConfig Removes EngineConfigCLIParser instance variable from EngineConfig since it's needed only in EngineConfig.setUpAndExecute() method. Change-Id: I1390755096670c7ed21882a487280d85426e576f Bug-Url: https://bugzilla.redhat.com/1063901 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java 1 file changed, 6 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1390755096670c7ed21882a487280d85426e576f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add common methods for runtime log4j setup
by yzaslavs＠redhat.com 16 Apr '14

16 Apr '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add common methods for runtime log4j setup ...................................................................... core: Add common methods for runtime log4j setup Adds Log4jUtils class which contains methods for runtime log4j setup used in engine-config and engine-manage-domains. Change-Id: Ic00ea0af643e8c978fd67eb8c56e2329d43e776d Bug-Url: https://bugzilla.redhat.com/1063901 Bug-Url: https://bugzilla.redhat.com/1083411 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log4jUtils.java 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00ea0af643e8c978fd67eb8c56e2329d43e776d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0