Change in ovirt-engine[master]: core: deprecate old storage allocation checks.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: deprecate old storage allocation checks.
......................................................................
core: deprecate old storage allocation checks.
According to bz, deprecated existing storage allocation validations so
that new patches use the new and correct sotrage allocation checks,
until such time the old validations are all replaced in the existing code
and can be removed.
Change-Id: Ie1fc08b4375eaea0e99593938adac48c5e2d9387
Bug-Url: https://bugzilla.redhat.com/960934
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/28944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1fc08b4375eaea0e99593938adac48c5e2d9387
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine: Disallow cross-DC template creation
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Disallow cross-DC template creation
......................................................................
engine: Disallow cross-DC template creation
Now we check during creation of template whether the target cluster
lies on the same storage domain as the source VM even if the template
contains no disks.
Change-Id: I6d9943ce1fb3736f280aaecc93896fc174c6b7dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1098951
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d9943ce1fb3736f280aaecc93896fc174c6b7dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.4]: webadmin: fixed layout of total VCPUs editor
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: fixed layout of total VCPUs editor
......................................................................
webadmin: fixed layout of total VCPUs editor
The broken layout was caused by using custom styling
of the widget with info icon.
Fixed by using the standard EntityModelWidgetWithInfo widget.
Change-Id: Iadb78a9bba4c98d5189463a19471e248c2e3f902
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1105468
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
2 files changed, 20 insertions(+), 21 deletions(-)
Approvals:
Tomas Jelinek: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadb78a9bba4c98d5189463a19471e248c2e3f902
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: fix logical loop in deps
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fix logical loop in deps
......................................................................
packaging: setup: fix logical loop in deps
Change-Id: I767a574aa19be57e66ad0541d38852c953591d2f
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py
M packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I767a574aa19be57e66ad0541d38852c953591d2f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: enable <not equal> operator for tag search
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: enable <not equal> operator for tag search
......................................................................
core: enable <not equal> operator for tag search
This patch allows searching Tags with != operator.
Up to now, when "tag" is used in the search criteria, we had used
StringOnlyEqualConditionRelationAutoCompleter to validate the tag value,
this class allows only for "=" operator.
Actually, there is no reason for this limitation and we can safely
replace this class use with StringConditionRelationAutoCompleter that
allows both "=" and "!=" operators.
This makes StringOnlyEqualConditionRelationAutoCompleter unused and
therefor it was removed.
Change-Id: Icb8fd9c3f75a62841b8d89933c16ac2077c95e4d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092609
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
D backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StringOnlyEqualConditionRelationAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
4 files changed, 2 insertions(+), 19 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28280
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb8fd9c3f75a62841b8d89933c16ac2077c95e4d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: bll: remove redundant methods
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bll: remove redundant methods
......................................................................
bll: remove redundant methods
Change-Id: Id28bdd5eb845963b9cfdd85df3ea79459e7be9a0
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
3 files changed, 1 insertion(+), 30 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id28bdd5eb845963b9cfdd85df3ea79459e7be9a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: avoid update disk dynamic data gathered from disk snap...
by laravot＠redhat.com
Liron Ar has submitted this change and it was merged.
Change subject: core: avoid update disk dynamic data gathered from disk snapshot
......................................................................
core: avoid update disk dynamic data gathered from disk snapshot
When a disk snapshot is plugged to the vm, a transient image is created on the
host local storage to allow read/write to that plugged 'disk'.
Therefore when the disk related stats are recieved for a VM that a disk snapshot
is plugged to, they shouldn't be updated in the disc_image_dynamic table.
The update is avoided at the DB level as we are trying to reduce the
number of the queries in VdsUpdateRuntimeInfo (in oppose to load the
device from the db and perform the check in the engine).
Change-Id: Iaa25d040327b4cfe9b049fa2ec2638893190e8ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110830
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M packaging/dbscripts/disk_image_dynamic_sp.sql
9 files changed, 98 insertions(+), 30 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa25d040327b4cfe9b049fa2ec2638893190e8ef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-log-collector[ovirt-log-collector-3.4]: Avoid hitting performance issues with api listing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Avoid hitting performance issues with api listing
......................................................................
Avoid hitting performance issues with api listing
After BZ1025320 default is provide all results
this limits results on each iteration to page_size
Related-To: http://bugzilla.redhat.com/1025320
Change-Id: I2c3cf488df334b5dcf43904a4c67f9abcbe38f87
Signed-off-by: Pablo <Pablo.Iranzo(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1101421
(cherry picked from commit 8c2d3904eef9194d40c2247bd65ce9eee7c26c71)
---
M src/helper/hypervisors.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Pablo Iranzo Gómez: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c3cf488df334b5dcf43904a4c67f9abcbe38f87
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: Change GuestToolsSetupIsoPrefix to ovirt-guest-tools-
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: Change GuestToolsSetupIsoPrefix to ovirt-guest-tools-
......................................................................
Change GuestToolsSetupIsoPrefix to ovirt-guest-tools-
Change-Id: Iecffeb7e688ca76ec75005f966524da0f1c77bb8
Bug-Url: https://bugzilla.redhat.com/1109841
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecffeb7e688ca76ec75005f966524da0f1c77bb8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: minor refactoring in pool related commands
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor refactoring in pool related commands
......................................................................
core: minor refactoring in pool related commands
Change-Id: I34ee0c07081286b6445c732c87c105bc16ef6a66
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromPoolParameters.java
3 files changed, 41 insertions(+), 77 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/28864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34ee0c07081286b6445c732c87c105bc16ef6a66
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months