June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: RetrieveImageData - validate received response
by laravot＠redhat.com 19 Jun '14

19 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: RetrieveImageData - validate received response ...................................................................... core: RetrieveImageData - validate received response After recieving OK response validate that the received size specified in the header and the size of the data match the requested size. Change-Id: I8f27ad8349ad9c8f1e44a204a4c5bc31f9ae5c7a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f27ad8349ad9c8f1e44a204a4c5bc31f9ae5c7a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin:Fix for Gluster hook resolve conflicts popup not lo...
by kmayilsa＠redhat.com 19 Jun '14

19 Jun '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin:Fix for Gluster hook resolve conflicts popup not loading ...................................................................... webadmin:Fix for Gluster hook resolve conflicts popup not loading Fix for Gluster hook resolve conflicts popup not loading properly. The issue was with parse method getting an empty string which is not handled appropriately. Change-Id: I7c51cd249552f8cb37f2e3093a1c0ddca764b859 Signed-off-by: Karnan TC <kchidamb(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/GlusterHookResolveConflictsPopupView.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Karnan t c: Verified anmolbabu: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c51cd249552f8cb37f2e3093a1c0ddca764b859 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: config: Expose RNG related config
by ofrenkel＠redhat.com 19 Jun '14

19 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: config: Expose RNG related config ...................................................................... config: Expose RNG related config This patch exposes two config options: 1, VirtIoRngDeviceSupported: Defines whether VirtIO Random Number Generator devices is supported for given cluster level, 2, ClusterRequiredRngSourcesDefault: For UI only. Random Number Generator sources that are preselected when creating a new cluster (comma separated string of values 'random' and 'hwrng'). Change-Id: I2938e5e4b05093b4b9465929f29b8928022dd613 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/977079 --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2938e5e4b05093b4b9465929f29b8928022dd613 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: prevent running vms when rng is not supported
by ofrenkel＠redhat.com 19 Jun '14

19 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: prevent running vms when rng is not supported ...................................................................... core: prevent running vms when rng is not supported This patch prevents vms with active rng device to run when rng device is not required by cluster. This situation could possibly happen when admin deselects required rng sources on cluster level, but there are already vms with rng (with such source) created in the cluster. Change-Id: Ia67a0a9b2a000670d60e3cc362c93023ddf69f38 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 91 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia67a0a9b2a000670d60e3cc362c93023ddf69f38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: validate jboss after yum upgrade
by sbonazzo＠redhat.com 19 Jun '14

19 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate jboss after yum upgrade ...................................................................... packaging: setup: validate jboss after yum upgrade jboss may be updated while upgrading ovirt-engine, so jboss home should be checked only after upgrade. Change-Id: Ifbfde5a28ef8d2c3ed421ffe4d9b733ae5abe1be Bug-Url: https://bugzilla.redhat.com/1106392 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbfde5a28ef8d2c3ed421ffe4d9b733ae5abe1be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Vm dialog- bugs with nic naming
by alkaplan＠redhat.com 19 Jun '14

19 Jun '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Vm dialog- bugs with nic naming ...................................................................... webadmin: Vm dialog- bugs with nic naming New nic name should be- nic + the highest existing nic num + 1. Since remove from the vnics list didn't work the list contained the old nics and the naming logic didn't work. To fix the issue 'vnics' type was changed from Set to List. VmNetworkInterface is mutable and changing its fields affects hashcode and equals. The javadoc for Set says: Note: Great care must be exercised if mutable objects are used as set elements. The behavior of a set is not specified if the value of an object is changed in a manner that affects equals comparisons while the object is an element in the set. Change-Id: Ib8594a29ba9c8ed32e4a0d4f8df78212dfc9f40f Bug-Url: https://bugzilla.redhat.com/1049789 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8594a29ba9c8ed32e4a0d4f8df78212dfc9f40f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: set device to "lun" on VmInfoBuilder
by oourfali＠redhat.com 19 Jun '14

19 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: set device to "lun" on VmInfoBuilder ...................................................................... core: set device to "lun" on VmInfoBuilder When starting a virtual machine with plugged lun disk using the virtio interface set the device type to "lun" instead of "disk". The rationale behind this patch is to provide the same behavior as when the disk is hotplugged to a running virtual machine: provide the capability of using generic scsi commands on the device inside the virtual machine. Change-Id: I7ceffe36e1145d4783c94f62043dfad694fdd290 Bug-Url: https://bugzilla.redhat.com/1110687 Signed-off-by: Xavi Francisco <xfrancis(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Xavi Francisco: Verified Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ceffe36e1145d4783c94f62043dfad694fdd290 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Xavi Francisco <xfrancis(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Xavi Francisco <xfrancis(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: fix references to dialog.queryBoolean
by oourfali＠redhat.com 19 Jun '14

19 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: fix references to dialog.queryBoolean ...................................................................... packaging: setup: fix references to dialog.queryBoolean Fixed references to dialog.queryBoolean introduced in commit a24709a1 (2013-06-19) Change-Id: I94abb99e9ba4e6bebc316ccfdb6e7bb9b8031400 Bug-Url: https://bugzilla.redhat.com/1110662 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 16f4471fe7cfda9c9330f3adb672fbd93c043242) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94abb99e9ba4e6bebc316ccfdb6e7bb9b8031400 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: ensure restarted services survive reboot
by oourfali＠redhat.com 19 Jun '14

19 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: ensure restarted services survive reboot ...................................................................... packaging: setup: ensure restarted services survive reboot Ensure that hostile services restarted while upgrading are started also after reboot. Change-Id: I2333590beb9f4cabcc7eb68cbbacac85b453318d Bug-Url: https://bugzilla.redhat.com/1110307 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py 1 file changed, 19 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/28880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2333590beb9f4cabcc7eb68cbbacac85b453318d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix vmJob logging
by amureini＠redhat.com 18 Jun '14

18 Jun '14

Allon Mureinik has submitted this change and it was merged. Change subject: engine: fix vmJob logging ...................................................................... engine: fix vmJob logging Make logging more clear and less spammy for vmJobs updates made in VdsUpdateRunTimeInfo. Change-Id: I0f5a9851c347366413496fb6e6375e7d44d1a30b Bug-Url: https://bugzilla.redhat.com/1110394 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/28906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f5a9851c347366413496fb6e6375e7d44d1a30b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0