Change in ovirt-engine[master]: engine : Introduce CommandEntityCleanupManager
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Introduce CommandEntityCleanupManager
......................................................................
engine : Introduce CommandEntityCleanupManager
Introduce CommandEntityCleanupManager that
cleans old commands in command_entities table
based on a new option CommandEntityAgingThreshold
Change-Id: Ic9a5ea74513e7e56f21b2861b899e6d8868affe8
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandEntityCleanupManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 66 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a5ea74513e7e56f21b2861b899e6d8868affe8
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Collapse all Async Command Callbacks
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Collapse all Async Command Callbacks
......................................................................
engine : Collapse all Async Command Callbacks
Collapse methods in Poller and EndActionCallBack into
AsyncCommandCallBack interface.
Change-Id: I4a81f54a2a6eb989948956a73ec0e0919b8422c4
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallBack.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java
3 files changed, 5 insertions(+), 10 deletions(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a81f54a2a6eb989948956a73ec0e0919b8422c4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Modify Async_tasks table to use CommandEntity
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Modify Async_tasks table to use CommandEntity
......................................................................
engine : Modify Async_tasks table to use CommandEntity
Drop columns from async_tasks table that hold the
information about the command. AsyncTasks class
has been modified to use CommandEntity to store
the command information. When async_task is persisted,
updated/deleted the corresponding CommandEntity is also
persisted, updated/deleted
Change-Id: Ied038b514f1285b4d46deff022beafd9dcfe5c29
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncTaskCRUDOperations.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml
M packaging/dbscripts/async_tasks_sp.sql
A packaging/dbscripts/upgrade/03_05_0660_remove_command_from_async_tasks.sql
21 files changed, 560 insertions(+), 285 deletions(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied038b514f1285b4d46deff022beafd9dcfe5c29
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: vdsm: fix dmidecode parsing
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: fix dmidecode parsing
......................................................................
vdsm: fix dmidecode parsing
There is a version of dmidecode reported print #-prefixed comments, this
patch discards these lines.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109342
Change-Id: I50493c5f77f59c5bdceac2a6e8223e8ccae75b09
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
M ChangeLog
M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50493c5f77f59c5bdceac2a6e8223e8ccae75b09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: vdsmhooks: fix package installation
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsmhooks: fix package installation
......................................................................
vdsmhooks: fix package installation
Change-Id: Ibaad04786feb92c6ce94058e48ecb8d264b42975
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M src/plugins/ovirt-host-deploy/vdsmhooks/hooks.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaad04786feb92c6ce94058e48ecb8d264b42975
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.2]: vdsmhooks: engage packages at earlier state
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsmhooks: engage packages at earlier state
......................................................................
vdsmhooks: engage packages at earlier state
Change-Id: Id235935239a6f2e80cb34da3a1530b8ae63e66df
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/vdsmhooks/hooks.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id235935239a6f2e80cb34da3a1530b8ae63e66df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.2
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-host-deploy[master]: vdsm: fix dmidecode parsing
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: fix dmidecode parsing
......................................................................
vdsm: fix dmidecode parsing
There is a version of dmidecode reported print #-prefixed comments, this
patch discards these lines.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109342
Change-Id: I50493c5f77f59c5bdceac2a6e8223e8ccae75b09
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
M ChangeLog
M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50493c5f77f59c5bdceac2a6e8223e8ccae75b09
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: fix AttachStorageDomainToPool parameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: fix AttachStorageDomainToPool parameters
......................................................................
webadmin: fix AttachStorageDomainToPool parameters
In change 881c8221 the parameters for AttachStorageDomainToPool were
changed to the new class AttachStorageDomainToPoolParameters (from
StorageDomainPoolParametersBase).
One instance of StorageDomainPoolParametersBase was left unchanged
making impossible to attach a storage domain from webadmin.
Relevant error:
ERROR [org.ovirt.engine.core.bll.CommandsFactory] An exception has
occured while trying to create a command object for command
AttachStorageDomainToPool: java.lang.Rd at:
CommandsFactory.findCommandConstructor(CommandsFactory.java:169)
Change-Id: If03b45a5fc4c5e9b64e0fa88bccb2634fb97308a
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Federico Simoncelli: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If03b45a5fc4c5e9b64e0fa88bccb2634fb97308a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: aaa: API changes required for namespace support
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: API changes required for namespace support
......................................................................
aaa: API changes required for namespace support
Namespace should be used in order to optimize the search for users and
groups at the autorization providers.
Topic: AAA
Change-Id: Ibf322468bd703aa3d14fc3c11a88f2e548e7f73c
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
3 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, approved
Yair Zaslavsky: Verified
--
To view, visit http://gerrit.ovirt.org/28262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf322468bd703aa3d14fc3c11a88f2e548e7f73c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: aaa: Failure in adding users via REST-API
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: Failure in adding users via REST-API
......................................................................
aaa: Failure in adding users via REST-API
The following patch fixes both the fact that
"domain" part appeared twice in rest-api and the
the search query to ignore the domain part in the username as
it is provided in the search pattern prior to the username.
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/1102041
Change-Id: I81ce111439c1647b13ef8ec6fcad169fd5feead6
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81ce111439c1647b13ef8ec6fcad169fd5feead6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months