Change in ovirt-engine[master]: webadmin: adding ListModelRadioGroupEditor
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: adding ListModelRadioGroupEditor
......................................................................
webadmin: adding ListModelRadioGroupEditor
An editor that displays ListModel as a group of radio buttons.
Change-Id: I7a2754a1157b1be725871a57a4618404ad4b3223
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelRadioGroup.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelRadioGroupEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/RadioGroup.java
3 files changed, 303 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a2754a1157b1be725871a57a4618404ad4b3223
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine, webadmin: Permit refresh capabilities on non-operatio...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine,webadmin: Permit refresh capabilities on non-operational host
......................................................................
engine,webadmin: Permit refresh capabilities on non-operational host
Change-Id: I50a0d30a718383cf91efaf25a294e1488067057d
Bug-Url: https://bugzilla.redhat.com/1101182
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 3 insertions(+), 11 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50a0d30a718383cf91efaf25a294e1488067057d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: WebSocketProxy on a separate host
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: WebSocketProxy on a separate host
......................................................................
packaging: setup: WebSocketProxy on a separate host
The aim of this feature is to enhance the engine setup being able
to install and configure the WebSocketProxy on a second machine,
where engine does not run, as proposed at:
http://www.ovirt.org/Features/WebSocketProxy_on_a_separate_host
Change-Id: Ifceddd5aa44a77f67a3b6b30c6678d9a3b485f9c
Bug-Url: https://bugzilla.redhat.com/1080992
Bug-Url: https://bugzilla.redhat.com/985945
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/engine/config.py.in
M packaging/setup/ovirt_engine_setup/engine/constants.py
A packaging/setup/ovirt_engine_setup/websocket_proxy/__init__.py
A packaging/setup/ovirt_engine_setup/websocket_proxy/config.py.in
A packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py
M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py
M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py
A packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py
17 files changed, 639 insertions(+), 140 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Doron Fediuck: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifceddd5aa44a77f67a3b6b30c6678d9a3b485f9c
Gerrit-PatchSet: 28
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: engine-cleanup split
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: engine-cleanup split
......................................................................
packaging: setup: engine-cleanup split
Let the user decide to remove all the product
components or just some of that at cleanup.
Related-To: https://bugzilla.redhat.com/1060529
Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py
M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/ca.py
A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/engine.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py
11 files changed, 262 insertions(+), 52 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Doron Fediuck: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: Making engine configuration optional at en...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Making engine configuration optional at engine-setup
......................................................................
packaging: setup: Making engine configuration optional at engine-setup
Making engine configuration optional asking
to the user if he/she want to configure it during
engine-setup.
Skipping all the engine specific plugin if the user
doesn't want to configure the engine.
Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/selinux.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/ssl.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/macrange.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/tools.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/engine.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/selinux.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/answerfile_fixup.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
36 files changed, 397 insertions(+), 57 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Doron Fediuck: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: refactor db credentials plugins
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: refactor db credentials plugins
......................................................................
packaging: setup: refactor db credentials plugins
Move the questions for db credentials to a common place.
Before this change, db creds were always asked about. Move that to
engine so that they are asked if engine is setup.
Other components that need engine db creds should ask for them
with getCredentials.
Let components owners query for db connections credentials before
users of these components, so that users can use them if already
queried.
Use private engine db credentials consts
Change-Id: Id889c9c3ab1dcc6a873a6f5f2f60bff957e616ea
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/setup/bin/ovirt-engine-upgrade-check
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/database.py
M packaging/setup/plugins/ovirt-engine-common/base/dialog/titles.py
D packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/__init__.py
D packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py
R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/pgpass.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py
D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/__init__.py
D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/macrange.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
32 files changed, 645 insertions(+), 708 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Doron Fediuck: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/28701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id889c9c3ab1dcc6a873a6f5f2f60bff957e616ea
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Add Json Mixin to ignore VdcFault setError method
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Add Json Mixin to ignore VdcFault setError method
......................................................................
engine : Add Json Mixin to ignore VdcFault setError method
VdcFault has two setError message which cause
a Json exception when serializing and deserializing.
Add a Mixin to ignore one of the setError methods
Change-Id: I579716659ab2dc7fee19b0fcfd0b7c74199e7220
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVdcFaultMixIn.java
3 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I579716659ab2dc7fee19b0fcfd0b7c74199e7220
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Persist VdcReturnValue in CommandEntity
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Persist VdcReturnValue in CommandEntity
......................................................................
engine : Persist VdcReturnValue in CommandEntity
Add return_value and return_value class to
command_entities table
Change-Id: I35f4601fe8aceae6d98a76334c55db77097205b5
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java
M packaging/dbscripts/command_entities_sp.sql
A packaging/dbscripts/upgrade/03_05_0690_add_cmd_entity_return_value.sql
7 files changed, 67 insertions(+), 20 deletions(-)
Approvals:
Ravi Nori: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35f4601fe8aceae6d98a76334c55db77097205b5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Add quartz to handle AsycCommands
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Add quartz to handle AsycCommands
......................................................................
engine : Add quartz to handle AsycCommands
Adding a call back method checkUpdateCmdStatus
to CommandCallBack which is responsible for
updating the status of the command.
The call back method is periodically called
on commands that have not succeeded using
the quartz framework
Persisting call back and loading them on server
restart will be introduced in latter patches
Change-Id: I66b1e5945884aec412ba412e39266129004d7218
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheWrapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/MapWrapperImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BackendUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CommandStatus.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java
M packaging/dbscripts/command_entities_sp.sql
A packaging/dbscripts/upgrade/03_05_0680_add_cmd_entity_callback_notified.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
22 files changed, 403 insertions(+), 120 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, but someone else must approve
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Introduction of CommandExecutor and CommandCallBack
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Introduction of CommandExecutor and CommandCallBack
......................................................................
engine : Introduction of CommandExecutor and CommandCallBack
Introduces CommandExecutor that execute the given action with
the parameters using an ExecuterService in a seperate
thread. The results of the command execution is passed back
to the CommandCallBack interface.
Change-Id: I70922b5b836971eca76dee26ba67b7023d546fe6
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCoordinator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandScheduler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java
M packaging/dbscripts/command_entities_sp.sql
A packaging/dbscripts/upgrade/03_05_0670_add_cmd_entity_callback_enabled.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
19 files changed, 186 insertions(+), 22 deletions(-)
Approvals:
Ravi Nori: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70922b5b836971eca76dee26ba67b7023d546fe6
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months