June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: removed unneeded entityGuidList
by derez＠redhat.com 13 Jun '14

13 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: removed unneeded entityGuidList ...................................................................... core: removed unneeded entityGuidList 'entityGuidList' is not required for the client; hence, removed it from GetUnregisteredEntitiesQuery and deleted redundant parameters file. Change-Id: Id064c6ceca351364feec740bf0df6e1b616dd8ec Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredEntitiesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/UnregisteredEntitiesQueryParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java 8 files changed, 20 insertions(+), 139 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id064c6ceca351364feec740bf0df6e1b616dd8ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fix constants references
by sbonazzo＠redhat.com 13 Jun '14

13 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix constants references ...................................................................... packaging: setup: fix constants references Change-Id: I80dd5131bf086d23636c720cc978e52eee5a90b8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Verified; Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80dd5131bf086d23636c720cc978e52eee5a90b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fixing adding group
by yzaslavs＠redhat.com 13 Jun '14

13 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fixing adding group ...................................................................... aaa: Fixing adding group Change-Id: I4c72f913e2588e83b9970315de2c5f18184510bc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1108667 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SearchQueryParsingUtils.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c72f913e2588e83b9970315de2c5f18184510bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: allow customizing temp directory
by yzaslavs＠redhat.com 13 Jun '14

13 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: allow customizing temp directory ...................................................................... host-deploy: allow customizing temp directory Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1100584 Change-Id: I01999a601780790e28c5c02e0d9eee53d4fc1aa5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01999a601780790e28c5c02e0d9eee53d4fc1aa5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: RNG device final touches
by vszocs＠redhat.com 13 Jun '14

13 Jun '14

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: RNG device final touches ...................................................................... frontend: RNG device final touches This patch solves small bugs in RNG device frontend: 1: RNG device widgets are now nonchangable for vms in pools. 2: RNG sources unavailability messages were fixed. 3: In pool edit widget, RNG widgets weren't set according to backing entity. Change-Id: I60a0c620f811d74aaef1efe8f570df1a4cc74857 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/977079 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 14 insertions(+), 4 deletions(-) Approvals: Frank Kobzik: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a0c620f811d74aaef1efe8f570df1a4cc74857 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RNG device final touches
by vszocs＠redhat.com 13 Jun '14

13 Jun '14

Vojtech Szocs has submitted this change and it was merged. Change subject: core: RNG device final touches ...................................................................... core: RNG device final touches This patch deals with 2 small bugs in RNG devices: 1: When creating vm from template, RNG device was created twice (firstly from AddVmFromTemplateParams and secondly from generic device copying). Solved by checking presence of RNG device on copying vm devices. 2: When creating vm pool, RNG device couldn't be customized. This was caused by incorrect RNG propagating in AddVmAndAttachToPoolCommand. 3: Fixed enum parsing in VmRngDevice. Change-Id: I78fa8f34eeebf02f14130570b581353572b18fad Bug-Url: https://bugzilla.redhat.com/977079 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Frank Kobzik: Verified Vojtech Szocs: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78fa8f34eeebf02f14130570b581353572b18fad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fixed logging error.
by juan.hernandez＠redhat.com 13 Jun '14

13 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: fixed logging error. ...................................................................... restapi: fixed logging error. removed exception cover-up and logging to std. Change-Id: I2d23a647c1ceef2d4d248694415d2578c76047e5 Bug-Url: https://bugzilla.redhat.com/1104184 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MappingExceptionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MappingLocator.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/MappingException.java 4 files changed, 43 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Mucha: Verified -- To view, visit http://gerrit.ovirt.org/28658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d23a647c1ceef2d4d248694415d2578c76047e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: fetching principal record should always be recursive
by yzaslavs＠redhat.com 13 Jun '14

13 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fetching principal record should always be recursive ...................................................................... aaa: fetching principal record should always be recursive Change-Id: Ib315adcf9b224af0542f477bc3dde1330e9dcd77 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java 2 files changed, 0 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib315adcf9b224af0542f477bc3dde1330e9dcd77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: ovirt-node-plugin: 0.2.0-0
by dougsland＠redhat.com 13 Jun '14

13 Jun '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: ovirt-node-plugin: 0.2.0-0 ...................................................................... ovirt-node-plugin: 0.2.0-0 Increase the version on master. Change-Id: I6514503bb0c0fb526a55757223729f28f428774b Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M configure.ac M ovirt-node-plugin-vdsm.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6514503bb0c0fb526a55757223729f28f428774b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use formatter in ImportVmFromConfigurationCommand
by mlipchuk＠redhat.com 12 Jun '14

12 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use formatter in ImportVmFromConfigurationCommand ...................................................................... core: Use formatter in ImportVmFromConfigurationCommand Change-Id: I6db67cd19bf69ef3d9cf497d5d802de312009701 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6db67cd19bf69ef3d9cf497d5d802de312009701 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0