Change in ovirt-engine[master]: engine: fix exception in coco.removeAllCommandsInHierarchy
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: fix exception in coco.removeAllCommandsInHierarchy
......................................................................
engine: fix exception in coco.removeAllCommandsInHierarchy
Prevent a ConcurrentModificationException when removing command
hierarchies.
Change-Id: I8608e3ea0e0970fe70cf5fa7718560c80728f2b6
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Greg Padgett: Verified
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8608e3ea0e0970fe70cf5fa7718560c80728f2b6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: core, db: add config values for Live Merge feature
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core, db: add config values for Live Merge feature
......................................................................
core, db: add config values for Live Merge feature
Add configuration values for Live Merge, specifying the compatibility
versions for this feature.
Change-Id: I663690c7a11505aa5be2fbab14f49532e4bd3e12
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Greg Padgett: Verified
Federico Simoncelli: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/27751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I663690c7a11505aa5be2fbab14f49532e4bd3e12
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: vdsbroker: update vmJobs when updating vm statistics
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: vdsbroker: update vmJobs when updating vm statistics
......................................................................
vdsbroker: update vmJobs when updating vm statistics
Update vmJob data in the database when updating vmStats. The jobs
records are created by the initiator of the job (i.e. a command), and
then may be updated and/or removed by VdsUpdateRunTimeInfo. The job
should be run before the job placeholder is inserted into the database
in order to limit the possibility of a query being made after the
insertion but before job execution, which would result in the job being
prematurely removed from the database.
Change-Id: If1a300d440a0a93381afe047eb294106a38088ec
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 77 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Greg Padgett: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1a300d440a0a93381afe047eb294106a38088ec
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[master]: vdsbroker: read vmJobs update from getVmStats call
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: vdsbroker: read vmJobs update from getVmStats call
......................................................................
vdsbroker: read vmJobs update from getVmStats call
For Live Merge, the vmStats return value may optionally contain a list
of vmJob entries. These jobs indicate new-style async tasks that run on
the VDS. As long as the job is returned in the stats, it is not
finished. Once the job is no longer reported, the caller should query
the expected end state to determine if the task was successful.
Change-Id: I6d0ab4372fe98f8d61f4f393e2823d278f33621f
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
2 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Greg Padgett: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26905
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d0ab4372fe98f8d61f4f393e2823d278f33621f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: vdsbroker: introduce MergeVDSCommand
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: vdsbroker: introduce MergeVDSCommand
......................................................................
vdsbroker: introduce MergeVDSCommand
This command calls a new VDSM verb, merge, which will merge VM snapshots
while a VM is running.
Change-Id: I320d1ac7de50f4a24236c6d26af75a3483b8bc5e
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MergeVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
7 files changed, 183 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Greg Padgett: Verified
Federico Simoncelli: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26907
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I320d1ac7de50f4a24236c6d26af75a3483b8bc5e
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core, db: add vm_jobs table, DAO, and BE
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core, db: add vm_jobs table, DAO, and BE
......................................................................
core, db: add vm_jobs table, DAO, and BE
Add vm_jobs table and DAO for supporting Live Merge.
Change-Id: I07734d4c4026062db7a505c1212553abf0b203ac
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJob.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJobType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJob.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJobState.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJobType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmJobDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
A packaging/dbscripts/upgrade/03_05_0700_create_vm_jobs_table.sql
A packaging/dbscripts/vm_jobs_sp.sql
16 files changed, 822 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Greg Padgett: Verified
Federico Simoncelli: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/26904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07734d4c4026062db7a505c1212553abf0b203ac
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: introduce RemoveSnapshotSingleDiskLive BLL command
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: introduce RemoveSnapshotSingleDiskLive BLL command
......................................................................
core: introduce RemoveSnapshotSingleDiskLive BLL command
RemoveSnapshotCommand now has the capability to run
RemoveSnapshotSingleDiskLiveCommand for merging snapshots while a VM
is running. This new command uses the CommandExecutor framework, and
runs 3 child commands: Merge, MergeStatus, and DestroyImage.
MergeCommand starts a merge job on the host running the VM. VDSM will
report the job to us in vmStats until it completes, at which time
MergeCommand is considered finished.
MergeStatusCommand will then run to determine whether the merge was
successful, along with discovering the merge direction chosen by vdsm.
This is done by querying the VM's current volume chain.
DestroyImageCommand then removes all the now-orphaned images left
behind by the merge operation.
After the children have all finished successfully, endVmCommand on
RemoveSnapshotSingleDiskLiveCommand updates the database records to
reflect the new post-merge volume chain.
Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MergeParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MergeStatusReturnValue.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskLiveStep.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyImageVDSCommandParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
25 files changed, 1,125 insertions(+), 81 deletions(-)
Approvals:
Greg Padgett: Verified
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: Enable Delete Snapshot while VM is running
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Enable Delete Snapshot while VM is running
......................................................................
webadmin: Enable Delete Snapshot while VM is running
Support the Live Merge operation in the UI.
Change-Id: I5162b0bf83ab447a427b5376b7a0980acb7ef213
Bug-Url: https://bugzilla.redhat.com/1058160
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
5 files changed, 42 insertions(+), 3 deletions(-)
Approvals:
Ravi Nori: Verified; Looks good to me, but someone else must approve
Greg Padgett: Verified
Federico Simoncelli: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5162b0bf83ab447a427b5376b7a0980acb7ef213
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: engine : Add callback enabled commands to CommandExecutor ca...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine : Add callback enabled commands to CommandExecutor callback map
......................................................................
engine : Add callback enabled commands to CommandExecutor callback map
Add ability to add ordinary commands to command executor's
call back map. The commands need to have callback enabled
Fixed execution of Command with AsyncTasks using CommandExecutor
framework.
Change-Id: I9765a947d3772fbc47a1adaa91cd54da9ba202bb
Bug-Url: https://bugzilla.redhat.com/1083769
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
6 files changed, 84 insertions(+), 33 deletions(-)
Approvals:
Greg Padgett: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9765a947d3772fbc47a1adaa91cd54da9ba202bb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.4]: ui: fix NPE when trying to create a pool with limited permis...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: fix NPE when trying to create a pool with limited permissions
......................................................................
ui: fix NPE when trying to create a pool with limited permissions
Bug-Url: https://bugzilla.redhat.com/1105622
Change-Id: I676d5d9bf0a51e2f570f3b45d930122e58b24fcf
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shahar Havivi: Verified
--
To view, visit http://gerrit.ovirt.org/28596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I676d5d9bf0a51e2f570f3b45d930122e58b24fcf
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months