August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Ignore case in CPU architecture
by tnisan＠redhat.com 21 Aug '14

21 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Ignore case in CPU architecture ...................................................................... restapi: Ignore case in CPU architecture The validation of the CPU architecture should be done ignoring case. Change-Id: Ib06b176dcc48fac667713683bdae5b1cfe4a4332 Bug-Url: https://bugzilla.redhat.com/1129248 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 4aaf8105c673820713dd219787a7149fcc59996e) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CPUValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib06b176dcc48fac667713683bdae5b1cfe4a4332 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix incorrect value of migrating_to_vds
by tnisan＠redhat.com 21 Aug '14

21 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix incorrect value of migrating_to_vds ...................................................................... core: fix incorrect value of migrating_to_vds Since we retried to switch host to maintenance as part of the monitoring thread but before the updated data from the monitoring was saved, the migrating_to_vds could have been overridden and set back to its previous value. This bug caused NPE in VURTI#handOver method sometimes and sometimes it produced a VM which is not migrating with some wrong value in its migrating_to_vds field. The solution is to retry to switch host to maintenance in the after-refresh-treatment part of the monitoring. Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090 Bug-Url: https://bugzilla.redhat.com/1112359 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Replace JAXB version provided by JBoss
by juan.hernandez＠redhat.com 21 Aug '14

21 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Replace JAXB version provided by JBoss ...................................................................... restapi: Replace JAXB version provided by JBoss The version of the JAXB implementation provided by the application server is 2.2.4, and it contains a bug that can cause a NPE: https://java.net/jira/browse/JAXB-860 Luckily this bug isn't currently triggered by the engine, but it will be once the following patch is merged: http://gerrit.ovirt.org/30189 To avoid this issue this patch upgrades the version used by the engine and adds a module that replaces the one provided by the application server with a newer version of JAXB that isn't affected by the bug. Change-Id: I3780ed6f54316482eb5e4cb77fd58b3ec2f59847 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/com/sun/xml/bind/main/module.xml M backend/manager/modules/restapi/jaxrs/pom.xml M pom.xml 4 files changed, 85 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3780ed6f54316482eb5e4cb77fd58b3ec2f59847 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: NPE when mapping watchdog without id
by juan.hernandez＠redhat.com 21 Aug '14

21 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: NPE when mapping watchdog without id ...................................................................... restapi: NPE when mapping watchdog without id Currently the operation to add a watchdog to a VM fails if the id isn't provided, as this triggers a NPE. This adds a check to prevent that NPE. Change-Id: Ib526525b37e74e2e4d863e4418dfb852a7ca4200 Bug-Url: https://bugzilla.redhat.com/1129781 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib526525b37e74e2e4d863e4418dfb852a7ca4200 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Ignore case in CPU architecture
by juan.hernandez＠redhat.com 21 Aug '14

21 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Ignore case in CPU architecture ...................................................................... restapi: Ignore case in CPU architecture The validation of the CPU architecture should be done ignoring case. Change-Id: Ib06b176dcc48fac667713683bdae5b1cfe4a4332 Bug-Url: https://bugzilla.redhat.com/1129248 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CPUValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib06b176dcc48fac667713683bdae5b1cfe4a4332 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: getting a cert for a remote wsp via suppor...
by sbonazzo＠redhat.com 21 Aug '14

21 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: getting a cert for a remote wsp via support files ...................................................................... packaging: setup: getting a cert for a remote wsp via support files Providing support to get the certificate for a remote Websocket Proxy also via support files and not just only with copy and paste. Adding pasted cert validation and better error handling. Change-Id: I24384e213470ff521a8a3651920fef594e4d7c9d Bug-Url: https://bugzilla.redhat.com/1116017 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 1 file changed, 135 insertions(+), 41 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24384e213470ff521a8a3651920fef594e4d7c9d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Making separate WSP CSR available also in ...
by sbonazzo＠redhat.com 21 Aug '14

21 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Making separate WSP CSR available also in temp file ...................................................................... packaging: setup: Making separate WSP CSR available also in temp file Making CSR for a WebsocketProxy on a sperate host available also in a temp file. Fixing name and file permission of default cert. Change-Id: If517c577ead43e604442c7d468f034c2c8eaf276 Bug-Url: https://bugzilla.redhat.com/1115993 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 4 files changed, 32 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If517c577ead43e604442c7d468f034c2c8eaf276 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Update COW preallocated images to COW sparse
by oourfali＠redhat.com 21 Aug '14

21 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Update COW preallocated images to COW sparse ...................................................................... core: Update COW preallocated images to COW sparse Update the volume type of COW images that were imported from export domain to a block storage domain from preallocated to sparse since COW preallocated is not not a legal image configuration Change-Id: Ia50e78021369b6143c028af08742521bbdeb07fe Bug-Url: https://bugzilla.redhat.com/1132086 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0810_convert_cow_preallocated_to_cow_sparse.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia50e78021369b6143c028af08742521bbdeb07fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add REST API support for iSCSI multipathing
by mlipchuk＠redhat.com 21 Aug '14

21 Aug '14

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi: Add REST API support for iSCSI multipathing ...................................................................... restapi: Add REST API support for iSCSI multipathing Enable getting, creating, updating and removing iSCSI Bonds through REST API including adding/removing a storage target (Engine term is storage connection is a little bit misleading) and adding/removing a logical network. In case of storage target and network the "add" acts more like "attach" because its adding an already existing target or/and network to the iscsi bond. Usages: Creating a new iSCSI Bond: POST /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1 Accept: application/xml Content-type: application/xml <iscsi_bond> <name>fromRest</name> <storage_connections> <storage_connection id={storageconnection_id} /> .... </storage_connections> <networks> <network id={network_id} /> .... </networks> </iscsi_bond> Updating an iSCSI Bond, only name and description can be editing that way: PUT /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id} HTTP/1.1 Accept: application/xml Content-type: application/xml <iscsi_bond> <name>{name}</name> <description>{description}</description> </iscsi_bond> Removing an iSCSI Bond: DELETE /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id} HTTP/1.1 Getting all iSCSI Bonds for the specified datacenter: GET /api/datacenters/{datacenter_id}/iscsibonds HTTP/1.1 Accept: application/xml Content-type: application/xml Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetIscsiBondByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworksByIscsiBondIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStorageServerConnectionByIscsiBondIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddIscsiBondCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddIscsiBondParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IscsiBondResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/IscsiBondsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworkResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworksResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageServerConnection.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworkResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondNetworksResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondsResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IscsiBondMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/IscsiBondMapperTest.java 27 files changed, 1,139 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: disallow removing last profile for parent
by ahadas＠redhat.com 21 Aug '14

21 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: disallow removing last profile for parent ...................................................................... core: disallow removing last profile for parent Change-Id: Ic1b53e090f3cce4b4831af7f403e8a219e00c7b7 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 36 insertions(+), 5 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1b53e090f3cce4b4831af7f403e8a219e00c7b7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0