August 2014 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[ovirt-3.5]: Support for mapping image ids to physical devices
by vfeenstr＠redhat.com 20 Aug '14

20 Aug '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Support for mapping image ids to physical devices ...................................................................... Support for mapping image ids to physical devices This patch uses libudev through ctypes for systems providing libudev due to the instable nature of sysfs. While on RHEL5 we're using sysfs we cannot for example use it on Fedora 20 with kernel 3.15 since the serial values seem not to be exposed by sysfs. This patch extends the disks-usage message with the 'mapping' field. The value of the mapping field is an object {'$serial': {'name': '$devname'}} Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Bug-Url: https://bugzilla.redhat.com/1127607 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit 692b3ea13a7b4ea5a5426424d6aaf13a0f45ba32) --- M configure.ac M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/Makefile.el5 M ovirt-guest-agent/OVirtAgentLogic.py M scripts/Makefile.am A scripts/diskmapper/Makefile.am A scripts/diskmapper/diskmapper.el5 A scripts/diskmapper/diskmapper.libudev 11 files changed, 239 insertions(+), 5 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Support for mapping image ids to physical devices
by vfeenstr＠redhat.com 20 Aug '14

20 Aug '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Support for mapping image ids to physical devices ...................................................................... Support for mapping image ids to physical devices This patch uses libudev through ctypes for systems providing libudev due to the instable nature of sysfs. While on RHEL5 we're using sysfs we cannot for example use it on Fedora 20 with kernel 3.15 since the serial values seem not to be exposed by sysfs. This patch extends the disks-usage message with the 'mapping' field. The value of the mapping field is an object {'$serial': {'name': '$devname'}} Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Bug-Url: https://bugzilla.redhat.com/1127607 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M configure.ac M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/Makefile.el5 M ovirt-guest-agent/OVirtAgentLogic.py M scripts/Makefile.am A scripts/diskmapper/Makefile.am A scripts/diskmapper/diskmapper.el5 A scripts/diskmapper/diskmapper.libudev 11 files changed, 239 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8961b3703703df573dbf2f0fca2143b463ae76b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: engine vdc error codes for vdsm sparsify
by amureini＠redhat.com 20 Aug '14

20 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: engine vdc error codes for vdsm sparsify ...................................................................... core: engine vdc error codes for vdsm sparsify VDSM virt-sparsify integration added two new errors in storage_exception.py. This patch adds the respective errors on the engine side. Change-Id: If787a4980d6a01bb58ad1646e38ef08090b59f37 Signed-off-by: Utkarsh <utkarshsins(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Utkarsh Singh: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If787a4980d6a01bb58ad1646e38ef08090b59f37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <utkarshsins(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Utkarsh Singh <utkarshsins(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: ENTER does not execute default command
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: ENTER does not execute default command ...................................................................... webadmin: ENTER does not execute default command Pressing the enter key does not execute the default command for all models that extend SearchableListModel Change-Id: I4ebfa08d2d3bcd0d2089febbe19e54c76cef25ec Bug-Url: https://bugzilla.redhat.com/1126324 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionStackPanelItem.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java 5 files changed, 16 insertions(+), 14 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ebfa08d2d3bcd0d2089febbe19e54c76cef25ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[sdk_3.5]: codegen: Disconnect-at-constructor only if proxy found
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Disconnect-at-constructor only if proxy found ...................................................................... codegen: Disconnect-at-constructor only if proxy found Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Related: https://bugzilla.redhat.com/996021 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit c625968c014cbf00535c83fad2e960a9597615e3) --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointTemplate 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Disconnect-at-constructor only if proxy found
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Disconnect-at-constructor only if proxy found ...................................................................... codegen: Disconnect-at-constructor only if proxy found Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Related: https://bugzilla.redhat.com/996021 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointTemplate 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: shorten columns on Network->Hosts sub tab
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: shorten columns on Network->Hosts sub tab ...................................................................... webadmin: shorten columns on Network->Hosts sub tab Shortened- 1) Column Network Device Shortened and remaned- 1) "Network Device Speed"->"Speed (Mbps)" 2) "Network Device Rx (Mbps)"->"Receive (Mbps)" 3) "Network Device Tx (Mbps)"->"Transmit (Mbps)" Change-Id: I5e23d51e76ac0aba9b4b253fa04b03a0c8cb5da7 Bug-Url: https://bugzilla.redhat.com/1108062 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 2 files changed, 10 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e23d51e76ac0aba9b4b253fa04b03a0c8cb5da7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: shorten column VLAN tag on Networks main Tab
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: shorten column VLAN tag on Networks main Tab ...................................................................... webadmin: shorten column VLAN tag on Networks main Tab Change-Id: I7b08ce09cc2899a049c48d713f9457a09b41218b Bug-Url: https://bugzilla.redhat.com/1108072 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b08ce09cc2899a049c48d713f9457a09b41218b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fixes layout of profiles instance type editor in v...
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixes layout of profiles instance type editor in vm dialog ...................................................................... webadmin: fixes layout of profiles instance type editor in vm dialog Change-Id: I329ccb7b15e1b3252659faf8151648318f05b39d Bug-Url: https://bugzilla.redhat.com/1129194 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit 234d5ee401ab5f6a627dded5cc54826dd4cfddd7) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329ccb7b15e1b3252659faf8151648318f05b39d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Host->Interfaces, shorten column width
by tnisan＠redhat.com 20 Aug '14

20 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Host->Interfaces, shorten column width ...................................................................... webadmin: Host->Interfaces, shorten column width Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9 Bug-Url: https://bugzilla.redhat.com/1115310 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit 2a030983cd44fb3960829c1ab144f0e45b156966) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java 5 files changed, 24 insertions(+), 24 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0