October 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: restapi: Don't extend "ReadOnlyDevices" in "Devices"

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't extend "ReadOnlyDevices" in "Devices" ...................................................................... restapi: Don't extend "ReadOnlyDevices" in "Devices" Currently the "Devices" resource extends the "ReadOnlyDevices" resource, which is kind of contradictory, it is like saying that any device is a read only device, which is conceptually wrong. This patch removes this usage. Change-Id: I608375dabee3cbaa7d477c6ba6951eec90889302 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DevicesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java 2 files changed, 8 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I608375dabee3cbaa7d477c6ba6951eec90889302 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Remove the read only NIC resources and tests

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove the read only NIC resources and tests ...................................................................... restapi: Remove the read only NIC resources and tests As they aren't used. Change-Id: I9a0904f090a1c2114f29b05b8df6f5d72220a812 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResource.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicResourceTest.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyNicsResourceTest.java 3 files changed, 0 insertions(+), 176 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a0904f090a1c2114f29b05b8df6f5d72220a812 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Don't use "ReadOnlyDeviceResource" in storage domai...

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't use "ReadOnlyDeviceResource" in storage domain disks ...................................................................... restapi: Don't use "ReadOnlyDeviceResource" in storage domain disks The interfaces corresponding to the storage domain disks collection extends the generic "ReadOnlyDeviceResource" interface. This generic interface is an obstable for the introduction of the new service model. This patch changes the storage domain disks collection so that it doesn't use that interface. Change-Id: I290877806fe0cf2def9dd18c4ce7d387332ac5fa Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainContentDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResource.java 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I290877806fe0cf2def9dd18c4ce7d387332ac5fa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: tools: Fix issue with adding permission for manage-domains user

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: tools: Fix issue with adding permission for manage-domains user ...................................................................... tools: Fix issue with adding permission for manage-domains user Option --add-permissions in engine-manage-domains was removed, because user LDAP user specified during engine-manage-domains execution should be used only to access LDAP server and not as an oVirt administrator. Change-Id: Ief31a99408706ee7a4974c93b63043c64f020d2b Bug-Url: https://bugzilla.redhat.com/1268076 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java M backend/manager/modules/builtin-extensions/src/main/resources/manage-domains-help.properties M backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties M packaging/man/man8/engine-manage-domains.8 5 files changed, 11 insertions(+), 37 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Martin Peřina: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief31a99408706ee7a4974c93b63043c64f020d2b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: db: Undo removal of valid config values

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: db: Undo removal of valid config values ...................................................................... db: Undo removal of valid config values Undoes removal of config values, which are still valid for 3.6, but they have already been removed from master. The issue was cause by backporting patch I062b6c9df0f812e3e36cdfed36854dddb045c62d. Change-Id: Id5ed8fb8b9df0d3e88de21063e09c23647e16ad7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269796 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/upgrade/03_06_1870_delete_deprecated_config_values.sql 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5ed8fb8b9df0d3e88de21063e09c23647e16ad7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: minor refactoring in StopVmCommandBase

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in StopVmCommandBase ...................................................................... core: minor refactoring in StopVmCommandBase 1. Remove unneeded part in log message 2. Organize the endVmCommand method to be more concise Change-Id: Ib5b5183b89fe9d256a4a36a4fae6419737e7c656 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 1 file changed, 7 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/43620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b5183b89fe9d256a4a36a4fae6419737e7c656 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6.0]: Revert "core: reduce log level for policy reset"

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: Revert "core: reduce log level for policy reset" ...................................................................... Revert "core: reduce log level for policy reset" This reverts commit 6a1784c54f8624ec3225d8831b4be32ac3674a51. Since the referenced bug wasn't an approved blocker. Bug-Url: https://bugzilla.redhat.com/1253230 Change-Id: I51b1c1c9ed3304b281e7607b9b34f7a5f47ef1c3 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 3 files changed, 4 insertions(+), 15 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51b1c1c9ed3304b281e7607b9b34f7a5f47ef1c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: fix NPE on scheduler when policy filters is null

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: fix NPE on scheduler when policy filters is null ...................................................................... core: fix NPE on scheduler when policy filters is null Patch NPE exception if there are no filters. Fix for patch https://gerrit.ovirt.org/#/c/44244/ Change-Id: I9f121d6f78c0aaea98d4008ff71f3e5f3f6fb0fc Bug-Url: http://bugzilla.redhat.com/1256238 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Roy Golan: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/44610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f121d6f78c0aaea98d4008ff71f3e5f3f6fb0fc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: display Disk Snapshot ID on cinder domains

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: display Disk Snapshot ID on cinder domains ...................................................................... webadmin: display Disk Snapshot ID on cinder domains Storage main-tab (Cinder domain) -> Disk Snapshots: display 'Disk Snapshot ID'. Change-Id: Ief87ca63cac131a12c20eb2e4d8b7aa61f37dc1e Bug-Url: https://bugzilla.redhat.com/1273405 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief87ca63cac131a12c20eb2e4d8b7aa61f37dc1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: distingish guest-os only architectures

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: distingish guest-os only architectures ...................................................................... core: distingish guest-os only architectures The mixing of architecture types that are used for both hosts and guests with these that are used only for guests within the same enumeration is confusing. Therefore, this patch adds a documentation on each type that indicates to which group it belongs. Change-Id: Ibba669bf7c46454eaf43bc33408819cef7aa12f3 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba669bf7c46454eaf43bc33408819cef7aa12f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 2 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2015