October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: instance images - correct size for Cinder disks
by derez＠redhat.com 22 Oct '15

22 Oct '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: instance images - correct size for Cinder disks ...................................................................... webadmin: instance images - correct size for Cinder disks New/Edit VM dialog: Cinder disks size should be formatted similarly to Images (using 'getSizeInGigabytes' method). Change-Id: Iaadee356fabd7f2121e2422746ab3cb2d111670a Bug-Url: https://bugzilla.redhat.com/1273950 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/47635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaadee356fabd7f2121e2422746ab3cb2d111670a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove old PersistentSetupNetworksCommand
by alkaplan＠redhat.com 22 Oct '15

22 Oct '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Remove old PersistentSetupNetworksCommand ...................................................................... engine: Remove old PersistentSetupNetworksCommand Change-Id: I0f42287f127f8bf6540d0e9bf1591ce64a52383c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentSetupNetworksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 1 insertion(+), 292 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f42287f127f8bf6540d0e9bf1591ce64a52383c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Adjust Attach/Detach network to use HostSetupNetwork...
by alkaplan＠redhat.com 22 Oct '15

22 Oct '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust Attach/Detach network to use HostSetupNetworksCommand ...................................................................... engine: Adjust Attach/Detach network to use HostSetupNetworksCommand Instead of the old SetupNetworkCommand. Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: I263264d436a20aa065c6c4432dc0887eaf71f04b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 13 files changed, 160 insertions(+), 229 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I263264d436a20aa065c6c4432dc0887eaf71f04b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: PersistentSetupNetworks audit log fix
by alkaplan＠redhat.com 22 Oct '15

22 Oct '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: PersistentSetupNetworks audit log fix ...................................................................... engine: PersistentSetupNetworks audit log fix The audit log should display the networks names only if they were passed to it as parameters. It shouldn't try to calculate the names of the changed networks. It causes bugs and doesn't have a big added value. Change-Id: Ib6fee08f46f5b79e78f94fda1b3f4440898f5a2e Bug-Url: https://bugzilla.redhat.com/1242236 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunction.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunctionTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 11 insertions(+), 102 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6fee08f46f5b79e78f94fda1b3f4440898f5a2e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove/UpdateNetwork should invoke new setup network...
by alkaplan＠redhat.com 22 Oct '15

22 Oct '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Remove/UpdateNetwork should invoke new setup networks command ...................................................................... engine: Remove/UpdateNetwork should invoke new setup networks command Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: I6fcaae1ea21372a3a521603b365dcd45c6f64803 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 8 files changed, 179 insertions(+), 229 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fcaae1ea21372a3a521603b365dcd45c6f64803 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: adjust ChangeVDSClusterCommand to use new HostSetupN...
by alkaplan＠redhat.com 22 Oct '15

22 Oct '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adjust ChangeVDSClusterCommand to use new HostSetupNetworks ...................................................................... engine: adjust ChangeVDSClusterCommand to use new HostSetupNetworks Bug-Url: https://bugzilla.redhat.com/1242236 Change-Id: Ice16351176e5547f11f7368cf3bc190da957597c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/HostSetupNetworksParametersBuilder.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java 5 files changed, 340 insertions(+), 73 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice16351176e5547f11f7368cf3bc190da957597c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.0_rc3
by sbonazzo＠redhat.com 22 Oct '15

22 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.0_rc3 ...................................................................... build: ovirt-live-3.6.0_rc3 Change-Id: I1268f35eafef8289ff6de9be82a748d1e3271e9f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1268f35eafef8289ff6de9be82a748d1e3271e9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: display Disk Snapshot ID on cinder domains
by derez＠redhat.com 22 Oct '15

22 Oct '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: display Disk Snapshot ID on cinder domains ...................................................................... webadmin: display Disk Snapshot ID on cinder domains Storage main-tab (Cinder domain) -> Disk Snapshots: display 'Disk Snapshot ID'. Change-Id: Ief87ca63cac131a12c20eb2e4d8b7aa61f37dc1e Bug-Url: https://bugzilla.redhat.com/1273405 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief87ca63cac131a12c20eb2e4d8b7aa61f37dc1e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: old SetupNetworks fix.
by tnisan＠redhat.com 22 Oct '15

22 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: old SetupNetworks fix. ...................................................................... core: old SetupNetworks fix. when creating new bond with VLAN using old setupnetworks command, base nic is calculated and cannot be found in db, because it wasn't created yet. NPE was produced, when trying to find NetworkAttachment using ID of inexisting nic. Check was added so code does not try to find such NetworkAttachment in such scenario. Consequence is, that it there's QOS defined on NetworkAttachment, it won't be applied. However this is not regression since this command is deprecated and never supported overridding QOS. Bug-Url: https://bugzilla.redhat.com/1271524 Change-Id: I9a2db946352bbd02eaa2dd64b98badd71050b6d3 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> (cherry picked from commit 1e081274a7034ce137f9346dcafc9240cbaa784b) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a2db946352bbd02eaa2dd64b98badd71050b6d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: fix template's disk volume info
by tnisan＠redhat.com 22 Oct '15

22 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: fix template's disk volume info ...................................................................... backend: fix template's disk volume info Commit 92665e0af829d25273d5d45669847569eae6f5cc introduced the ability to specify a template disk's format when creating it. However, if the format was not specified, it defaulted to the active image's format. This behavior, although not entirely a bad idea (as it prefers thin provisioning over prealloaction, which may in fact be the best practice for template disks), is inconsistent with previous versions' behavior, and could be considered a behavioral regression. This patch restores the original behavior of matching the template disk's format with the format of the base image of the disk its derived from, unless it's explicitly specified, of course. Change-Id: I7a976c157eb0dbab4fd311a2ae60a57f6c88f4f0 Bug-Url: https://bugzilla.redhat.com/1257240 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/47579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a976c157eb0dbab4fd311a2ae60a57f6c88f4f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0