Change in ovirt-engine[master]: core: old SetupNetworks fix.
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: old SetupNetworks fix.
......................................................................
core: old SetupNetworks fix.
when creating new bond with VLAN using old setupnetworks command, base
nic is calculated and cannot be found in db, because it wasn't created
yet. NPE was produced, when trying to find NetworkAttachment
using ID of inexisting nic. Check was added so code does not try to
find such NetworkAttachment in such scenario. Consequence is, that it
there's QOS defined on NetworkAttachment, it won't be applied. However
this is not regression since this command is deprecated and never
supported overridding QOS.
Bug-Url: https://bugzilla.redhat.com/1271524
Change-Id: I9a2db946352bbd02eaa2dd64b98badd71050b6d3
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47551
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a2db946352bbd02eaa2dd64b98badd71050b6d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: adding separators lines on Host Network Interfaces...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adding separators lines on Host Network Interfaces subtab
......................................................................
webadmin: adding separators lines on Host Network
Interfaces subtab
Change-Id: I7e76ea442b5a06326f65f8e2603b58c07f3b9d45
Bug-Url: https://bugzilla.redhat.com/1140634
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Eliraz Levi: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e76ea442b5a06326f65f8e2603b58c07f3b9d45
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: exttool: do not initialize disabled extensions
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: exttool: do not initialize disabled extensions
......................................................................
exttool: do not initialize disabled extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1273789
Change-Id: I8fd8ca3a37e204f5303287e22d89ce7c83a6a444
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Ondra Machacek: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47564
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fd8ca3a37e204f5303287e22d89ce7c83a6a444
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: CreateCinderSnapshot failure flow - fix NPE
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: CreateCinderSnapshot failure flow - fix NPE
......................................................................
core: CreateCinderSnapshot failure flow - fix NPE
CreateCinderSnapshotCommandCallback -> onFailed:
'getDiskId' method shouldn't be invoked before setting
the 'cmdId' (to avoid an NPE on getCommand).
Change-Id: I5a95af5f7999e33a638a00348b269c35c3972ce4
Bug-Url: https://bugzilla.redhat.com/1273572
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a95af5f7999e33a638a00348b269c35c3972ce4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Don't use generic interfaces for template disks
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't use generic interfaces for template disks
......................................................................
restapi: Don't use generic interfaces for template disks
This patch removes the usage of generic interfaces for the template
disks resource, as they make the code very difficult to refactor.
Change-Id: I5d479c5597d61534872ce0d2817affbb70a94d01
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDeviceResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java
D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDiskResourceTest.java
D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java
11 files changed, 213 insertions(+), 318 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47539
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d479c5597d61534872ce0d2817affbb70a94d01
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: backend: fix template's disk volume info
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: fix template's disk volume info
......................................................................
backend: fix template's disk volume info
Commit 92665e0af829d25273d5d45669847569eae6f5cc introduced the ability
to specify a template disk's format when creating it. However, if the
format was not specified, it defaulted to the active image's format.
This behavior, although not entirely a bad idea (as it prefers thin
provisioning over prealloaction, which may in fact be the best practice
for template disks), is inconsistent with previous versions' behavior,
and could be considered a behavioral regression.
This patch restores the original behavior of matching the template
disk's format with the format of the base image of the disk its derived
from, unless it's explicitly specified, of course.
Change-Id: I7a976c157eb0dbab4fd311a2ae60a57f6c88f4f0
Bug-Url: https://bugzilla.redhat.com/1257240
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/47475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a976c157eb0dbab4fd311a2ae60a57f6c88f4f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: scheduler: Enable CDI for policy units
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduler: Enable CDI for policy units
......................................................................
scheduler: Enable CDI for policy units
Whit this patch it is possible to use injections in policy units. The
CPUPolicyUnit now uses CDI as a proof of concept.
Change-Id: Ia406e6fb8b33a0938cb633f59d30d995f6218bf7
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CPUPolicyUnit.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CPUPolicyUnitTest.java
3 files changed, 135 insertions(+), 7 deletions(-)
Approvals:
Dudi Maroshi: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46164
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia406e6fb8b33a0938cb633f59d30d995f6218bf7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: engine : After an command is finished tasks are not cleared ...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine : After an command is finished tasks are not cleared and stay in executing status
......................................................................
engine : After an command is finished tasks are not cleared and stay in executing status
Tasks are not being updated to FINISHED status
after completion execution.
Change-Id: I37bf0926432b4ea592c47ec9e61c093d7ecbd55f
Bug-Url: https://bugzilla.redhat.com/1273447
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37bf0926432b4ea592c47ec9e61c093d7ecbd55f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: CreateCinderSnapshot failure flow - fix NPE
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: CreateCinderSnapshot failure flow - fix NPE
......................................................................
core: CreateCinderSnapshot failure flow - fix NPE
CreateCinderSnapshotCommandCallback -> onFailed:
'getDiskId' method shouldn't be invoked before setting
the 'cmdId' (to avoid an NPE on getCommand).
Change-Id: I5a95af5f7999e33a638a00348b269c35c3972ce4
Bug-Url: https://bugzilla.redhat.com/1273572
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a95af5f7999e33a638a00348b269c35c3972ce4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6.0]: core: reduce log level for policy reset
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: reduce log level for policy reset
......................................................................
core: reduce log level for policy reset
During setup networks we reset connection policy to let configure
network over the network. Information about the reset was logged as
error which was confusing.
Change-Id: I851c1b3026dc48d335a2ccaf2ee5ff9bc1410c33
Bug-Url: https://bugzilla.redhat.com/1253230
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I851c1b3026dc48d335a2ccaf2ee5ff9bc1410c33
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.0
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months