Change in ovirt-hosted-engine-ha[master]: upgrade: specifically check if still attached to bootstrap SP
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: specifically check if still attached to bootstrap SP
......................................................................
upgrade: specifically check if still attached to bootstrap SP
On upgrade we are checking if the hosted-engine storage
domain is attached to a storage pool to check if we need
to detach to let the engine import.
This is not correct cause once the engine imports the
hosted-engine storage domain it will attach it to its
datacenter SP so this patch will explictly check if
the hosted-engine SP is still attached to its 3.5
bootstrap SP.
Bug-Url: https://bugzilla.redhat.com/1281539
Change-Id: Ia50f50c548fea573f659ef54dd29b7bddd3bd94a
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia50f50c548fea573f659ef54dd29b7bddd3bd94a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: GetUnregisteredBlockStorageDomainsQuery lambdas
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetUnregisteredBlockStorageDomainsQuery lambdas
......................................................................
core: GetUnregisteredBlockStorageDomainsQuery lambdas
Replace usage of LinqUtils with the standard Java 8 streaming APIs.
Change-Id: I0d6ab64903dcbe0ec591bf6b9d8de63795ed93c5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java
1 file changed, 7 insertions(+), 20 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d6ab64903dcbe0ec591bf6b9d8de63795ed93c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: GetUnregisteredBlockStorageDomainsQuery init
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetUnregisteredBlockStorageDomainsQuery init
......................................................................
core: GetUnregisteredBlockStorageDomainsQuery init
Removed redundant initializers.
Change-Id: Idfe7b0ef1733dfd09866ea4531d5aacd21af3d15
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48582
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idfe7b0ef1733dfd09866ea4531d5aacd21af3d15
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: floor max memory available to 0, if negative.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: floor max memory available to 0, if negative.
......................................................................
packaging: setup: floor max memory available to 0, if negative.
Change-Id: I409d9633a4246d40398fd7b07f70a29d9fb38adf
Bug-Url: https://bugzilla.redhat.com/1268373
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
(cherry picked from commit c29b8a13edef3f571ed9660fdd0e3a2c2b8b5dbc)
---
M src/plugins/ovirt-hosted-engine-setup/vm/memory.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I409d9633a4246d40398fd7b07f70a29d9fb38adf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: restapi: Generate Action XML types
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Generate Action XML types
......................................................................
restapi: Generate Action XML types
Currently the Action XML type is defined in the XML schema, in the
api.xsd file. This type is basically the union of two groups of
elements: ActionParameterGroup and ActionResponseGroup. The first is the
union of all the input parameters of all the action methods. The second
is the union of all the output parameters of all the action methods.
This patch removes all the Action related XML types from the api.xsd
file and changes the schema generator so that it generates them from the
model. The specifications of the parameters are also moved to the
corresponding service interfaces.
For example, the action to migrate a virtual machine uses a "force"
parameter that is currently defined in the XML schema as follows:
<!-- should migration be forced if VM is pinned to host? -->
<xs:element name="force" type="xs:boolean" minOccurs="0"/>
This patch moves it to the definition of the virtual machine service,
the VmService interface, where it is specified as follows:
@Type
public interface VmService {
interface Migrate {
/**
* Indicates if migration should be forced if VM is
* pinned to host.
*/
@In Boolean force();
}
}
The schema generator collects the parameters of all the services and
generates the ActionParameterGroup and ActionResponseGroup from that.
Change-Id: I581f98794c21e6c03df897d3415dfbc55d1820a8
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnalyzer.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Attribute.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Link.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Method.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Parameter.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/StructType.java
M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Type.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JaxrsNames.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java
M backend/manager/modules/restapi/model/src/main/java/services/DiskService.java
M backend/manager/modules/restapi/model/src/main/java/services/ExternalProviderService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostNicService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostNicsService.java
M backend/manager/modules/restapi/model/src/main/java/services/HostService.java
M backend/manager/modules/restapi/model/src/main/java/services/ImageService.java
M backend/manager/modules/restapi/model/src/main/java/services/JobService.java
M backend/manager/modules/restapi/model/src/main/java/services/SnapshotService.java
M backend/manager/modules/restapi/model/src/main/java/services/StepService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainTemplateService.java
M backend/manager/modules/restapi/model/src/main/java/services/StorageDomainVmService.java
M backend/manager/modules/restapi/model/src/main/java/services/TemplateService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmGraphicsConsoleService.java
M backend/manager/modules/restapi/model/src/main/java/services/VmService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterBrickService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterBricksService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterHookService.java
M backend/manager/modules/restapi/model/src/main/java/services/gluster/GlusterVolumeService.java
M backend/manager/modules/restapi/model/src/main/java/services/openstack/OpenstackImageService.java
31 files changed, 505 insertions(+), 180 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48467
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I581f98794c21e6c03df897d3415dfbc55d1820a8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: db:fixing erroneous formatting
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db:fixing erroneous formatting
......................................................................
db:fixing erroneous formatting
This patch fixing formatting patch error turning conditions with "&&"
to "& &"
Change-Id: Ie56428ca597898100526ab20c0b7aa6cb81e8684
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/storages_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie56428ca597898100526ab20c0b7aa6cb81e8684
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in jenkins[master]: renamed 3.6.1.x to 3.6.1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: renamed 3.6.1.x to 3.6.1
......................................................................
renamed 3.6.1.x to 3.6.1
Change-Id: I9fe98d7c0f87f29284c5dcd952796d5e87504403
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml
M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/48744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fe98d7c0f87f29284c5dcd952796d5e87504403
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: floor max memory available to 0, if negative.
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: floor max memory available to 0, if negative.
......................................................................
packaging: setup: floor max memory available to 0, if negative.
Change-Id: I409d9633a4246d40398fd7b07f70a29d9fb38adf
Bug-Url: https://bugzilla.redhat.com/1268373
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/memory.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I409d9633a4246d40398fd7b07f70a29d9fb38adf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: validate available memory for virtual machine
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: validate available memory for virtual machine
......................................................................
packaging: setup: validate available memory for virtual machine
Change-Id: I87d60c3f1149be2d33bf187934b5a31c17138edf
Bug-Url: https://bugzilla.redhat.com/1268373
Bug-Url: https://bugzilla.redhat.com/1283141
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
M src/plugins/ovirt-hosted-engine-setup/vm/memory.py
3 files changed, 123 insertions(+), 81 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87d60c3f1149be2d33bf187934b5a31c17138edf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: restapi: Add GET and HEAD methods to the system resource
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add GET and HEAD methods to the system resource
......................................................................
restapi: Add GET and HEAD methods to the system resource
The "SystemResource" interface generated by the JAX-RS code generator
doesn't include the following two methods:
@GET
Response get();
@HEAD
Response head();
Instead of that the methods and the annotations are part of the
implementation class. In previous versions of Resteasy this worked
correctly, but in the newer version included in WildFly the annotations
aren't recognized. As a result requests to /ovirt-engine/api return
nothing.
To solve this issue this patch changes the JAX-RS code generator so that
it explicitly adds these two methods to the "SystemResource" interface.
Change-Id: I7a0dfa3bb7e3d7a3087580e79d2fe576a2daec34
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/JaxrsGenerator.java
2 files changed, 22 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Sharon Naftaly: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a0dfa3bb7e3d7a3087580e79d2fe576a2daec34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months