November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: logging: improving logging capabilities
by msivak＠redhat.com 18 Nov '15

18 Nov '15

Martin Sivák has submitted this change and it was merged. Change subject: logging: improving logging capabilities ...................................................................... logging: improving logging capabilities Improving logging capabilities if consumed by an external tool with its own logging framework. Change-Id: I6eaa9289aae64b1ffab6ff0c071d21d9289ea93d Bug-Url: https://bugzilla.redhat.com/1278725 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 82 insertions(+), 43 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48175 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eaa9289aae64b1ffab6ff0c071d21d9289ea93d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: drop all-in-one feature
by sbonazzo＠redhat.com 18 Nov '15

18 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: drop all-in-one feature ...................................................................... packaging: setup: drop all-in-one feature All-in-One which was deprecated in 3.6 should be dropped in favor of Hosted Engine. Change-Id: Ie013fa5f945f62c7689c8db648fa74fed7c8c99f Bug-Url: https://bugzilla.redhat.com/1282798 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in D packaging/firewalld/aio/ovirt-aio.xml.in M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/__init__.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/cpu.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/firewall.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/sshd.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/storage.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsmi.py 12 files changed, 1 insertion(+), 1,341 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie013fa5f945f62c7689c8db648fa74fed7c8c99f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: VFs that are a slaves of a bond, shouldn't considere...
by alkaplan＠redhat.com 18 Nov '15

18 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: VFs that are a slaves of a bond, shouldn't considered as free ...................................................................... engine: VFs that are a slaves of a bond, shouldn't considered as free Change-Id: I4a69cfd31bd7a612b7555bc5bc3f82ff0fb808fe Bug-Url:https://bugzilla.redhat.com/1258233 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java 2 files changed, 41 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a69cfd31bd7a612b7555bc5bc3f82ff0fb808fe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make SUPPORTED_DOMAIN_TYPES package protected
by rgolan＠redhat.com 17 Nov '15

17 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Make SUPPORTED_DOMAIN_TYPES package protected ...................................................................... core: Make SUPPORTED_DOMAIN_TYPES package protected This is needed to avoid the following Findbugs warning: Field should be package protected A mutable static field could be changed by malicious code or by accident. The field could be made package protected to avoid this vulnerability. Bug kind and pattern: MS - MS_PKGPROTECT Change-Id: Iffac6d6ed8735106364e73924d12333f713e2db5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffac6d6ed8735106364e73924d12333f713e2db5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: engine_page: Improve error handling during registration
by dougsland＠redhat.com 17 Nov '15

17 Nov '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Improve error handling during registration ...................................................................... engine_page: Improve error handling during registration Replace the split call to a better string output handling. Change-Id: I3c4204fcd4674d1b4b7afc3043f139b7f1c870ea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1272216 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/47386 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> Tested-by: Fabian Deutsch <fabiand(a)redhat.com> (cherry picked from commit 16b12db3971887005f5d8123613f491095ddf938) Reviewed-on: https://gerrit.ovirt.org/48688 --- M src/engine_page.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c4204fcd4674d1b4b7afc3043f139b7f1c870ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Improve error handling during registration
by fabiand＠redhat.com 17 Nov '15

17 Nov '15

Fabian Deutsch has submitted this change and it was merged. Change subject: engine_page: Improve error handling during registration ...................................................................... engine_page: Improve error handling during registration Replace the split call to a better string output handling. Change-Id: I3c4204fcd4674d1b4b7afc3043f139b7f1c870ea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1272216 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/47386 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> Tested-by: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c4204fcd4674d1b4b7afc3043f139b7f1c870ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: kickstart: add ovirt-engine-setup-plugin-live
by sbonazzo＠redhat.com 17 Nov '15

17 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: kickstart: add ovirt-engine-setup-plugin-live ...................................................................... kickstart: add ovirt-engine-setup-plugin-live Change-Id: Iee80539b8e9391d647dc0c6631094174a6341e72 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee80539b8e9391d647dc0c6631094174a6341e72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: eliminate CDA on export RAM snapshot
by tnisan＠redhat.com 17 Nov '15

17 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: eliminate CDA on export RAM snapshot ...................................................................... core: eliminate CDA on export RAM snapshot Change the canDoAction method of CopyImageGroupCommand to return true in case the disk to be copied does not exist in the database. Otherwise, export of memory volumes (both metadata and memory dump), that do not exist in the database, cannot be exported. Change-Id: I06327acfc290975dbac6630caa19b301457f6376 Bug-Url: https://bugzilla.redhat.com/1282239 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/48666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06327acfc290975dbac6630caa19b301457f6376 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: nicer error messages about pg conf
by sbonazzo＠redhat.com 17 Nov '15

17 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: nicer error messages about pg conf ...................................................................... packaging: setup: nicer error messages about pg conf Add location of postgresql.conf to error messages about it. Change-Id: I1a27d8dd936cc945d879140c6b2a8be6808143c0 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 21 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/44268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a27d8dd936cc945d879140c6b2a8be6808143c0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: packaging: ovirt-engine-setup-plugin-live
by sbonazzo＠redhat.com 17 Nov '15

17 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-engine-setup-plugin-live ...................................................................... packaging: ovirt-engine-setup-plugin-live Change-Id: Id1d8bffc5a1955f8ee54f48304d6827c99f4e548 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.req M automation/build-artifacts.sh M automation/check-patch.req M automation/check-patch.sh D fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/__init__.py D fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py D fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/oliveconst.py A ovirt-engine-setup-plugin-live/.gitignore A ovirt-engine-setup-plugin-live/COPYING A ovirt-engine-setup-plugin-live/Makefile.am A ovirt-engine-setup-plugin-live/NOTICE A ovirt-engine-setup-plugin-live/README.md C ovirt-engine-setup-plugin-live/build/Makefile.am A ovirt-engine-setup-plugin-live/build/python.inc A ovirt-engine-setup-plugin-live/configure.ac A ovirt-engine-setup-plugin-live/ovirt-engine-setup-plugin-live.spec.in A ovirt-engine-setup-plugin-live/po/.gitignore A ovirt-engine-setup-plugin-live/po/LINGUAS A ovirt-engine-setup-plugin-live/po/Makevars A ovirt-engine-setup-plugin-live/po/POTFILES.in C ovirt-engine-setup-plugin-live/src/Makefile.am C ovirt-engine-setup-plugin-live/src/ovirt_live/Makefile.am C ovirt-engine-setup-plugin-live/src/ovirt_live/__init__.py R ovirt-engine-setup-plugin-live/src/ovirt_live/constants.py C ovirt-engine-setup-plugin-live/src/plugins/Makefile.am C ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/Makefile.am R ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/__init__.py R ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/core.py 28 files changed, 615 insertions(+), 493 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1d8bffc5a1955f8ee54f48304d6827c99f4e548 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0