November 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: fc21: drop support
by sbonazzo＠redhat.com 19 Nov '15

19 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fc21: drop support ...................................................................... fc21: drop support Drop support for FC21 now that FC23 is available Change-Id: I4b4596dbd6c29e6eeef846d84a469f5ce4aa0d4a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/fabic-ovirt/fabric-ovirt_standard.yaml M jobs/confs/projects/ioprocess/ioprocess_create-rpms.yaml M jobs/confs/projects/lago/lago_standard.yaml M jobs/confs/projects/mom/mom_create-rpms.yaml M jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml M jobs/confs/projects/repoman/repoman_build-artifacts.yaml M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml M jobs/confs/projects/vdsm/vdsm_install-rpm-sanity.yaml M jobs/confs/yaml/builders/copy-create-job-artifact.yaml D mock_configs/fedora-21-x86_64.cfg D mock_configs/fedora-21-x86_64_proxied.cfg M mock_configs/mock_runner.sh 14 files changed, 2 insertions(+), 191 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for review -- To view, visit https://gerrit.ovirt.org/48784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b4596dbd6c29e6eeef846d84a469f5ce4aa0d4a Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: cli: Add "optionhelper.py"
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add "optionhelper.py" ...................................................................... cli: Add "optionhelper.py" Change-Id: Idc6ffb5a97fa3705a95da254d4c9852faefbadf7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile A src/ovirtcli/utils/optionhelper.py 2 files changed, 56 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc6ffb5a97fa3705a95da254d4c9852faefbadf7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: cli: Process correct "--parent..." options
by juan.hernandez＠redhat.com 19 Nov '15

19 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Process correct "--parent..." options ...................................................................... cli: Process correct "--parent..." options Currently when the CLI tries to find a parent collection it assumes that the option used is "--type-identifier", but it can also be "--parent-type-identifier" and "--parent-type-name". As a result when the "--parent..." options are used autocompletion doesn't show the correct options. To avoid this issue this patch changes the CLI so that it uses the methods that check this in a more generic way. Change-Id: I42fb362c59d4baad5968c1ac0df15bbe0b7dab8a Bug-Url: https://bugzilla.redhat.com/1282832 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M src/ovirtcli/command/command.py M src/ovirtcli/shell/cmdshell.py 3 files changed, 23 insertions(+), 51 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42fb362c59d4baad5968c1ac0df15bbe0b7dab8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Host Network QoS should not allow zero values
by alkaplan＠redhat.com 19 Nov '15

19 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Host Network QoS should not allow zero values ...................................................................... webadmin: Host Network QoS should not allow zero values Change-Id: If5220baf3de09c3aa106258ed0faaf98071bd517 Bug-Url: https://bugzilla.redhat.com/1244493 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5220baf3de09c3aa106258ed0faaf98071bd517 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Host Network QoS should not allow zero values
by alkaplan＠redhat.com 19 Nov '15

19 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Host Network QoS should not allow zero values ...................................................................... engine: Host Network QoS should not allow zero values Change-Id: I06a253a0e6b737ed02002db25b9b7994d5eda4fe Bug-Url: https://bugzilla.redhat.com/1244493 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a253a0e6b737ed02002db25b9b7994d5eda4fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Set management network in upgrade
by emesika＠redhat.com 19 Nov '15

19 Nov '15

Eli Mesika has submitted this change and it was merged. Change subject: engine: Set management network in upgrade ...................................................................... engine: Set management network in upgrade Set management network in upgrade (take 2). The patch re-dones upgrade script 03_06_0840 as the related configuration key was renamed in the pre-upgrade phase. Change-Id: I8c68c2bfe758beacb41a74912dacc2080cb621a6 Bug-Url: https://bugzilla.redhat.com/1279955 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0010_set_mgmt_network_in_network_cluster.sql 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/48376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c68c2bfe758beacb41a74912dacc2080cb621a6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: org.ovirt.engine.core.bll.common.predicates
by masayag＠redhat.com 18 Nov '15

18 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: org.ovirt.engine.core.bll.common.predicates ...................................................................... core: org.ovirt.engine.core.bll.common.predicates Replace this package's implementation of org.ovirt.engine.core.utils.linq.Predicate to the standard java.util.function.Predicate that has the same functionality. Change-Id: I49cbd5ad19197aeef8e235e691acaf7ca778d8ed Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/ActiveVmAttachedToClusterPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/RunningVmPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/VmNetworkCanBeUpdatedPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/RunningVmPredicateTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/VmNetworkCanBeUpdatedPredicateTest.java 8 files changed, 15 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49cbd5ad19197aeef8e235e691acaf7ca778d8ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetUnregisteredCinderDisksByStorageDomainIdQuery perfo...
by amureini＠redhat.com 18 Nov '15

18 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredCinderDisksByStorageDomainIdQuery performance ...................................................................... core: GetUnregisteredCinderDisksByStorageDomainIdQuery performance GetUnregisteredCinderDisksByStorageDomainIdQuery had a naive implementation to compare between the volumes retrieved from Cinder and the disks stored in the engine database. In the old implementation, a list of all the volumes was retrieved from the Cinder provider (denoted as N volumes from now on) and a list of all the disks in a given Cinder domain were retrieved from the database (denoted as M disks from now on). Then the volumes were iterated over, and for each volume, the disks were iterated over, in search of a disk with a corresponding ID, resulting in an algorithm with an O(N * M) time complexity. In the implementation presented by this patch, the disks are first iterated, and a Set of their IDs is produced (An O(N) operation). Then, the volumes are iterated, and filtered according their ID being present in the aforementioned Set (An O(M) operation, assuming the JDK implements an efficient hash on Strings). The resulting algorithm has an O(N+M) time complexity, and given n->inf, m->inf, should present a significant improvement in large systems. As an added bonus, this algorithm is implemented using Java 8's built-in streaming APIs instead of the boiler-plated, ugly, LinqUtils code. Change-Id: I5fb243998255cac1936ac388729f3f933a9320e2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredCinderDisksByStorageDomainIdQuery.java 1 file changed, 5 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fb243998255cac1936ac388729f3f933a9320e2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetUnregisteredCinderDisksByStorageDomainIdQueryTest
by amureini＠redhat.com 18 Nov '15

18 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredCinderDisksByStorageDomainIdQueryTest ...................................................................... core: GetUnregisteredCinderDisksByStorageDomainIdQueryTest Introduced GetUnregisteredCinderDisksByStorageDomainIdQueryTest, a unit test for the GetUnregisteredCinderDisksByStorageDomainIdQuery class in order to facilitate refactoring it. Change-Id: If66ed95cbacabf14eaf65b327ccd67b65c9435e2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredCinderDisksByStorageDomainIdQueryTest.java 1 file changed, 87 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If66ed95cbacabf14eaf65b327ccd67b65c9435e2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine_upgrade_to_3.6.1: add missing scripts
by sbonazzo＠redhat.com 18 Nov '15

18 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_upgrade_to_3.6.1: add missing scripts ...................................................................... ovirt-engine_upgrade_to_3.6.1: add missing scripts Change-Id: I0140bf7ae26decbc82bc4a654fc98b2efd0e5447 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/ovirt-engine_upgrade_to_3.6.1/build_engine_rpm.sh A jobs/ovirt-engine_upgrade_to_3.6.1/cleanup.file.otopi A jobs/ovirt-engine_upgrade_to_3.6.1/cleanup.sh A jobs/ovirt-engine_upgrade_to_3.6.1/setup.file.otopi A jobs/ovirt-engine_upgrade_to_3.6.1/upgrade.sh 5 files changed, 775 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/48777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0140bf7ae26decbc82bc4a654fc98b2efd0e5447 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0