Change in ovirt-engine[master]: core, frontend: allow spice+vnc only on 3.6+ cluster
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core,frontend: allow spice+vnc only on 3.6+ cluster
......................................................................
core,frontend: allow spice+vnc only on 3.6+ cluster
Changes:
- do not add the SPICE+VNC option to the dialogs if not allowed
- check on add/edit if more than one graphics are allowed
- check on add new graphics device if it can be added
Change-Id: I4a52ae9f5525578e641e1d039fda048b1f447595
Bug-Url: https://bugzilla.redhat.com/1279524
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
14 files changed, 52 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48753
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a52ae9f5525578e641e1d039fda048b1f447595
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: backend: Copy host device spec params on template creation
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: backend: Copy host device spec params on template creation
......................................................................
backend: Copy host device spec params on template creation
Without preserving the contents of host devices's spec params the
devices of template (and VMs created from this template) will become
unusable - invisible and unmodifiable to the UI.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281433
Change-Id: If35c5a78a7ac1ee1ca7e70658d8ffb7708eeb6b6
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If35c5a78a7ac1ee1ca7e70658d8ffb7708eeb6b6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.2.1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-ha-1.3.2.1
......................................................................
build: post ovirt-hosted-engine-ha-1.3.2.1
Change-Id: I934593e372e7cb2f1594ab5884799f85779c3f0d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48757
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I934593e372e7cb2f1594ab5884799f85779c3f0d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in jenkins[master]: Archive rpm build logs in engine upgrade jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Archive rpm build logs in engine upgrade jobs
......................................................................
Archive rpm build logs in engine upgrade jobs
Added a function to archive .log files from specified folders
to $workspace/logs. Also changed the store() function to archive the
file with its path name, in case same file names exist in different
folders.
Change-Id: I7027b3da36ee906629f6c24fa8f50b04239835d9
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_to_3.5/cleanup.sh
M jobs/ovirt-engine_upgrade_to_3.6/cleanup.sh
M jobs/ovirt-engine_upgrade_to_master/cleanup.sh
3 files changed, 63 insertions(+), 30 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Looks good to me; Passed CI tests; Ready for merge
David Caro: Looks good to me
--
To view, visit https://gerrit.ovirt.org/47269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7027b3da36ee906629f6c24fa8f50b04239835d9
Gerrit-PatchSet: 9
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6.1]: core: proxy for import vm not in ppc cluster
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: proxy for import vm not in ppc cluster
......................................................................
core: proxy for import vm not in ppc cluster
Block import VM from external provider if the proxy host
resides in PPC cluster or if there is no host that is up
and in cluster with supported compatibility version and
also not a PPC cluster (therefore no host in the data
center can serve as proxy).
Change-Id: I0277803f04aeb121507ec9d7e7efde20d1f03e03
Bug-Url: https://bugzilla.redhat.com/1280264
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48747
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0277803f04aeb121507ec9d7e7efde20d1f03e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6.1]: core: proxy for import VM in cluster 3.6 or higher
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: proxy for import VM in cluster 3.6 or higher
......................................................................
core: proxy for import VM in cluster 3.6 or higher
Block import VM from external provider if the selected proxy
host is in cluster with compatibility version lower than 3.6
or if there is no host that is up and resides in cluster with
compatibility version which is 3.6 or higher in the data center
(therefore no host is capable to serve as proxy).
Change-Id: I5aad27d1bde487338c889af6c37d4c2af386652f
Bug-Url: https://bugzilla.redhat.com/1280264
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
8 files changed, 49 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48745
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5aad27d1bde487338c889af6c37d4c2af386652f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6.1]: engine: VFs that are a slaves of a bond, shouldn't considere...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: VFs that are a slaves of a bond, shouldn't considered as free
......................................................................
engine: VFs that are a slaves of a bond, shouldn't considered as free
Change-Id: I4a69cfd31bd7a612b7555bc5bc3f82ff0fb808fe
Bug-Url: https://bugzilla.redhat.com/1258233
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java
2 files changed, 41 insertions(+), 17 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48742
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a69cfd31bd7a612b7555bc5bc3f82ff0fb808fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: logging: improoving logging capabilities
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: logging: improoving logging capabilities
......................................................................
logging: improoving logging capabilities
Getting logs for low level operations
Change-Id: Iaa6ef382fbdad806239ff6c1e0410e1d2d6a4880
Depends-on: https://gerrit.ovirt.org/#/c/48175/
Bug-Url: https://bugzilla.redhat.com/1278725
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/48354
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa6ef382fbdad806239ff6c1e0410e1d2d6a4880
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-setup[master]: logging: improving logging capabilities
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: logging: improving logging capabilities
......................................................................
logging: improving logging capabilities
Getting logs for low level operations
Change-Id: Iaa6ef382fbdad806239ff6c1e0410e1d2d6a4880
Depends-on: https://gerrit.ovirt.org/#/c/48175/
Bug-Url: https://bugzilla.redhat.com/1278725
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/48184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa6ef382fbdad806239ff6c1e0410e1d2d6a4880
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: specifically check if still attached to bootstrap SP
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: specifically check if still attached to bootstrap SP
......................................................................
upgrade: specifically check if still attached to bootstrap SP
On upgrade we are checking if the hosted-engine storage
domain is attached to a storage pool to check if we need
to detach to let the engine import.
This is not correct cause once the engine imports the
hosted-engine storage domain it will attach it to its
datacenter SP so this patch will explictly check if
the hosted-engine SP is still attached to its 3.5
bootstrap SP.
Bug-Url: https://bugzilla.redhat.com/1281539
Change-Id: Ia50f50c548fea573f659ef54dd29b7bddd3bd94a
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia50f50c548fea573f659ef54dd29b7bddd3bd94a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months