Change in ovirt-engine[master]: core: StorageHandlingCommandBase#isDomainExistsInDiskDescrip...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase#isDomainExistsInDiskDescription
......................................................................
core: StorageHandlingCommandBase#isDomainExistsInDiskDescription
Simplified method call by using Objects.toString with a default instead
of explicitly checking for nulls.
Besides shortening the code and making it more fluid to read, this patch
offers a minor performance improvement as
map.get(OvfInfoFileConstants.Domains) is now only called once, but it's
doubtful that this improvement will be noticeable in any reasonable
(or, frankly, unreasonable) setup.
Change-Id: I3de0cf7eae0926d650f2c6b8064c30c03a919cca
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3de0cf7eae0926d650f2c6b8064c30c03a919cca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: StorageHandlingCommandBase VM collection
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase VM collection
......................................................................
core: StorageHandlingCommandBase VM collection
Collect VMs with fluent Java 8 streaming API instead of ugly boilerplate
for loops.
Change-Id: I139909b7be75ac9321ac4a03127c138fc0c621d7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 4 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/48587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I139909b7be75ac9321ac4a03127c138fc0c621d7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: StorageHandlingCommandBase master SD query
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase master SD query
......................................................................
core: StorageHandlingCommandBase master SD query
Retrieve the master domain with the appropriate DAO methods instead of
querying all the domains in the pool and iterating them in-memory.
This patch improves both the code's readability and its performance,
especially in large-scale pools that contain many domains.
Change-Id: I92a8a8fe7563e8ae21b300db67a7f1aa4a86f34a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 3 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92a8a8fe7563e8ae21b300db67a7f1aa4a86f34a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: StorageHandlingCommandBase casts
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase casts
......................................................................
core: StorageHandlingCommandBase casts
Remove redundant cast.
Change-Id: I91c9a6f0d5e5228d27cc3e9abbf558f76e85ec70
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48585
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91c9a6f0d5e5228d27cc3e9abbf558f76e85ec70
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: StorageHandlingCommandBase generics
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBase generics
......................................................................
core: StorageHandlingCommandBase generics
Use generics instead of raw collections.
Change-Id: I928bcf2b6e8b687f9bfc4e51392cab3dd04ec5f2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48584
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I928bcf2b6e8b687f9bfc4e51392cab3dd04ec5f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: restapi: Add VnicProfile.passthrough support
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add VnicProfile.passthrough support
......................................................................
restapi: Add VnicProfile.passthrough support
Add support for VnicProfile.passthrough in REST API.
Change-Id: I4b3f2f938171b3f383655a8a21a277f2772ed817
Bug-Url: https://bugzilla.redhat.com/1231507
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/VnicPassThroughMode.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfileResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VnicProfileValidator.java
A backend/manager/modules/restapi/model/src/main/java/types/VnicPassThrough.java
M backend/manager/modules/restapi/model/src/main/java/types/VnicProfile.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java
7 files changed, 140 insertions(+), 11 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/48142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3f2f938171b3f383655a8a21a277f2772ed817
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: restapi: REST API for SR-IOV feature
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: REST API for SR-IOV feature
......................................................................
restapi: REST API for SR-IOV feature
REST API for SR-IOV feature.
Change-Id: I6281d67dcb4f0480418a00a4ee6ac900f67b6a03
Bug-Url: https://bugzilla.redhat.com/1231507
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateHostNicVfsConfigParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VfsConfigBaseParameters.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostNicResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VirtualFunctionAllowedNetworkResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VirtualFunctionAllowedNetworksResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBaseHostNicLabelResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBaseHostNicLabelsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedNetworkResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedNetworksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java
M backend/manager/modules/restapi/model/src/main/java/types/HostNic.java
A backend/manager/modules/restapi/model/src/main/java/types/HostNicVirtualFunctionsConfiguration.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
26 files changed, 801 insertions(+), 115 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/48072
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6281d67dcb4f0480418a00a4ee6ac900f67b6a03
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add VF icon and PF name for VF nics
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add VF icon and PF name for VF nics
......................................................................
webadmin: Add VF icon and PF name for VF nics
Add VF icon and PF name for VF nics in Setup network dialog.
Change-Id: Iba8ec1246d5c3a3c12d06af7899d61b34efdcf06
Bug-Url: https://bugzilla.redhat.com/1202118
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkInterfaceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/nic_vfunc.png
9 files changed, 90 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/48248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba8ec1246d5c3a3c12d06af7899d61b34efdcf06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: add GetAllVfsConfigByHostIdQuery
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: add GetAllVfsConfigByHostIdQuery
......................................................................
engine: add GetAllVfsConfigByHostIdQuery
Make possible to know what PF NICs the VF NICs rely on.
Change-Id: Id598599ba6e8b1a2789b9489fa40076825c0db34
Bug-Url: https://bugzilla.redhat.com/1202118
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllVfsConfigByHostIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVfToPfMapByHostIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImpl.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVfToPfMapByHostIdQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
7 files changed, 295 insertions(+), 36 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/48247
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id598599ba6e8b1a2789b9489fa40076825c0db34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Prepare for next release
......................................................................
cli: Prepare for next release
In preparation for the next release this patch increases the version
number and sets the RPM release number to 0.1.
Change-Id: I3b665d2c6dade66794e770c1f13cb7d80ef8b6d3
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M setup.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48623
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b665d2c6dade66794e770c1f13cb7d80ef8b6d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months