Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Hide Discover panel if SD in maintenance
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Hide Discover panel if SD in maintenance
......................................................................
webadmin: Hide Discover panel if SD in maintenance
For iSCSI, in case the Storage Domain is in maintenance state,
the "Discover" panel should not be visible when editing.
Change-Id: I38532a05642f256515e924d25fa0a35e0367e977
Bug-Url: https://bugzilla.redhat.com/1222298
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/48474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38532a05642f256515e924d25fa0a35e0367e977
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in jenkins[master]: Adding 3.6 ovirt system tests
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Adding 3.6 ovirt system tests
......................................................................
Adding 3.6 ovirt system tests
Change-Id: Ibb03c221cb32934dfa6010ffb17d3a8f4573ab5c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1278491
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Eyal Edri: Looks good to me; Ready for merge
Yaniv Bronhaim: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/48223
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb03c221cb32934dfa6010ffb17d3a8f4573ab5c
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in jenkins[master]: system_tests: Adapting to the new lago tests repo
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: system_tests: Adapting to the new lago tests repo
......................................................................
system_tests: Adapting to the new lago tests repo
Now it pulls in the code from ovirt-system-tests repo and runs the
basic_suite for the given version (3.5 only right now)
It's using mock_runner to run the tests too
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1277492
Change-Id: I0f3b4fe91a403ea7237549aea688d9e9d876de2c
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
M jobs/confs/shell-scripts/system_tests.cleanup.sh
M jobs/confs/shell-scripts/system_tests.collect_logs.sh
M jobs/confs/shell-scripts/system_tests.sh
A jobs/confs/yaml/scms/ovirt-system-tests.yaml
M jobs/confs/yaml/templates/system_tests_templates.yaml
6 files changed, 79 insertions(+), 75 deletions(-)
Approvals:
Eyal Edri: Looks good to me
Yaniv Bronhaim: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for merge
--
To view, visit https://gerrit.ovirt.org/48163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f3b4fe91a403ea7237549aea688d9e9d876de2c
Gerrit-PatchSet: 8
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn(a)gmail.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: restapi: Import VM - support volume type/format
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Import VM - support volume type/format
......................................................................
restapi: Import VM - support volume type/format
Adding support for changing the allocation policy of disks imported from
an export domain as part of importing a VM.
The caller can specify for each disks the format and allocation policy.
Note that "collapse_snapshots" should be true.
For example, to force one of the disks to be preallocated:
POST
/storagedomains/{storagedomain:id}/vms/{vm:id}/import;collapse_snapshots=true
<action>
<storage_domain>
<name>mydata</name>
</storage_domain>
<cluster>
<name>mycluster</name>
</cluster>
<vm>
<disks>
<disk id="792f8ca8-3932-429b-9660-006ba144bc72">
<format>raw</format>
<sparse>false</sparse>
</disk>
</disks>
</vm>
</action>
Change-Id: I0cd0dc95bfb938d66e8e1ba1ad56116e4dc173f3
Bug-Url: https://bugzilla.redhat.com/998607
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
3 files changed, 104 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/48017
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0cd0dc95bfb938d66e8e1ba1ad56116e4dc173f3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: cleanup hibernation disks
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup hibernation disks
......................................................................
core: cleanup hibernation disks
1. Rename hibernation disks-specific methods in MemoryUtils so they
could be properly distinguished from snapshot memory disks.
2. Use GuidUtils.getGuidListFromString instead of duplicating it.
Change-Id: I931cb9e819c8e68b5f98ae7d6418b83ab1b9c01a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
7 files changed, 38 insertions(+), 28 deletions(-)
Approvals:
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/48431
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I931cb9e819c8e68b5f98ae7d6418b83ab1b9c01a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Quota storage calculating fix for floating disks.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Quota storage calculating fix for floating disks.
......................................................................
core: Quota storage calculating fix for floating disks.
While calculating the quota usage in CalculateStorageUsage psql function,
the calculated "actual size"- which is supposed to include disks
that are not active- DID calculate floating disks in that state.
This patch drops any consideration regarding whether a disk is connected
to a VM or not while calculating the quota usage of inactive disks.
Change-Id: Ib417215b2db6e0ee5ae3acad17b7dcf77b175cf6
Bug-Url: https://bugzilla.redhat.com/1225484
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M packaging/dbscripts/create_functions.sql
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/48273
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib417215b2db6e0ee5ae3acad17b7dcf77b175cf6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Typo in SimpleDependencyInjector class name
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Typo in SimpleDependencyInjector class name
......................................................................
core: Typo in SimpleDependencyInjector class name
Renamed SimpleDependecyInjector to SimpleDependencyInjector.
Change-Id: I3f0a121024785f4f473ef9373b42849434c597bd
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IconLoader.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateWatchdogCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SimpleDependecyInjector.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SimpleDependencyInjector.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/TimeZoneValidator.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsTypeUtils.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/OsTypeMockUtils.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/utils/SimpleDependecyInjector.java
A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/utils/SimpleDependencyInjector.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
59 files changed, 269 insertions(+), 269 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f0a121024785f4f473ef9373b42849434c597bd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: backend: save call to db if not needed in CreateImageTemplat...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: backend: save call to db if not needed in CreateImageTemplateCommand
......................................................................
backend: save call to db if not needed in CreateImageTemplateCommand
In CreateImageTemplateCommand.executeCommand we first call to
fillVolumeInformation (a db call), and then in some cases we override
the information we got from this db call.
In this patch we first check if we need the information, and only if we
do - we call fillVolumeInformation.
Change-Id: I590b3bada2446f48e8bcda2f15c63a69b2016eca
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/47826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I590b3bada2446f48e8bcda2f15c63a69b2016eca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: IOvfBuilder constants' modifiers
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: IOvfBuilder constants' modifiers
......................................................................
core: IOvfBuilder constants' modifiers
Change-Id: I16c2e2df3b9fd894db2fcbe33d990a511fe58722
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16c2e2df3b9fd894db2fcbe33d990a511fe58722
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Remove unused OvfParser#_xmlNS
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused OvfParser#_xmlNS
......................................................................
core: Remove unused OvfParser#_xmlNS
Change-Id: I6ebcf453125828afaaae13195c5afa34575afbc5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/47281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ebcf453125828afaaae13195c5afa34575afbc5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months