Change in ovirt-engine[master]: core: Remove GetVGList*
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove GetVGList*
......................................................................
core: Remove GetVGList*
GetVGList query returns all the VGs a host can access that are not
correlated to storage domains saved in the database. It is only used in
BackendHostStorageResource, where it is used to retrieve connection
information. This information is redundant, as it's always used together
with the connections related to GetDeviceList, which retrieves devices
related to VGs too, anyway.
This patch removes this entire redundant query, cleaning up the code and
improving the performance of hosts/{hostId}/storage and
hosts/{hostId}/storage/{storageId} by a significant factor.
This patch includes:
1. Removing the redundant calls to GetVgList in
BackendHostStorageResource and amending the test accordingly.
2. Removing GetVgListQuery class and the corresponding constant from
VdcQueryType, now that there are no more usages for it.
3. Removing GetVGListVDSCommand, the corresponding constant in
VDSCommandType, the corresponding methods in IVdsServer and its
implementations and the related VGListReturnForXmlRpc class, now that
there are no more usages for it.
Change-Id: Ie16e0da825e74defd0aada439b58bb25e93bc802
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVgListQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
11 files changed, 6 insertions(+), 255 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/48525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie16e0da825e74defd0aada439b58bb25e93bc802
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: UI: sysprep attached by default in run once dialog.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: UI: sysprep attached by default in run once dialog.
......................................................................
UI: sysprep attached by default in run once dialog.
Needs to attach on the first run only if there is sysprep data.
Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27
Bug-Url: https://bugzilla.redhat.com/1240900
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: VdsDao - adding getAllForStoragePoolAndStatuses()
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: VdsDao - adding getAllForStoragePoolAndStatuses()
......................................................................
core: VdsDao - adding getAllForStoragePoolAndStatuses()
This patch adds getAllForStoragePoolAndStatuses() to VdsDAO to provide
abillity to get hosts in different statuses in one db call instead of
calling getAllForStoragePoolAndStatus() multiple times and/or perform
filtering on the calling side.
Change-Id: I5984d5e683b8ae18268248cedb22c1ea66987037
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IdentifiableUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/vds_sp.sql
6 files changed, 69 insertions(+), 11 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5984d5e683b8ae18268248cedb22c1ea66987037
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: IrsProxyData.updateVdsDomainsData() - separation to me...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: IrsProxyData.updateVdsDomainsData() - separation to methods
......................................................................
core: IrsProxyData.updateVdsDomainsData() - separation to methods
This patch separates the logic contained in updateVdsDomainsData() into
different methods for simplification and easier maintenance.
Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
1 file changed, 111 insertions(+), 82 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: more accurate audit log when domain is deactivated
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: more accurate audit log when domain is deactivated
......................................................................
core: more accurate audit log when domain is deactivated
when a Storage Domain is being deactivated it first moves to "Preparing for
maintenance" status and only when it's confirmed that its not accessed
(by monitoring) from any host it moves to Maintenance status.
However, currently when it moves to "Preparing for maintenance" the
audit log indicates that the domain was deactivated and when it actually
moves to Maintenance there's no audit log at all.
This patch fixes the current audit log and adds a new one for the time
the domain status is changed to Maintenance.
Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc
Bug-Url: https://bugzilla.redhat.com/1247957
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
4 files changed, 26 insertions(+), 11 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: support domains maintenance on more hosts statuses
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: support domains maintenance on more hosts statuses
......................................................................
core: support domains maintenance on more hosts statuses
When a domain is being deactivated its status is changed to
PreparingForMaintenance. When it's confirmed that no host in the DC access it
(according to the host domain monitoring report) its status is changed
to Maintenance.
The domain monitoring results of hosts in status other then Up status aren't
being analyzed, therfore when there is a host in that status deactivated
domains will remain in "Preparing for maintenance".
An example for a relevant status is NonOperational, As host can be in Non operational
due to various reasons, the domain monitoring results of such hosts should
be anazlyzed as well when inspecting if a domain can be moved to maintenance status
because if the domain isn't accessed it can move safely to
"maintenance".
As part of this change when a domain is deactivated the pool information is
refreshed on hosts in the relevant statuses in dc that uses the memory
backend (to not extend of risk on long connectStoragePool for non
operational hosts as the metadata is stored on the storage). While in DC
that stores the metadata on storage the metadata refresh will occur by
the host recovery mechanism.
The domain monitoring report of those hosts is then inspected as well to allow the
domain to move to maintenance. In this patch I've added only the NonOperational
status as one as the inspected statuses - if it'll be needed we can add
other statuses as well.
Change-Id: I767106d429f0d8b4bd24b0f539b9a91204be18e9
Bug-Url: https://bugzilla.redhat.com/1256841
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java
6 files changed, 63 insertions(+), 33 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Roy Golan: Looks good to me, but someone else must approve
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45322
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I767106d429f0d8b4bd24b0f539b9a91204be18e9
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: decide whether to process domain monitoring in IrsProx...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: decide whether to process domain monitoring in IrsProxyData
......................................................................
core: decide whether to process domain monitoring in IrsProxyData
Currently the decision on whether it's needed to process the recevied
monitoring data is done in IrsBrokerCommand, as this method is supposed
to be used only as a proxy to the actual processing method - it makes
more sense to have the logic on when we should consider the report that,
otherwise each caller will need to copy that logic.
Change-Id: I2c87698477d6fbb7023b3e7f39eac4af62e91f64
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
2 files changed, 20 insertions(+), 11 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45359
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c87698477d6fbb7023b3e7f39eac4af62e91f64
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[master]: core: moving reportingVdsStatus constant from IrsBrokerCommand
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: moving reportingVdsStatus constant from IrsBrokerCommand
......................................................................
core: moving reportingVdsStatus constant from IrsBrokerCommand
This patch moves the reportingVdsStatus constant to
StoragePoolDomainHelper and changes it to be a Set.
Change-Id: Ib369139ba0ae6953fb22d9bf35f640cff93ef858
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
3 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45358
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib369139ba0ae6953fb22d9bf35f640cff93ef858
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months
Change in ovirt-engine[ovirt-engine-3.6]: core: fix NPE on scheduler when policy filters is null
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix NPE on scheduler when policy filters is null
......................................................................
core: fix NPE on scheduler when policy filters is null
Patch NPE exception if there are no filters.
Fix for patch https://gerrit.ovirt.org/#/c/44244/
Change-Id: I9f121d6f78c0aaea98d4008ff71f3e5f3f6fb0fc
Bug-Url: http://bugzilla.redhat.com/1256238
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b74f7a057d74b2f6b0ed0dbde8de2e5daad47b4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 2 months
Change in ovirt-engine[master]: core: Rename parameter in getLUNs
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Rename parameter in getLUNs
......................................................................
core: Rename parameter in getLUNs
Renamed the storageDomainId parameter in getLUNs so it doesn't hide the
data member of the same name.
Change-Id: Iccfb4c75a928a0dee04a68263088ad864ae4184a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccfb4c75a928a0dee04a68263088ad864ae4184a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years, 2 months