Change in ovirt-engine[master]: core: Support remove of VM with Cinder disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Support remove of VM with Cinder disks
......................................................................
core: Support remove of VM with Cinder disks
Add a support for removing a VM with Cinder disks
Change-Id: I1bf8b7e54542bd0673c5c26e98fbe0335d74a79b
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 36 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bf8b7e54542bd0673c5c26e98fbe0335d74a79b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: Add callback command for remove VM with Cinder disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Add callback command for remove VM with Cinder disks
......................................................................
core: Add callback command for remove VM with Cinder disks
Adding new callback from remove VM with Cinder disks
Change-Id: I1e07d72543656681f4a761db629bbcbc1bb40021
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommandCallBack.java
2 files changed, 62 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39229
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e07d72543656681f4a761db629bbcbc1bb40021
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: Add command to remove VM with Cinder disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Add command to remove VM with Cinder disks
......................................................................
core: Add command to remove VM with Cinder disks
Adding a command for removing all the Cinder disks attached to a VM.
Change-Id: I5ed7ecdd6cd891936ed7a18b4f48eec48935b79a
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmCinderDisksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
3 files changed, 135 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39228
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ed7ecdd6cd891936ed7a18b4f48eec48935b79a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: support Cinder disk update
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: support Cinder disk update
......................................................................
core: support Cinder disk update
Support updating/extending Cinder disks.
Change-Id: I16d4ce9f53569ddfe1984b29dcbe1cdda4f7b444
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 85 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39201
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16d4ce9f53569ddfe1984b29dcbe1cdda4f7b444
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: adding ExtendCinderDisk command and callback
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: adding ExtendCinderDisk command and callback
......................................................................
core: adding ExtendCinderDisk command and callback
Introducing ExtendCinderDiskCommand and
ExtendCinderDiskCommandCallback.
Change-Id: I03e0b6993d52f27f6241aeb7ad9a8b01326883d0
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
7 files changed, 166 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39199
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03e0b6993d52f27f6241aeb7ad9a8b01326883d0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin : Create + Delete Geo-rep session
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin : Create + Delete Geo-rep session
......................................................................
webadmin : Create + Delete Geo-rep session
This patch adds create and delete geo-rep
session.
Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepActionConfirmationModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java
16 files changed, 878 insertions(+), 37 deletions(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/29691
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c
Gerrit-PatchSet: 50
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: Fix CDA typo when importing a "dirty" domain
by wallaroo1976＠gmail.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix CDA typo when importing a "dirty" domain
......................................................................
core: Fix CDA typo when importing a "dirty" domain
Change-Id: I06b4b6e0bd73b7644ac0dcff8eaabfc65e488782
Bug-Url: https://bugzilla.redhat.com/1206440
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b4b6e0bd73b7644ac0dcff8eaabfc65e488782
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: cleanup cells -- use SafeHtmlTemplates
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: cleanup cells -- use SafeHtmlTemplates
......................................................................
userportal, webadmin: cleanup cells -- use SafeHtmlTemplates
CLeaned up some Cells and VmTable to use SafeHtmlTemplates instead
of String-building HTML.
Change-Id: Iab169b1daf5974655f90bab47e8ee5286c4f2e51
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LunSelectionCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/SafeHtmlCell.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/CustomSelectionCell.java
4 files changed, 81 insertions(+), 22 deletions(-)
Approvals:
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab169b1daf5974655f90bab47e8ee5286c4f2e51
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: fix Coverity issues related to tooltips
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fix Coverity issues related to tooltips
......................................................................
userportal, webadmin: fix Coverity issues related to tooltips
* 1291168 Dereference null return value
If the function actually returns a null value, a NullPointerException
will be thrown.
In org.ovirt.engine.ui.userportal.widget.QuotaProgressBar.setValues
* 1289478 Missing call to superclass
Whatever action the superclass method implements will not occur, if
the superclass call is actually required.
In org.ovirt.engine.ui.webadmin.widget.table.cell.MenuCell.onBrowserEvent
* 1289477 Logically dead code
The indicated dead code may have performed some action; that action will
never occur.
In org.ovirt.engine.ui.common.widget.table.cell.RadioboxCell.onBrowserEvent
* 1289467, 1289468, 1289469, 1289470 Missing break in switch
Execution falls through to the next case statement or default; this might
indicate a common typo.
In org.ovirt.engine.ui.webadmin.widget.table.column.VolumeStatusColumn.getTooltip
* 1289466 Dereference null return value
If the function actually returns a null value, a NullPointerException will
be thrown.
In org.ovirt.engine.ui.common.widget.uicommon.popup.vm.
VmSnapshotCustomPreviewPopupWidget$10.getTooltip
* 1289462, 1289463, 1289464, 1289465 Unused value
An assigned value that is never used may represent unnecessary computation,
an incorrect algorithm, or possibly the need for cleanup or refactoring.
In org.ovirt.engine.ui.webadmin.widget.table.column.VolumeStatusColumn.getTooltip
* 1289461 Useless call
A function call that seems to have an intended effect has no actual effect
on the logic of the program.
In org.ovirt.engine.ui.userportal.widget.table.column.AbstractMaskedVmImageColumn.
render
* 1289460 SF: Switch case falls through
In org.ovirt.engine.ui.webadmin.widget.table.column.VolumeStatusColumn.getTooltip
* 1289459 SIC: Inner class could be made static
This class is an inner class, but does not use its embedded reference to the
object which created it.
Change-Id: Iec6a015fb0083cec224290b31b7e981cc9841ffb
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/RadioboxCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/AbstractMaskedVmImageColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/MenuCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java
7 files changed, 17 insertions(+), 10 deletions(-)
Approvals:
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec6a015fb0083cec224290b31b7e981cc9841ffb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: Adding Cinder volume validation
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Adding Cinder volume validation
......................................................................
core: Adding Cinder volume validation
Add validation also for Cinder disks on Remove VM command
Change-Id: I24d37d5d756994acb3f0f7af044491c6c9a70998
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24d37d5d756994acb3f0f7af044491c6c9a70998
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months