Change in ovirt-engine[master]: restapi: Implicitly add Correlation-Id to RSDL
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Implicitly add Correlation-Id to RSDL
......................................................................
restapi: Implicitly add Correlation-Id to RSDL
Currently the Correlation-Id header is documented in the RSDL manually,
but it fact it is used by all the operations that can potentially modify
the state of the system, so it is better to implicity add it to all
these operations and remove it from the metadata file.
Change-Id: I0add23cbbb411f43f76df9896873987fbb83990f
Bug-Url: https://bugzilla.redhat.com/1206130
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
2 files changed, 25 insertions(+), 576 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit https://gerrit.ovirt.org/39246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0add23cbbb411f43f76df9896873987fbb83990f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: engine : Geo-rep JsonRpc refactored
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine : Geo-rep JsonRpc refactored
......................................................................
engine : Geo-rep JsonRpc refactored
This patch refactors JsonRpcVdsServer geo-rep in
accordance with merged vdsm patch.
Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
anmolbabu: Verified
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Objections:
oVirt Jenkins CI Server: Fails
--
To view, visit https://gerrit.ovirt.org/39250
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: build: pack gwt-symbols within jar
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: build: pack gwt-symbols within jar
......................................................................
build: pack gwt-symbols within jar
due to limitation of rhel build, gwt target files are not available to
the make process.
packing these as maven artifacts will enable to reference them.
somewhat more complex, until we drop el6.
Change-Id: I1bfb8ca2eb2cb9e020eeff2c2e65237839402227
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182000
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
A frontend/webadmin/modules/frontend-symbols/pom.xml
A frontend/webadmin/modules/frontend-symbols/resources/userportal/.keep
A frontend/webadmin/modules/frontend-symbols/resources/webadmin/.keep
M frontend/webadmin/modules/pom.xml
5 files changed, 60 insertions(+), 10 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39286
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bfb8ca2eb2cb9e020eeff2c2e65237839402227
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: Changed text in import VM dialog
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Changed text in import VM dialog
......................................................................
webadmin: Changed text in import VM dialog
Change-Id: If3e13bdfcb400979964d934f8e7b60828b4122e3
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1149492
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3e13bdfcb400979964d934f8e7b60828b4122e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: restapi: Add VM parameters to VmPool collection
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: restapi: Add VM parameters to VmPool collection
......................................................................
restapi: Add VM parameters to VmPool collection
A majority of VM parameters that are available in the UI when adding VM Pool
were missing from REST API VmPool collection.
Added new <vm> subelement with all the VM fields into the <vmpool> element.
The values of these fields override the values of the corresponding template
parameters. The structure is:
<vm_pool>
<size>50</size>
...
<template id="xxx"/>
<vm>
<some_overriden_field_a>new value</some_overriden_field_a>
<some_overriden_field_b>new value 2</some_overriden_field_b>
</vm>
</vm_pool>
Description on oVirt Wiki:
http://www.ovirt.org/Features/Vm_Parameters_in_REST_API_for_Vm_Pools
Change-Id: I791791a99abdf258f42b3e06288567f1b6c0bbf4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195167
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java
4 files changed, 29 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Shmuel Leib Melamud: Verified
--
To view, visit https://gerrit.ovirt.org/38755
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I791791a99abdf258f42b3e06288567f1b6c0bbf4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine : Fixes geo-rep issues
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine : Fixes geo-rep issues
......................................................................
engine : Fixes geo-rep issues
This patch fixes the following issues:
1. Fixes the xml parsing logic in GlusterHostsPubKeyReturnForXmlRpc
for json mode.
2. hostname and username separated
3. When masterVolumeId was not set, use volumeId passed in parameter.
Change-Id: I925815c663be810cedb2cd7df81032d24ea8286c
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostsPubKeyReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java
3 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Objections:
oVirt Jenkins CI Server: Fails
--
To view, visit https://gerrit.ovirt.org/39279
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I925815c663be810cedb2cd7df81032d24ea8286c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[ovirt-engine-3.5.2]: core: Fix CDA typo when importing a "dirty" domain
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix CDA typo when importing a "dirty" domain
......................................................................
core: Fix CDA typo when importing a "dirty" domain
Changing the rest of the AppErrors files with this type
Change-Id: Ib1e0ad72f1f43d952f1d0c272dd79de546f910dc
Bug-Url: https://bugzilla.redhat.com/1206440
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/39277
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e0ad72f1f43d952f1d0c272dd79de546f910dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 9 months
Change in ovirt-engine[ovirt-engine-3.5.2]: core: Fix CDA typo when importing a "dirty" domain
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix CDA typo when importing a "dirty" domain
......................................................................
core: Fix CDA typo when importing a "dirty" domain
Change-Id: I06b4b6e0bd73b7644ac0dcff8eaabfc65e488782
Bug-Url: https://bugzilla.redhat.com/1206440
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/39259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b4b6e0bd73b7644ac0dcff8eaabfc65e488782
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 9 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix CDA typo when importing a "dirty" domain
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix CDA typo when importing a "dirty" domain
......................................................................
core: Fix CDA typo when importing a "dirty" domain
Changing the rest of the AppErrors files with this type
Change-Id: Ib1e0ad72f1f43d952f1d0c272dd79de546f910dc
Bug-Url: https://bugzilla.redhat.com/1206440
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/39276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e0ad72f1f43d952f1d0c272dd79de546f910dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix CDA typo when importing a "dirty" domain
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix CDA typo when importing a "dirty" domain
......................................................................
core: Fix CDA typo when importing a "dirty" domain
Change-Id: I06b4b6e0bd73b7644ac0dcff8eaabfc65e488782
Bug-Url: https://bugzilla.redhat.com/1206440
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/39258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06b4b6e0bd73b7644ac0dcff8eaabfc65e488782
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months