Change in ovirt-engine[master]: webadmin, userportal: Optimize syntax checker handling
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Optimize syntax checker handling
......................................................................
webadmin,userportal: Optimize syntax checker handling
1. access to (search) syntax checker instance is now provided
through Configurator#getSyntaxChecker
* UserPortalConfigurator#getSyntaxChecker returns null
(not available in UserPortal context)
* WebAdminConfigurator#getSyntaxChecker returns instance
obtained via SyntaxCheckerFactory
2. removed SearchableListModel#syntaxChecker field along
with related code (instance initialization, getter)
3. modified SearchableListModel#isSearchValidForServerSideSorting
to access syntax checker through Configurator
* in UserPortal context, syntax checker will be null
and above method will simply return true
* in WebAdmin context, syntax checker will be non-null
and existing behavior will be retained
4. modified SearchSuggestModel to access syntax checker
through Configurator
5. removed unused SyntaxCheckerFactory#getUISyntaxChecker
This patch improves performance of UserPortal while keeping
existing behavior of WebAdmin (where syntax checker is used
in SearchableListModel#isSearchValidForServerSideSorting).
Change-Id: Iab7f369fa26452fe49c57f99dc53919a2bad0412
Bug-Url: https://bugzilla.redhat.com/1221236
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
7 files changed, 31 insertions(+), 23 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/41237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab7f369fa26452fe49c57f99dc53919a2bad0412
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: fix compensation for import and clone vm
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: fix compensation for import and clone vm
......................................................................
core: fix compensation for import and clone vm
If the initialization that is done in post-construct accessed the
command's parameters in a non-transactive command that uses
compensation, the compensation didn't work. The problem is that when
instantiate the command for compensation, the parameters are not passed,
so the initialization in the post-construct failed.
The solution is to do the initialization in post-construct only when the
parameters are set.
Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/41213
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: make postConstruct final
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: make postConstruct final
......................................................................
core: make postConstruct final
Consider the following case:
Class A {
@PostConstruct
protected void foo() {}
}
Class B extends A {
@Override
@PostConstruct
protected void foo() {}
}
JBOSS 7.1.1: when instantiate class B, B#foo will be called twice. This
seems to be a bug in JBOSS.
JBOSS EAP 6.3: when instantiate class B, B#foo will be called only once.
Because of Ibf9cdd60, we have @PostConstruct on postConstruct methods in
commands as well as in the CommandBase, so we have the structure above,
thus in JBOSS 7.1.1 the postConstruct methods are called multiple times.
This patch introduces a different approach where the postConstruct
method that is annotated with @PostConstruct is declared as final in
CommandBase, and calls CommandBase#init which is the method that should
be overridden by commands and does not need to be annotated with
@PostConstruct.
Change-Id: I8340d8348b298fec0c73bf93b7411a149e9fe8c0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostCommand.java
9 files changed, 21 insertions(+), 35 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/41212
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8340d8348b298fec0c73bf93b7411a149e9fe8c0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: Phase 5: Add graphics console representation
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: Phase 5: Add graphics console representation
......................................................................
restapi: Phase 5: Add graphics console representation
as a part of display subresource.
GraphicsConsole holds basic dynamic data of running console (host, port,
secure port).
This patch also adds way to get the console descriptor (aka .vv file)
via request on /vms/{vmid}/display/graphics_consoles/{consoleId} with
header containing "Accept: application/x-virt-viewer" where consoleId is
"5350494345" for SPICE and "564e43" for VNC console (hexa encoded
SPICE/VNC strings).
Change-Id: I7dbc63ac49bfba5637c38b84b373d78f348c7872
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1128763
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/GraphicsType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ApiMediaType.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmGraphicsConsoleResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmGraphicsConsolesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsolesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/GraphicsValidator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
14 files changed, 359 insertions(+), 8 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dbc63ac49bfba5637c38b84b373d78f348c7872
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-reports[master]: reports: added heatmap report
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: reports: added heatmap report
......................................................................
reports: added heatmap report
Change-Id: I0e34dbc254d7123f7743d20b0e20e774a4822bbc
Bug-Url:https://bugzilla.redhat.com/1169693
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/.folder.xml
A packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49.xml
A packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49_files/br49_full_details.jrxml.data
A packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49_files/br49_legend.jrxml.data
A packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49_files/heatmap_report_cpu_usage_br49_jrxml.data
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/.folder.xml
A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Avg_Max.xml
A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Utilization_Measure.xml
M packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/.folder.xml
A packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Hosts_List_Multi.xml
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data
11 files changed, 1,694 insertions(+), 0 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e34dbc254d7123f7743d20b0e20e774a4822bbc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: UI: Fix header buttons in import iScsi target
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: Fix header buttons in import iScsi target
......................................................................
UI: Fix header buttons in import iScsi target
Login button is scrolled with the target table when discovering iScsi
targets
Change-Id: I5e091ac344ca84624f82e8fbf58cd446adb27de9
Bug-Url: https://bugzilla.redhat.com/1138131
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.ui.xml
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Verified
Shahar Havivi: Verified
--
To view, visit https://gerrit.ovirt.org/41051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e091ac344ca84624f82e8fbf58cd446adb27de9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Missing entries for daos
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Missing entries for daos
......................................................................
engine: Missing entries for daos
Added missing entries for newly added dao
Change-Id: I5a8c5d4b528643e164d36b026d7d7b829212d90e
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a8c5d4b528643e164d36b026d7d7b829212d90e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: Added place holder for watchdog model.
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Added place holder for watchdog model.
......................................................................
webadmin: Added place holder for watchdog model.
When adding new VM the watchdog model didn't have a place holder like
the watchdog action did. So a place holder was added "<No Watchdog>"
to comply with current UI design standards.
Change-Id: Ice4111935a0ec3bb29237660702e536adbc34d14
Bug-Url: https://bugzilla.redhat.com/1166047
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
3 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/36688
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice4111935a0ec3bb29237660702e536adbc34d14
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-live[master]: post ovirt-live-3.6.0_alpha1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: post ovirt-live-3.6.0_alpha1
......................................................................
post ovirt-live-3.6.0_alpha1
Change-Id: I4be87d93e667a274ae533d7585942714b9a78625
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4be87d93e667a274ae533d7585942714b9a78625
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-node-plugin-vdsm[master]: autoreg: vdsm-tool register verb
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: autoreg: vdsm-tool register verb
......................................................................
autoreg: vdsm-tool register verb
- Added support to vdsm-tool register verb
- Added key management_server_fingerprint
- Added key engine_admin_password
See also:
vdsm-tool: Add register verb
https://gerrit.ovirt.org/#/c/40966/
engine_page: vdsm-tool register verb integration
https://gerrit.ovirt.org/#/c/41081/
Change-Id: I7417dfcf4165d88e4e22b315a03d0e4ac8984571
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/41082
Reviewed-by: Jenkins CI
---
M autoinstall/autoreg-args
M autoinstall/autoreg.py
2 files changed, 44 insertions(+), 4 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41082
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7417dfcf4165d88e4e22b315a03d0e4ac8984571
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
