May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-release[master]: update configure.ac docs to match defaults
by sbonazzo＠redhat.com 20 May '15

20 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: update configure.ac docs to match defaults ...................................................................... update configure.ac docs to match defaults Change-Id: I9421a72cae76dbc714ca47096b1a9a5fb281ff32 Signed-off-by: Max Kovgan <mvk(a)redhat.com> --- M ovirt-release-master/configure.ac 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve David Caro: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9421a72cae76dbc714ca47096b1a9a5fb281ff32 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: sla: Add support for basic PolicyUnit testing
by rgolan＠redhat.com 20 May '15

20 May '15

Roy Golan has submitted this change and it was merged. Change subject: sla: Add support for basic PolicyUnit testing ...................................................................... sla: Add support for basic PolicyUnit testing This patch adds a rudimentary infrastructure for unit testing policy units. A (very simple) CSV loader is included with dynamic entity field recognition using introspection and simple tests for PowerSavingBalancePolicyUnit and EvenDistributionBalancePolicyUnit are included as an example. Change-Id: Ied30d4ac4c1eeee2911e5f276d5333982147effa Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CPUPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUsageComparator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/AbstractPolicyUnitTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnitTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnitTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java A backend/manager/modules/bll/src/test/resources/scheduling/basic_balancing_hosts_cpu_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_balancing_hosts_cpumem_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_balancing_hosts_cpumem_medium_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_balancing_hosts_mem_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_balancing_vms.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_power_saving_hosts_cpu_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_power_saving_hosts_cpumem_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_power_saving_hosts_medium_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_power_saving_hosts_mem_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_power_saving_hosts_no_load.csv A backend/manager/modules/bll/src/test/resources/scheduling/basic_power_saving_vms.csv 20 files changed, 643 insertions(+), 18 deletions(-) Approvals: Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied30d4ac4c1eeee2911e5f276d5333982147effa Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: enable new gluster features using new feature check
by sabose＠redhat.com 20 May '15

20 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: enable new gluster features using new feature check ...................................................................... gluster: enable new gluster features using new feature check Enabling the new gluster features like snapshot managment, geo replication, brick provisioning based on new feature compatibility check. With this, above features will be supported in 3.5 cluster as well. Change-Id: I9074a500caa1b5a30cea19e9fa4420e12d3fa6a1 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java 15 files changed, 153 insertions(+), 50 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9074a500caa1b5a30cea19e9fa4420e12d3fa6a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add additional features support in cluster popup.
by sabose＠redhat.com 20 May '15

20 May '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: add additional features support in cluster popup. ...................................................................... webadmin: add additional features support in cluster popup. Add support for addtional features in the cluster pop up. User can enable/disable some extra feature during cluster creation. Addtional features will be shown based on the cluster compatability version shown and services (gluster, virt) enabled. Change-Id: Ic13dda67f3e9a7d7134030c3923470291c3c5aec Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 6 files changed, 193 insertions(+), 4 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic13dda67f3e9a7d7134030c3923470291c3c5aec Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: fix NPE and visibility issues in CheckBoxGroup
by sabose＠redhat.com 20 May '15

20 May '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: fix NPE and visibility issues in CheckBoxGroup ...................................................................... webadmin: fix NPE and visibility issues in CheckBoxGroup Fixing the NPE issue in setValue() and items clearning issue setAcceptableValues() of CheckBoxGroup Change-Id: Ia4f1d371d6c6cbecad9642641d762e954016105d Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/CheckBoxGroup.java 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f1d371d6c6cbecad9642641d762e954016105d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: add feature comptability check for VDS
by sabose＠redhat.com 20 May '15

20 May '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: add feature comptability check for VDS ...................................................................... engine: add feature comptability check for VDS Some times checking for the cluster compatibility version is not enough to support some features across multiple comptability versions. So we need to have some machanism while adding a node to cluster to check that vdsm supports all the required features required for the cluster. This patch adds feature compatability check for VDS. List of all additional features will be maintained in a master table. List of features will be shown in the new/edit cluster dialog based on the compatability version selected as well as the services gluster/virt enabled. User can select the features he wants in the cluster and cluster will be initialized with that set of feature during cluster creation. When a node is added to the cluster, it checks that all the required features for the cluster are supported by vdsm. This is done in a generic way so that it can used in different features in future. Currently it is used to check whether the vdsm supports gluster37 features. gluster37 features are supported in 3.6 cluster by default. It is also supported in 3.5 cluster with this feature check. Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByClusterIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByVersionAndCategoryQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AdditionalFeature.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SupportedAdditionalClusterFeature.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterFeaturesByVersionAndCategoryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDaoImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterFeatureDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/cluster_features_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_1480_add_cluster_features_table.sql 39 files changed, 1,280 insertions(+), 19 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add validation for create brick popup view
by sabose＠redhat.com 20 May '15

20 May '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: add validation for create brick popup view ...................................................................... webadmin: add validation for create brick popup view Adding validations for entities in create brick popup view. Change-Id: I16d3a2c377a80f37b6f8aba061ad26ac17d9736b Bug-Url: https://bugzilla.redhat.com/1211976 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/BrickMountPointValidation.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/BrickMountPointValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.ui.xml 6 files changed, 162 insertions(+), 2 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16d3a2c377a80f37b6f8aba061ad26ac17d9736b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: fix wrong mirrorlist path
by sbonazzo＠redhat.com 20 May '15

20 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: fix wrong mirrorlist path ...................................................................... fix wrong mirrorlist path - add a dash at the end of default paths Change-Id: Ia4e10fb6f661a6ac4234ec860a9e707c9b1446a7 Signed-off-by: Max Kovgan <mvk(a)redhat.com> --- M ovirt-release-master/configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Max Kovgan: Verified -- To view, visit https://gerrit.ovirt.org/41142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4e10fb6f661a6ac4234ec860a9e707c9b1446a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Improve the description storage domain detach
by juan.hernandez＠redhat.com 20 May '15

20 May '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Improve the description storage domain detach ...................................................................... restapi: Improve the description storage domain detach The DELETE operation of the "storagedomains" sub-collection of the "datacenters" collection is used to detach the storage domain from the data center, but the RSDL description isn't explicit about this. This patch improves the description so that it is more explicit about the meaning. Change-Id: Ia2b16297d59b0f4443779d4fc3db1c715e3d449a Bug-Url: https://bugzilla.redhat.com/1221294 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2b16297d59b0f4443779d4fc3db1c715e3d449a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Overload addTextAndLinkAlert with alert type
by masayag＠redhat.com 20 May '15

20 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Overload addTextAndLinkAlert with alert type ...................................................................... webadmin: Overload addTextAndLinkAlert with alert type Change-Id: I3695d0b732d4f2139c18defa4809041cd62473f2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/41021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3695d0b732d4f2139c18defa4809041cd62473f2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0