Change in ovirt-engine[master]: webadmin: fix mac range validation not a ghost if at least o...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: fix mac range validation not a ghost if at least one boundary is set
......................................................................
webadmin: fix mac range validation
not a ghost if at least one boundary is set
Change-Id: Ie0f30070ba6ca4d9bc0199c8913e8b68b6720372
Bug-Url: https://bugzilla.redhat.com/1217940
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacRangeWidget.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Mucha: Verified
--
To view, visit https://gerrit.ovirt.org/41109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0f30070ba6ca4d9bc0199c8913e8b68b6720372
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: webadmin: Maintenence text and reason should be in the same ...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Maintenence text and reason should be in the same line
......................................................................
webadmin: Maintenence text and reason should be in the same line
Change-Id: Ibd79b53f307984792c11b456d6fdb58c7be55ee5
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/SafeHtmlWithStyleCell.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java
3 files changed, 36 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd79b53f307984792c11b456d6fdb58c7be55ee5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: core: Prevent blank template sub-templates - backend
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Prevent blank template sub-templates - backend
......................................................................
core: Prevent blank template sub-templates - backend
Change-Id: I88740116070f5cee438038be5a6375a2243acae6
Bug-Url: https://bugzilla.redhat.com/1205813
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
3 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40499
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88740116070f5cee438038be5a6375a2243acae6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: packaging: engine-backup: Stricter credentials options checks
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Stricter credentials options checks
......................................................................
packaging: engine-backup: Stricter credentials options checks
Do not allow passing credentials options without --change-*credentials.
Change-Id: Id7cb0e61e9184b9ebed24c2584ce1317541644f3
Bug-Url: https://bugzilla.redhat.com/1212526
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/41087
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7cb0e61e9184b9ebed24c2584ce1317541644f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: sla: Update balancers and add memory based load balancing
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: sla: Update balancers and add memory based load balancing
......................................................................
sla: Update balancers and add memory based load balancing
This patch cleans up the load balancing modules and creates
a new base class for them - CpuAndMemoryBalancingPolicyUnit.
It also cleans up the naming conventions in the code so we
are no longer confused by "overLoadedCPU" method getting
data about idle hosts.
The base class supports primary and secondary reason for
balancing, but does not force the content. All inherited
classes then provide their own lists for primary and
secondary source and destination hosts.
The base class provides parametrized methods for getting
CPU and memory over-, under- and normally loaded hosts.
These methods are meant to be called from the derived classes
when preparing the primary and secondary lists.
Migration is never attempted to CPU or memory overloaded
hosts (not even in power saving).
The Even Distribution unit is then updated to use Memory
as the secondary criteria when no CPU based load balancing
is needed (or possible).
The Power saving unit is updated in the same way, except
it tries to migrate VMs from over and under utilized hosts
to the middle group - normally utilized hosts. This should
behave the same as the old code with the exception of having
the memory information used as well.
Change-Id: I1fe13267feca89ab6c8fb9d85656f05930d0b333
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenGuestDistributionBalancePolicyUnit.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUsageComparator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VmCpuUsageComparator.java
A packaging/dbscripts/upgrade/03_06_1420_add_memory_balancing_vars.sql
9 files changed, 729 insertions(+), 281 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38189
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fe13267feca89ab6c8fb9d85656f05930d0b333
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Added canDoAction for volume snapshot create and re...
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Added canDoAction for volume snapshot create and restore
......................................................................
gluster: Added canDoAction for volume snapshot create and restore
Added canDoAction conditions for gluster volume snapshot
create and restore commands.
Change-Id: I54f85ecae08e465e7d762e4772c5402d08ab14ea
Bug-Url: https://bugzilla.redhat.com/1215878
Bug-Url: https://bugzilla.redhat.com/1215884
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54f85ecae08e465e7d762e4772c5402d08ab14ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Fixed a coverity scan issue
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Fixed a coverity scan issue
......................................................................
gluster: Fixed a coverity scan issue
Fixed a coverity scan issue reported
Change-Id: If0d394e7077552341726506ab1e1e143dc3a717c
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0d394e7077552341726506ab1e1e143dc3a717c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Georep status detail changes
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Georep status detail changes
......................................................................
engine: Georep status detail changes
Changes corresponding to gluster's georep status
detail changes
Change-Id: Id05fa1d8537bcd3a0a80f1765f142dab575f43ba
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
M packaging/dbscripts/gluster_georep_sp.sql
A packaging/dbscripts/upgrade/03_05_1470_alter_georep_session_details.sql
11 files changed, 205 insertions(+), 121 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id05fa1d8537bcd3a0a80f1765f142dab575f43ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: gluster: enable new gluster features using new feature check
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: enable new gluster features using new feature check
......................................................................
gluster: enable new gluster features using new feature check
Enabling the new gluster features like snapshot managment,
geo replication, brick provisioning based on new feature
compatibility check. With this, above features will be
supported in 3.5 cluster as well.
Change-Id: I9074a500caa1b5a30cea19e9fa4420e12d3fa6a1
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java
16 files changed, 149 insertions(+), 51 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/40921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9074a500caa1b5a30cea19e9fa4420e12d3fa6a1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: packaging: Do not dump/restore privileges
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Do not dump/restore privileges
......................................................................
packaging: Do not dump/restore privileges
Change-Id: If8e8d9b9d56efeb2ef38b3255b12aa919a942440
Bug-Url: https://bugzilla.redhat.com/1217402
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh
M packaging/setup/ovirt_engine_setup/engine_common/database.py
2 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/41047
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8e8d9b9d56efeb2ef38b3255b12aa919a942440
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years