May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Corrected VDS commands for xmlrpc case
by kmayilsa＠redhat.com 18 May '15

18 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected VDS commands for xmlrpc case ...................................................................... gluster: Corrected VDS commands for xmlrpc case There were mismatch in names of VDSM versb called from engine for xmlrpc case. Corrected the same. Change-Id: I0332e16f20ed1eebf35f8ff45e238351e7c2315e Bug-Url: https://bugzilla.redhat.com/1218991 Bug-Url: https://bugzilla.redhat.com/1215881 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteAllGlusterVolumeSnapshotsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeSnapshotInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 22 insertions(+), 18 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0332e16f20ed1eebf35f8ff45e238351e7c2315e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Spare a Date object when calculating date
by rgolan＠redhat.com 18 May '15

18 May '15

Roy Golan has submitted this change and it was merged. Change subject: core: Spare a Date object when calculating date ...................................................................... core: Spare a Date object when calculating date Change-Id: I2c7aa688a96a210b36f932ce50fbd1fd276883ee Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7aa688a96a210b36f932ce50fbd1fd276883ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Remove volume snapshot schedule if job ended
by kmayilsa＠redhat.com 18 May '15

18 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Remove volume snapshot schedule if job ended ...................................................................... gluster: Remove volume snapshot schedule if job ended Added logic to remove the gluster volume snapshot schedule details if the schedule has ended. Change-Id: Ibbdb11f0d881339749dac8101ca9a01b04a334c6 Bug-Url: https://bugzilla.redhat.com/1219827 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 74 insertions(+), 23 deletions(-) Approvals: Shubhendu Tripathi: Verified Jenkins CI: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbdb11f0d881339749dac8101ca9a01b04a334c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Corrected VDS commands for xmlrpc case
by kmayilsa＠redhat.com 18 May '15

18 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected VDS commands for xmlrpc case ...................................................................... gluster: Corrected VDS commands for xmlrpc case There were mismatch in names of VDSM versb called from engine for xmlrpc case. Corrected the same. Change-Id: I0332e16f20ed1eebf35f8ff45e238351e7c2315e Bug-Url: https://bugzilla.redhat.com/1218991 Bug-Url: https://bugzilla.redhat.com/1215881 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeSnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteAllGlusterVolumeSnapshotsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeSnapshotInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 22 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0332e16f20ed1eebf35f8ff45e238351e7c2315e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: cleanup in DisksAllocationModel
by ahadas＠redhat.com 17 May '15

17 May '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: cleanup in DisksAllocationModel ...................................................................... webadmin: cleanup in DisksAllocationModel Rename DisksAllocationModel#isVolumeFormatAvailable to isVolumeTypeAvailable as it controls the volume type and not the volume format. Change-Id: I1ed7e2b15cb38715b39250bab2ac65eb0caaa68a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloneVmFromSnapshotModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 5 files changed, 21 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/38374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed7e2b15cb38715b39250bab2ac65eb0caaa68a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Save RNG device when VM is running
by ofrenkel＠redhat.com 17 May '15

17 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Save RNG device when VM is running ...................................................................... core: Save RNG device when VM is running Added missing functionality to detect changes of RNG device properties when VM is running and to save/restore them to/from NEXT_RUN snapshot. For this purpose Optional<T> class was added to VmManagementParametersBase. This class combines data for the device that needs to be updated with a flag that switches the update on/off. This change makes possible to use @EditableDeviceOnVmStatusField annotation for rngDevice field and to combine rngDevice update with other device updates in a single list. Optional<T> class may be used as well for other fields in VmManagementParametersBase that use the same pattern. Watchdog is one of them. Change-Id: If9aa41b0cacd77120b002123d8e196e215e20fdc Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 7 files changed, 167 insertions(+), 70 deletions(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9aa41b0cacd77120b002123d8e196e215e20fdc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Typos and minor fixes in OVF classes
by ofrenkel＠redhat.com 17 May '15

17 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Typos and minor fixes in OVF classes ...................................................................... core: Typos and minor fixes in OVF classes In OvfReader: doc comment fix and fixed typo in OvfReader.getNetwotkInterface() method name. In OvfTemplateWriter: using _vmTemplate instead of vmBase for consistency - both variables point to the same object. Fixed typo in comment. In OvfVmWriter: fixed typo in comment. In OvfLogEventHandlers: doc comment fixes and typos in comments and error messages. Change-Id: I06d45d1a5b5cef641b01164a2c2b797bdff3d021 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfLogEventHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java 4 files changed, 10 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06d45d1a5b5cef641b01164a2c2b797bdff3d021 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Extending disk editing when adding a new template.
by tnisan＠redhat.com 17 May '15

17 May '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Extending disk editing when adding a new template. ...................................................................... restapi: Extending disk editing when adding a new template. Currently when adding a new template, its disks edit is enabled only when the disk's storage domain is specified- In this case, editing any other field is ignored by the REST, and the request which is sent to the backend does not contain all the values the user posted. This patch makes the REST request for a new template to consider every given value related to the new template's disks whether the storage domain is specified and whether it is not, so the disk values that are provided will always be sent to backend. The specified attributes given in the REST request will be patched on the original disk using a mapper so that a sent disk will contain a default value in case some of its fields will not be provided by the user. Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03 Bug-Url: https://bugzilla.redhat.com/1222283 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java 2 files changed, 44 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Amit Aviram: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Maintain a list of scheduled quartz job in VdsManager
by masayag＠redhat.com 17 May '15

17 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Maintain a list of scheduled quartz job in VdsManager ...................................................................... engine: Maintain a list of scheduled quartz job in VdsManager The scheduled jobs of a host could be stored into a list to allow easier maintenance. Change-Id: I1efc1ad5a5ffca51f9e028b703905352ad92f88c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 29 insertions(+), 35 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1efc1ad5a5ffca51f9e028b703905352ad92f88c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Use typed empty map
by masayag＠redhat.com 17 May '15

17 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use typed empty map ...................................................................... engine: Use typed empty map Change-Id: Id8eb94354b479d4606a325380216e1f8b4969903 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 3 files changed, 4 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8eb94354b479d4606a325380216e1f8b4969903 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0