Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Fixed issue with null brick during sync
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Fixed issue with null brick during sync
......................................................................
engine: Fixed issue with null brick during sync
While syncing gluster volume info, if the server
associated with one of the bricks is not available
in the engine db, a null object was returned for the
brick. This causes NPE - handling that flow here.
Change-Id: I5760158318184b67ba52f8191ecd8f7fbdea902b
Bug-Url: https://bugzilla.redhat.com/1220263
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5760158318184b67ba52f8191ecd8f7fbdea902b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: Allow creation of new disks as copy of any existin...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Allow creation of new disks as copy of any existing disk
......................................................................
webadmin: Allow creation of new disks as copy of any existing disk
Allowed to make a copy of a VM disk
Change-Id: I9c11478216a11d12208365ebdc69b9665766f6ba
Bug-Url: https://bugzilla.redhat.com/1132066
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 101 insertions(+), 38 deletions(-)
Approvals:
Tomas Jelinek: Verified
Tal Nisan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c11478216a11d12208365ebdc69b9665766f6ba
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Allow creation of new disks as copy of any existing disk
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Allow creation of new disks as copy of any existing disk
......................................................................
core: Allow creation of new disks as copy of any existing disk
Allowed to make a copy of a VM disk
Change-Id: I07eece05b1880011f1a1b4300d07f0bd1ebf30bd
Bug-Url: https://bugzilla.redhat.com/1132066
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
5 files changed, 56 insertions(+), 51 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07eece05b1880011f1a1b4300d07f0bd1ebf30bd
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Fixed issue with null brick during sync
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Fixed issue with null brick during sync
......................................................................
engine: Fixed issue with null brick during sync
While syncing gluster volume info, if the server
associated with one of the bricks is not available
in the engine db, a null object was returned for the
brick. This causes NPE - handling that flow here.
Change-Id: I5760158318184b67ba52f8191ecd8f7fbdea902b
Bug-Url: https://bugzilla.redhat.com/1220263
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5760158318184b67ba52f8191ecd8f7fbdea902b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: avoid npe on vm disk creation without domain
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: avoid npe on vm disk creation without domain
......................................................................
restapi: avoid npe on vm disk creation without domain
Modified 'BackendVmDisksResource -> add()' to avoid an NPE
when creating a disk without a specified storage domain.
Change-Id: I34eaeec901ebcdbaaf49f4224eb1f1dfa4279cb1
Bug-Url: https://bugzilla.redhat.com/1220824
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/40826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34eaeec901ebcdbaaf49f4224eb1f1dfa4279cb1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: drop UserRefreshRate from config
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: drop UserRefreshRate from config
......................................................................
core: drop UserRefreshRate from config
it's not needed since rhbz#1176306
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1221012
Change-Id: Ifba974a82c9907b8e3c18872c2737275b0265d10
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
3 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38813
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifba974a82c9907b8e3c18872c2737275b0265d10
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: automatically shutdown engine VM on automa...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: automatically shutdown engine VM on automated setup
......................................................................
packaging: setup: automatically shutdown engine VM on automated setup
Adding support for automatically shutdown engine VM on automated setup
Change-Id: I6417a76302f71fc47bfc84c20aef9203ec4f1548
Bug-Url: https://bugzilla.redhat.com/1120780
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
3 files changed, 47 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40802
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6417a76302f71fc47bfc84c20aef9203ec4f1548
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: locked vm icon
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: locked vm icon
......................................................................
webadmin: locked vm icon
Until now, the in-memory lock status for a given VM was not exposed in
the UI. This patch changes the status icon to have an indication when
the VM is exclusively locked.
We add an icon of a lock which overlay the regular status icon of the
VM, in case it is exclusively locked.
Change-Id: I121c5e65eb3bdc740b1b0aaf05f5e12591a86e46
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VmStatusCell.java
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmStatus/vm_locked_overlay_icon.png
4 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/40754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I121c5e65eb3bdc740b1b0aaf05f5e12591a86e46
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Gluster volume snapshot scheduling UI changes
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Gluster volume snapshot scheduling UI changes
......................................................................
webadmin: Gluster volume snapshot scheduling UI changes
There were few comments on the labels and different options
shown on the volume snapshot scheduling screen. Incoporated
those comments so that labels for the fields are more
prominent and intuitive.
Change-Id: Iba8fb55284212c3c8313ce342964a3ca6a3b715a
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40840
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba8fb55284212c3c8313ce342964a3ca6a3b715a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: Gluster volume snapshot scheduling UI changes
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Gluster volume snapshot scheduling UI changes
......................................................................
webadmin: Gluster volume snapshot scheduling UI changes
There were few comments on the labels and different options
shown on the volume snapshot scheduling screen. Incoporated
those comments so that labels for the fields are more
prominent and intuitive.
Change-Id: Iba8fb55284212c3c8313ce342964a3ca6a3b715a
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Shubhendu Tripathi: Verified
anmolbabu: Looks good to me, but someone else must approve
Kanagaraj M: Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba8fb55284212c3c8313ce342964a3ca6a3b715a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months