Change in ovirt-engine[ovirt-engine-3.5.3]: webadmin: Fixed text wrapping in "New Cluster".
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed text wrapping in "New Cluster".
......................................................................
webadmin: Fixed text wrapping in "New Cluster".
On Webadmin in Deutsch the text "Optimize for speed" is now in the same
row as it's radio button.
Change-Id: Ibf48395c82a5e33fc2ab897dcad622c1ce055738
Bug-Url: https://bugzilla.redhat.com/1220120
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
(cherry picked from commit e1fc7ab8c81c5d14efafb0b581af08d9633b1cab)
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40858
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf48395c82a5e33fc2ab897dcad622c1ce055738
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.3]: webadmin: Fixed capitalization on "New Cluster".
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed capitalization on "New Cluster".
......................................................................
webadmin: Fixed capitalization on "New Cluster".
Fixed Capitalization on the "New Cluster" dialog.
The text: "Migrate only Highly Available Virtual Machines"
was changed to: "Migrate Only Highly Available Virtual Machines"
in order to match the capitalization with the two other options.
Change-Id: I9ea28360b7554d45b26df9194fc420ab8249f31b
Bug-Url: https://bugzilla.redhat.com/1220123
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ea28360b7554d45b26df9194fc420ab8249f31b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.3]: engine: Fix ambigous error message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Fix ambigous error message
......................................................................
engine: Fix ambigous error message
Fix error message to reflect the subject DiskProfile name and the
target StorageDomain name.
Sample fixed error message:
Operation Failed: [Cannot add VM. Disk Profile 'storage-profile-1-ds-2'
is not assigned to Storage Domain 'storage-domain-2'.]
Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b
Bug-Url: https://bugzilla.redhat.com/1220127
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40849
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.3]: engine: validate (vm NUMA nodes) <= (vm CPU cores)
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores)
......................................................................
engine: validate (vm NUMA nodes) <= (vm CPU cores)
Add validation in canDoAction(), in UpdateVmCommand.
Validate (vm NUMA nodes> <= (vm CPU cores), even if called from REST api
Generate a detailed error message:
[Cannot edit VM. Assigned 2 NUMA nodes for 1 CPU cores. Cannot assign
more NUMA nodes then CPU cores.]
Bug-Url: https://bugzilla.redhat.com/1220122
Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 66 insertions(+), 2 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed capitalization on "New Cluster".
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed capitalization on "New Cluster".
......................................................................
webadmin: Fixed capitalization on "New Cluster".
Fixed Capitalization on the "New Cluster" dialog.
The text: "Migrate only Highly Available Virtual Machines"
was changed to: "Migrate Only Highly Available Virtual Machines"
in order to match the capitalization with the two other options.
Change-Id: I9ea28360b7554d45b26df9194fc420ab8249f31b
Bug-Url: https://bugzilla.redhat.com/1220123
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/34895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ea28360b7554d45b26df9194fc420ab8249f31b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed text wrapping in "New Cluster".
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed text wrapping in "New Cluster".
......................................................................
webadmin: Fixed text wrapping in "New Cluster".
On Webadmin in Deutsch the text "Optimize for speed" is now in the same
row as it's radio button.
Change-Id: Ibf48395c82a5e33fc2ab897dcad622c1ce055738
Bug-Url: https://bugzilla.redhat.com/1220120
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Sivák: Verified
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/34838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf48395c82a5e33fc2ab897dcad622c1ce055738
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: validate (vm NUMA nodes) <= (vm CPU cores)
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores)
......................................................................
engine: validate (vm NUMA nodes) <= (vm CPU cores)
Add validation in canDoAction(), in UpdateVmCommand.
Validate (vm NUMA nodes> <= (vm CPU cores), even if called from REST api
Generate a detailed error message:
[Cannot edit VM. Assigned 2 NUMA nodes for 1 CPU cores. Cannot assign
more NUMA nodes then CPU cores.]
Bug-Url: https://bugzilla.redhat.com/1220122
Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 66 insertions(+), 2 deletions(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Fix ambigous error message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Fix ambigous error message
......................................................................
engine: Fix ambigous error message
Fix error message to reflect the subject DiskProfile name and the
target StorageDomain name.
Sample fixed error message:
Operation Failed: [Cannot add VM. Disk Profile 'storage-profile-1-ds-2'
is not assigned to Storage Domain 'storage-domain-2'.]
Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b
Bug-Url: https://bugzilla.redhat.com/1220127
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40847
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: aaa: builtin: manage-domains: convert to new parameters parser
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: aaa: builtin: manage-domains: convert to new parameters parser
......................................................................
aaa: builtin: manage-domains: convert to new parameters parser
Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java
A backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties
D backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/Argument.java
D backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilder.java
D backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParser.java
D backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ArgumentBuilderTest.java
D backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/cli/ExtendedCliParserTest.java
M packaging/bin/engine-manage-domains.sh
10 files changed, 400 insertions(+), 1,213 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Ondra Machacek: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: uutils: added new cli parser
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: uutils: added new cli parser
......................................................................
uutils: added new cli parser
Change-Id: I00042b669e19293641579582223e7ca40717132d
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/Argument.java
A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java
A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/StringValueConverter.java
A backend/manager/modules/uutils/src/main/resources/org/ovirt/engine/core/uutils/cli/parser/defaults.properties
4 files changed, 744 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Ondra Machacek: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve
mooli tayer: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40157
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
9 years, 7 months