Change in ovirt-engine[master]: userportal, webadmin: added optional underlining to column h...
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: added optional underlining to column headers
......................................................................
userportal, webadmin: added optional underlining to column headers
Some column headers require underlining when they have a tooltip set
(to indicate that the user can hover over them for a tooltip). Added
functionality to SafeHtmlHeader to achieve this.
Change-Id: I2d1e2094410dae6a33897401aa83a2212ef645fd
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
M packaging/branding/ovirt.brand/ovirt.css
4 files changed, 41 insertions(+), 12 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/40626
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d1e2094410dae6a33897401aa83a2212ef645fd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: fixed VMs > Disks de/activate tooltips
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: fixed VMs > Disks de/activate tooltips
......................................................................
webadmin: fixed VMs > Disks de/activate tooltips
Change-Id: I34196af6301316687279c8c4dffb95de8d5ce270
Bug-Url: https://bugzilla.redhat.com/1140158
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java
1 file changed, 6 insertions(+), 11 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/40614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34196af6301316687279c8c4dffb95de8d5ce270
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: validate (vm NUMA nodes) <= (vm CPU cores)
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: validate (vm NUMA nodes) <= (vm CPU cores)
......................................................................
engine: validate (vm NUMA nodes) <= (vm CPU cores)
Add validation in canDoAction(), in UpdateVmCommand.
Validate (vm NUMA nodes> <= (vm CPU cores), even if called from REST api
Generate a detailed error message:
[Cannot edit VM. Assigned 2 NUMA nodes for 1 CPU cores. Cannot assign
more NUMA nodes then CPU cores.]
Bug-Url: https://bugzilla.redhat.com/1196235
Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 71 insertions(+), 4 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4589721f3d9fa76509d2931b351c5517c06df334
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: Revert "webadmin: cluster guide me datacenter"
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: Revert "webadmin: cluster guide me datacenter"
......................................................................
Revert "webadmin: cluster guide me datacenter"
This reverts commit 11d5777f8bc8f970a56bb661ab77e35b0cdeac7b.
Change-Id: I38db944a4ccd5bc81ac2b69d23058b02ddbdf461
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/AddDataCenterClusterPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/guide/GuidePopupPresenterWidget.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.ui.xml
8 files changed, 172 insertions(+), 435 deletions(-)
Approvals:
Alexander Wels: Verified
Einav Cohen: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40821
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38db944a4ccd5bc81ac2b69d23058b02ddbdf461
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: restapi: missing authentication_url in rsdl
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: missing authentication_url in rsdl
......................................................................
restapi: missing authentication_url in rsdl
Added 'authentication_url' for openstacknetworkproviders and
openstackimageproviders.
Change-Id: Ia5d7fb4b1e5914b0670ecf8863b37fcb37fae5e5
Bug-Url: https://bugzilla.redhat.com/1202339
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/40819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5d7fb4b1e5914b0670ecf8863b37fcb37fae5e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: Validate disk model properties before flushing
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Validate disk model properties before flushing
......................................................................
webadmin: Validate disk model properties before flushing
Since commit 4dc19d308aa6f7944924c92908016c1b67f62544 the disk properties
are flushed before saving, this overrides the validation phase and in case
of setting of a primitive value to null, the unboxing throws an NPE.
Added a call to validation before flushing to solve this problem
Change-Id: Ifa982d1f2fff9c0b90a9a23f9480ce99b20f9e25
Bug-Url: https://bugzilla.redhat.com/1215974
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Verified
--
To view, visit https://gerrit.ovirt.org/40741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa982d1f2fff9c0b90a9a23f9480ce99b20f9e25
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: packaging: setup: fix duplicate dialog name
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fix duplicate dialog name
......................................................................
packaging: setup: fix duplicate dialog name
Not causing bugs currently.
Can interfere with automated testing that uses the dialog name to choose
an answer.
Change-Id: Ifca577858a5998bd05f39347b24f368131ca74e4
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/40815
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifca577858a5998bd05f39347b24f368131ca74e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: UI plugins - control tab priority
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugins - control tab priority
......................................................................
webadmin: UI plugins - control tab priority
When adding custom main or sub tab, UI plugins can now specify
the priority of the tab, denoting its relative position within
the tab panel.
Standard main and sub tabs typically have their priority starting
at 0 (left-most tab) and incremented by 1 for each next tab. For
example, "DataCenter" main tab priority is 0, "Cluster" main tab
priority is 1, and so on.
Example usage:
api.addMainTab('Test', 'test-tab', 'plugin/TestPlugin/tab.html',
// tab options object, as documented at
// http://www.ovirt.org/Features/UIPlugins#Main_and_sub_tabs
{
priority: -1 // position this tab before all standard ones
}
);
This patch also improves priority comparison in AbstractTabPanel
to account for rounding procedure, e.g. representing real numbers
in a floating point number system.
Change-Id: I1251ccbe7b3cfbb378fa31ef6009184216409265
Bug-Url: https://bugzilla.redhat.com/1214624
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/FloatingPointHelper.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTabPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/TabOptions.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxyFactory.java
5 files changed, 85 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/40510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1251ccbe7b3cfbb378fa31ef6009184216409265
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Karnan Chidambarakani <kchidamb(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: userportal, webadmin: fixed hanging tooltips on click
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fixed hanging tooltips on click
......................................................................
userportal, webadmin: fixed hanging tooltips on click
Added a click handler to Tooltip to close the Tooltip when mouse
is clicked anywhere in the application.
WidgetTooltips were missing the click handler functionality to
close tooltips on any mouse click. (ElementTooltip has its own
click handler that can probably be removed in a follow-up
patch.)
Change-Id: I79d21be8f9832635e1c13e2fb1b604b5817ba351
Bug-Url: https://bugzilla.redhat.com/1211171
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/Tooltip.java
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/40678
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79d21be8f9832635e1c13e2fb1b604b5817ba351
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Use description for discover FCP Storage in rsdl
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Use description for discover FCP Storage in rsdl
......................................................................
restapi: Use description for discover FCP Storage in rsdl
Adding a description in rsdl for unregisteredstoragedomainsdiscover
using FCP.
Change-Id: I0657db41409bdebe936bb1c254a0912b32a7af18
Bug-Url: https://bugzilla.redhat.com/1217456
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/40811
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0657db41409bdebe936bb1c254a0912b32a7af18
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months