May 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Extracting virtIO-scsi disabling check in CDA

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Extracting virtIO-scsi disabling check in CDA ...................................................................... core: Extracting virtIO-scsi disabling check in CDA VirtIO-scsi disabling validation in AddVmFromSnapshotCommand's CDA is extracted to an outer function for Simplification of the code. This enables a significant ease in unit-testing AddVmFromSnapshotCommand's functionality. Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Bug-Url: https://bugzilla.redhat.com/1220282 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/40727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: return backend instances with CDI instead JNDI

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: return backend instances with CDI instead JNDI ...................................................................... core: return backend instances with CDI instead JNDI Change-Id: I3710d057c7feffe3c14f9b8d582bbc1c70461fa8 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3710d057c7feffe3c14f9b8d582bbc1c70461fa8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Modified to disable the new snapshot creation

by sabose＠redhat.com

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Modified to disable the new snapshot creation ...................................................................... gluster: Modified to disable the new snapshot creation Modified to disable the option for new snapshot creation if some of the brick(s) are down for a volume. Also added a canDoAction engine side to take care of the same scenario. Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Bug-Url: https://bugzilla.redhat.com/1213238 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 3 files changed, 23 insertions(+), 4 deletions(-) Approvals: Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40716 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Adds title to Optimize for virt confirmation dialog

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Adds title to Optimize for virt confirmation dialog ...................................................................... webadmin: Adds title to Optimize for virt confirmation dialog The confirmation model window to confirm Optimize for virt store is added with title text, which was missing earlier Change-Id: I1e4fb62dc787220ceefc5d491bb0051da769cdef Bug-Url: https://bugzilla.redhat.com/1186598 Signed-off-by: Karnan TC <kchidamb(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 34 insertions(+), 13 deletions(-) Approvals: Karnan t c: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e4fb62dc787220ceefc5d491bb0051da769cdef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Add the "max" matrix parameter implicitly

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add the "max" matrix parameter implicitly ...................................................................... restapi: Add the "max" matrix parameter implicitly All collections support the "max" matrix parameter, so it is better to add it implicitly to the generated RSDL document and remove it from the metadata file. Change-Id: Iacf0e520d716b0df84e7b6e7b57ffff5911cb1c5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 2 files changed, 46 insertions(+), 291 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacf0e520d716b0df84e7b6e7b57ffff5911cb1c5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Fixes setup failure due to sql errors

by sabose＠redhat.com

Sahina Bose has submitted this change and it was merged. Change subject: engine : Fixes setup failure due to sql errors ...................................................................... engine : Fixes setup failure due to sql errors SQL function fn_db_add_config_value_for_versions_up_to() not available in ovirt-engine-3.5-gluster. Queries replaced with fn_db_add_config_value() Change-Id: I4a4ab29d21daf1a1954fd53a92333a67cfa14483 Signed-off-by: Karnan TC <kchidamb(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Karnan t c: Verified Eli Mesika: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a4ab29d21daf1a1954fd53a92333a67cfa14483 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: Try options from command line and settings

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Try options from command line and settings ...................................................................... cli: Try options from command line and settings Currently the connect command doesn't try to get the options from the command line, only from the settings. This is a regression introduced by a previous patch that removed the dependency on the "optparse" module. This patch fixes that issue. Change-Id: I497a9269390fa62406099854cbebf273664c04a6 Bug-Url: https://bugzilla.redhat.com/1135544 Related: https://bugzilla.redhat.com/1135550 Related: https://gerrit.ovirt.org/36257 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 42 insertions(+), 28 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I497a9269390fa62406099854cbebf273664c04a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine-sdk[master]: sdk: Always set the request body

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Always set the request body ...................................................................... sdk: Always set the request body The cURL library remembers the body of the request, and this means that after sending a POST with a body the next GET will have the same body. This isn't harmful, as servers will typically ignore bodies of GET requests, but it isn't ideal. To solve this issue this patch changes the SDK so that it will explicitly clear the request body. Change-Id: I028f2672fa7f817b21c12f8805d5bf09ae2bb61e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/connectionspool.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028f2672fa7f817b21c12f8805d5bf09ae2bb61e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in jenkins[master]: yaml: add default values for throttle concurrent builds

by eedri＠redhat.com

Eyal Edri has submitted this change and it was merged. Change subject: yaml: add default values for throttle concurrent builds ...................................................................... yaml: add default values for throttle concurrent builds - disabled by default - total max = 3 - total per node = 1 - option = project (run on this project only) Change-Id: I639434141a1937e804630732978c2d3237c20e2c Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/defaults/defaults.yaml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sagi Shnaidman: Looks good to me Sandro Bonazzola: Looks good to me; Ready for review Eyal Edri: Verified; Looks good to me; Ready for merge; Passed CI tests Jenkins CI: Looks good to me; Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/40740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I639434141a1937e804630732978c2d3237c20e2c Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

9 years, 7 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: don't print stack trace when the ha broker is unreachable

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: don't print stack trace when the ha broker is unreachable ...................................................................... don't print stack trace when the ha broker is unreachable Change-Id: I02cfcd2a59ede40efaa0747a7dd3b9758ffb5270 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150073 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit 70f27b8852cf47449313f85b5b672e0a1c3e86bb) --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Verified Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02cfcd2a59ede40efaa0747a7dd3b9758ffb5270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits May 2015