May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-backup: Updated --help output
by sbonazzo＠redhat.com 11 May '15

11 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Updated --help output ...................................................................... packaging: engine-backup: Updated --help output Change-Id: I48987840d9179ad2a010a1c89a3efe4689677020 Bug-Url: https://bugzilla.redhat.com/1188132 Signed-off-by: Lucy Bopf <lbopf(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 60 insertions(+), 57 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Lucy Bopf: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48987840d9179ad2a010a1c89a3efe4689677020 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lucy Bopf <lbopf(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Lucy Bopf <lbopf(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Modified to disable the new snapshot creation
by kmayilsa＠redhat.com 11 May '15

11 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Modified to disable the new snapshot creation ...................................................................... gluster: Modified to disable the new snapshot creation Modified to disable the option for new snapshot creation if some of the brick(s) are down for a volume. Also added a canDoAction engine side to take care of the same scenario. Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Bug-Url: https://bugzilla.redhat.com/1213238 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 3 files changed, 23 insertions(+), 4 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Extracting virtIO-scsi disabling check in CDA
by amureini＠redhat.com 10 May '15

10 May '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Extracting virtIO-scsi disabling check in CDA ...................................................................... core: Extracting virtIO-scsi disabling check in CDA VirtIO-scsi disabling validation in AddVmFromSnapshotCommand's CDA is extracted to an outer function for Simplification of the code. This enables a significant ease in unit-testing AddVmFromSnapshotCommand's functionality. Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Bug-Url: https://bugzilla.redhat.com/1215845 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/40710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: NPE fix in clone image from snapshot
by amureini＠redhat.com 10 May '15

10 May '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: NPE fix in clone image from snapshot ...................................................................... core: NPE fix in clone image from snapshot NPE is thrown from AddVmFromSnapshotCommand's CDA. This is caused because destStorages is filled with its domains only in the super's CDA- which is being called at the end of the function. This patch puts the call to super.CDA before the usage of destStorages. * Later on, this will be refactored, this patch is a fast fix for 3.5.3 build. Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3 Bug-Url: https://bugzilla.redhat.com/1215845 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix log to use info and not error
by mlipchuk＠redhat.com 10 May '15

10 May '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix log to use info and not error ...................................................................... core: Fix log to use info and not error Fix log to info instead of error. Change-Id: I01e4bec903504e85282078fc2e7fd7573d030430 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommandCallback.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01e4bec903504e85282078fc2e7fd7573d030430 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use set instead of List to prevent duplicate key violi...
by mlipchuk＠redhat.com 10 May '15

10 May '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use set instead of List to prevent duplicate key violiation ...................................................................... core: Use set instead of List to prevent duplicate key violiation Use set instead of List to prevent duplicate key violiation while building the associated command entities. Change-Id: I55a2933da86aec6202fd806bf1a5701811ed1207 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Maor Lipchuk: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55a2933da86aec6202fd806bf1a5701811ed1207 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Extends vds_dynamic with updates_available
by masayag＠redhat.com 10 May '15

10 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extends vds_dynamic with updates_available ...................................................................... engine: Extends vds_dynamic with updates_available The new attribute serves as indication for the availability of updates on the host to be installed. Change-Id: I7c788b17cb58791fe540b7130965a210557e68a5 Bug-Url: https://bugzilla.redhat.com/1157368 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1360_add_updates_available_to_vds_dynamic.sql M packaging/dbscripts/vds_sp.sql 9 files changed, 48 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/39862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c788b17cb58791fe540b7130965a210557e68a5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Added missing @Override in RemoveVmCommand
by ofrenkel＠redhat.com 10 May '15

10 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Added missing @Override in RemoveVmCommand ...................................................................... core: Added missing @Override in RemoveVmCommand Change-Id: Ife245557927d27e4aec5ee54fe48186eccb8c784 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife245557927d27e4aec5ee54fe48186eccb8c784 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove useless method
by masayag＠redhat.com 09 May '15

09 May '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove useless method ...................................................................... core: Remove useless method This method never used. Change-Id: I4167b4dd432f2818f91e7015d938da36817c1f11 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4167b4dd432f2818f91e7015d938da36817c1f11 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.3]: core: change other OS to 64bit
by piotr.kliczewski＠gmail.com 08 May '15

08 May '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: change other OS to 64bit ...................................................................... core: change other OS to 64bit Currently the default for the "other" OS is 32bit This patch uses the following OS heirarchy and changing accordingly the "other" OS to be 64bit other other linux SUSE RH3 RH4 RH5 RH6 RH3 64 RH4 64 RH5 64 RH6 64 RH7 64 Ubuntu 1204 Debian Ubuntu 1210 Ubuntu 1304 Ubuntu 1310 Ubuntu 1404 other PPC 64 Linux PPC 64 Ubuntu PPC 64 FreeBSD FreeBSD 64 XP Win 7 Win 7 64 Win 8 64 Win 8 Win 2003 Win 2008 Win 2003 64 Win 2008 64 Win 2008 R2 64 Win 2012 64 Change-Id: Ie2c3eb1d64145b9ee372deda01168f0b9732375b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1218531 Signed-off-by: emesika <emesika(a)redhat.com> (cherry picked from commit 80b697f464eec11a677c8410f53b774493cd326e) --- M packaging/conf/osinfo-defaults.properties 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2c3eb1d64145b9ee372deda01168f0b9732375b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.3 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0