May 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Add cinder helper method for Cinder disks

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add cinder helper method for Cinder disks ...................................................................... core: Add cinder helper method for Cinder disks Add Cinder helper method to return filtered subjectentities for Cinder disks. Change-Id: I59afc1d6814ccdf343615322f758bd473482a296 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59afc1d6814ccdf343615322f758bd473482a296 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in mom[master]: print more user friendly error when VM is powered down while...

by alitke＠redhat.com

Adam Litke has submitted this change and it was merged. Change subject: print more user friendly error when VM is powered down while running collectors ...................................................................... print more user friendly error when VM is powered down while running collectors The stacktrace will still get logged, but there will be human readable reason why it happened. Please note that this situation is rare so we shouldn't have problems with log floods Change-Id: I027b090a785883f79c7a678e8505c7e1d18bf2a8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1170512 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/35883 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/HypervisorInterfaces/vdsmInterface.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified -- To view, visit https://gerrit.ovirt.org/35883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I027b090a785883f79c7a678e8505c7e1d18bf2a8 Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5.3]: core: NPE fix in clone image from snapshot

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: NPE fix in clone image from snapshot ...................................................................... core: NPE fix in clone image from snapshot NPE is thrown from AddVmFromSnapshotCommand's CDA. This is caused because destStorages is filled with its domains only in the super's CDA- which is being called at the end of the function. This patch puts the call to super.CDA before the usage of destStorages. * Later on, this will be refactored, this patch is a fast fix for 3.5.3 build. Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3 Bug-Url: https://bugzilla.redhat.com/1220282 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/40753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.3 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5.3]: core: Extracting virtIO-scsi disabling check in CDA

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Extracting virtIO-scsi disabling check in CDA ...................................................................... core: Extracting virtIO-scsi disabling check in CDA VirtIO-scsi disabling validation in AddVmFromSnapshotCommand's CDA is extracted to an outer function for Simplification of the code. This enables a significant ease in unit-testing AddVmFromSnapshotCommand's functionality. Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Bug-Url: https://bugzilla.redhat.com/1220282 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/40752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.3 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in jenkins[master]: yaml: enable throttle builds for rpm install template

by eedri＠redhat.com

Eyal Edri has submitted this change and it was merged. Change subject: yaml: enable throttle builds for rpm install template ...................................................................... yaml: enable throttle builds for rpm install template Change-Id: I410e9561f4f003b4b2ef5666f7ce5a9d2e81021c Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/templates/install-rpm-sanity.yaml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Ready for merge Jenkins CI: Looks good to me; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I410e9561f4f003b4b2ef5666f7ce5a9d2e81021c Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

9 years, 7 months

1
0
0 / 0

Change in jenkins[master]: The workers option is not supported on test

by dcaroest＠redhat.com

David Caro has submitted this change and it was merged. Change subject: The workers option is not supported on test ...................................................................... The workers option is not supported on test It was removed from the test command on latest jjb Change-Id: Ic79a72f1d8358f9c7d36ad48c84403242aa275c0 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/jenkins_check_yaml.sh 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Looks good to me; Ready for review David Caro: Verified; Looks good to me; Ready for merge; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/40731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic79a72f1d8358f9c7d36ad48c84403242aa275c0 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: fix mocking validator in FenceValidatorTest

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: fix mocking validator in FenceValidatorTest ...................................................................... core: fix mocking validator in FenceValidatorTest Change-Id: Id62273e0b603488b13491541bf9aab5adc10e1a2 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/40755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id62273e0b603488b13491541bf9aab5adc10e1a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: using cloud-init to run engine-setup

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: using cloud-init to run engine-setup ...................................................................... packaging: setup: using cloud-init to run engine-setup Using cloud-init to run engine-setup on the engine appliance Change-Id: I305232fc44a524fd53e2d7fbd819ab5b95d4931c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1217106 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1077850 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/appliance_esetup.py M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py M src/vdsm_hooks/hostedengine.py 6 files changed, 400 insertions(+), 51 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I305232fc44a524fd53e2d7fbd819ab5b95d4931c Gerrit-PatchSet: 22 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: commited counted was missing vms

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: commited counted was missing vms ...................................................................... core: commited counted was missing vms Change-Id: Id94addb1a387b5aec284325c4cc0a17ad1cab9fb Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsListFetcherTest.java 4 files changed, 65 insertions(+), 18 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id94addb1a387b5aec284325c4cc0a17ad1cab9fb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: NPE fix in clone image from snapshot

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: NPE fix in clone image from snapshot ...................................................................... core: NPE fix in clone image from snapshot NPE is thrown from AddVmFromSnapshotCommand's CDA. This is caused because destStorages is filled with its domains only in the super's CDA- which is being called at the end of the function. This patch puts the call to super.CDA before the usage of destStorages. * Later on, this will be refactored, this patch is a fast fix for 3.5.3 build. Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3 Bug-Url: https://bugzilla.redhat.com/1220282 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/40728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c412298c017bd1dad6ee1248933907139d82e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits May 2015