Change in ovirt-engine[master]: engine: Use ProcessDownVmParameters instead of IdParameters
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Use ProcessDownVmParameters instead of IdParameters
......................................................................
engine: Use ProcessDownVmParameters instead of IdParameters
Besides the vmId ProcessDownVmParameters will also contain whether the
refresh of the host should be skipped.
Change-Id: I913ecde00122d190b45d0e8a0ce98886ec7f1b6a
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProcessDownVmParameters.java
7 files changed, 38 insertions(+), 12 deletions(-)
Approvals:
Alona Kaplan: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I913ecde00122d190b45d0e8a0ce98886ec7f1b6a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: engine: calling CollectVdsNetworkData after vm state changed...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: calling CollectVdsNetworkData after vm state changed to up
......................................................................
engine: calling CollectVdsNetworkData after vm state changed to up
When the vm's state is changed to up VSCommandType.CollectVdsNetworkData
should be called in case the vm contains virtual functions (since the nics
are detached from the host).
Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
6 files changed, 72 insertions(+), 16 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76
Gerrit-PatchSet: 30
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: engine: scheduling host- find free VF
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: scheduling host- find free VF
......................................................................
engine: scheduling host- find free VF
A VF is marked as suitable for a passthrough vnic in case:
1. It is free (reported by vdsCaps, not attached to vm, doesn't have vlan
device or network attached to it).
2. Its PF has the vnic's network (or label) in it's vf's configuration.
Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfScheduler.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
13 files changed, 606 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Verified
Roy Golan: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58c7aaa7a5a7160132418c397840583209aa8371
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: packaging: setup: print rpm updates list
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: print rpm updates list
......................................................................
packaging: setup: print rpm updates list
Printing rpm updates list asking
user confirmation.
Change-Id: Ie38d46a69d6b530caae15e43591315990e5d8dd4
Bug-Url: https://bugzilla.redhat.com/1168629
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40342
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie38d46a69d6b530caae15e43591315990e5d8dd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-hosted-engine-setup[master]: Adapt to VDSM 3.7 StorageDomainInfo API
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Adapt to VDSM 3.7 StorageDomainInfo API
......................................................................
Adapt to VDSM 3.7 StorageDomainInfo API
In VDSM 3.7 StorageDomainInfo returns a string for
the "type" key in the result dictionary.
The string should be ones between the names of the constants in
the enum type StorageDomainType defined in vdsm/rpc/vdsmapi-schema.json
The VDSM schema is missing GLUSTERFS but it's using it anyway.
Change-Id: Id5f45d088c943c62e0e5761cca1a565616b2dcc5
See-Also: https://bugzilla.redhat.com/1215039
Bug-Url: https://bugzilla.redhat.com/1213307
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
2 files changed, 15 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40503
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5f45d088c943c62e0e5761cca1a565616b2dcc5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: packaging: setup: fixing imports for dev-env environment
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing imports for dev-env environment
......................................................................
packaging: setup: fixing imports for dev-env environment
Avoid requiring docker as a generic import to avoid
breaking dev-env.
Change-Id: Ie04ac311b78abde8bceabcb89cbb4d30ec90a36d
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py
M packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie04ac311b78abde8bceabcb89cbb4d30ec90a36d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: core: support hot plug for Cinder disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: support hot plug for Cinder disks
......................................................................
core: support hot plug for Cinder disks
Support hot-plugging Cinder disks:
* Invoke 'VmInfoBuilder.buildCinderDisk' on HotPlugDiskVDSCommand.
* Update disk's CinderConnectionInfo on AbstractDiskVmCommand.
Change-Id: Ibe00f9e568a5ee0da1667bb8e57ac075cd5d03ed
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
4 files changed, 69 insertions(+), 49 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39658
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe00f9e568a5ee0da1667bb8e57ac075cd5d03ed
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5.3]: core: Add OVF_STORE disks registration on Data Center initia...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add OVF_STORE disks registration on Data Center initialization
......................................................................
core: Add OVF_STORE disks registration on Data Center initialization
Add existing OVF_STORE disks to Storage Domains which are registered to
the Data Center
Change-Id: I9a6dd41c220dd1e91c458e0af5a600860a3ae466
Bug-Url: https://bugzilla.redhat.com/1217339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/40485
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a6dd41c220dd1e91c458e0af5a600860a3ae466
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5.3]: core: Refactor register of OVF_STORE disks
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Refactor register of OVF_STORE disks
......................................................................
core: Refactor register of OVF_STORE disks
Refactor the OVF_STORE disks' registration on attach Storage Domain
process, by moving the code to StorageHandlingCommandBase,
so it can be used also for initializing a new Data Center.
Change-Id: I0d24f059c0073d8744b46b0d0697e323f63ce119
Bug-Url: https://bugzilla.redhat.com/1217339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
3 files changed, 236 insertions(+), 55 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/40484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d24f059c0073d8744b46b0d0697e323f63ce119
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: webadmin, userportal: Disable GWTP version checking
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Disable GWTP version checking
......................................................................
webadmin,userportal: Disable GWTP version checking
Disabled GWTP VersionInspectorLinker functionality in order
to avoid unnecessary overhead during GWT application builds.
Following text should not appear in build log anymore:
Invoking Linker Verify the availability of a more recent version of GWTP.
[INFO] Checking version information for gwtp-mvp-client
Change-Id: I52d88661d2d8cc6068bfdd2af59c5731abd8f434
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/40502
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52d88661d2d8cc6068bfdd2af59c5731abd8f434
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months