June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix EKU for VMConsole servlet
by ofrenkel＠redhat.com 09 Jun '15

09 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix EKU for VMConsole servlet ...................................................................... core: fix EKU for VMConsole servlet replace the EKU value with the correct one. Change-Id: I68b5fd4bd2d8fe44d1135569eef2a2fb67c63a1a Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Verified Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68b5fd4bd2d8fe44d1135569eef2a2fb67c63a1a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Move DiskSnapshot Remove to entity
by juan.hernandez＠redhat.com 09 Jun '15

09 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move DiskSnapshot Remove to entity ...................................................................... restapi: Move DiskSnapshot Remove to entity This patch moves the method that implements the DELETE operation from the collection interface to the entity interface. This is needed to avoid issues with newer versions of Resteasy. Change-Id: I63d10b373ae833fe300b855768512bcb3056455c Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskSnapshotResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskSnapshotsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotResourceTest.java 5 files changed, 36 insertions(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63d10b373ae833fe300b855768512bcb3056455c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Check Host Cluster Version in RefreshHostDevicesCom...
by ofrenkel＠redhat.com 09 Jun '15

09 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Check Host Cluster Version in RefreshHostDevicesCommand ...................................................................... backend: Check Host Cluster Version in RefreshHostDevicesCommand Change-Id: I8b8c81ebecbfe76bafef1cd0184626abaf045ba2 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java 2 files changed, 11 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8c81ebecbfe76bafef1cd0184626abaf045ba2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Size info in GB along side %
by amureini＠redhat.com 09 Jun '15

09 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Size info in GB along side % ...................................................................... webadmin: Size info in GB along side % In Storage General sub tab, there's a percentage threshold. Add to it the information in GB, out of the storage's total size. Change-Id: I6a4032a16909d66186e98d4535983fb8cce86f46 Bug-Url: https://bugzilla.redhat.com/1213134 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java 3 files changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/40729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a4032a16909d66186e98d4535983fb8cce86f46 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: Fixed BR49 report name
by ydary＠redhat.com 09 Jun '15

09 Jun '15

Yaniv Dary has submitted this change and it was merged. Change subject: reports: Fixed BR49 report name ...................................................................... reports: Fixed BR49 report name Change-Id: Ifdaf64d048d6146f289f26738fa26bb90264ddaf Bug-Url: https://bugzilla.redhat.com/1225045 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdaf64d048d6146f289f26738fa26bb90264ddaf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix coverity #1302429 and #1302428
by alkaplan＠redhat.com 09 Jun '15

09 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix coverity #1302429 and #1302428 ...................................................................... webadmin: fix coverity #1302429 and #1302428 Change-Id: I0a05a21c1c70f605cefc166159aba0ee349be10c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a05a21c1c70f605cefc166159aba0ee349be10c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: deleted old commented C# code
by ofrenkel＠redhat.com 09 Jun '15

09 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: deleted old commented C# code ...................................................................... core: deleted old commented C# code Not needed, removed Change-Id: Ibdbb1dfeaa087d31b02b702014688a5330af93c0 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllServerCpuListQuery.java 1 file changed, 0 insertions(+), 47 deletions(-) Approvals: Tomas Jelinek: Verified Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdbb1dfeaa087d31b02b702014688a5330af93c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin, engine : Refactored SizeUnit as per IEC binary pref...
by kmayilsa＠redhat.com 09 Jun '15

09 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin,engine : Refactored SizeUnit as per IEC binary prefixes ...................................................................... webadmin,engine : Refactored SizeUnit as per IEC binary prefixes This patch does the following: [1] Adds a AlternateMessage to dynamically form size string(size+unit) which in most places previously, used to do a normal string concat using '+' operator. [2] Added string equivalents to SizeUnit enum members and overrided toString of SizeUnit to return this string. The reason is, this toString can be later used to localize the string equivalents of SizeUnit units. [3] Removed some unused messges which turned unused after [1] above. [4] Modified some places to use SizeConverter#autoConvert to avoid replication of autoConvert logic. Change-Id: Ieacb29c0df8d5355a754a3db15f976a986d771fd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214137 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SizeConverterTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/DiskSizeLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateDiskListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaMemoryProgressBar.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaStorageProgressBar.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/RebalanceFileSizeRenderer.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VolumeCapacityRenderer.java 22 files changed, 73 insertions(+), 70 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieacb29c0df8d5355a754a3db15f976a986d771fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Removes option to create Disperse volumes from UI
by kmayilsa＠redhat.com 09 Jun '15

09 Jun '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Removes option to create Disperse volumes from UI ...................................................................... webadmin: Removes option to create Disperse volumes from UI Removes Disperse, Distributed Disperse volumes from create volume popup. Change-Id: I0c6632364f7a54a698702614fdbca8e8a4bd520a Bug-Url: https://bugzilla.redhat.com/1212302 Signed-off-by: Karnan TC <kchidamb(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Karnan t c: Verified Kanagaraj M: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c6632364f7a54a698702614fdbca8e8a4bd520a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Error messages translation fix
by masayag＠redhat.com 08 Jun '15

08 Jun '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Error messages translation fix ...................................................................... core: Error messages translation fix Error message with variable reference at the beginning results in empty string. E.g. "${foo} bar" Change-Id: Idad1f7ce2f48c8e05e0e4b4f7e34d559abd65cda Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idad1f7ce2f48c8e05e0e4b4f7e34d559abd65cda Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0