Change in ovirt-engine[master]: webadmin, userportal: added javadoc to AbstractUiCommandButton
by gshereme＠redhat.com
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin, userportal: added javadoc to AbstractUiCommandButton
......................................................................
webadmin, userportal: added javadoc to AbstractUiCommandButton
Change-Id: I17cc5df3cf7432e9b19c42db7753f9d59de16f0d
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Greg Sheremeta: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42874
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17cc5df3cf7432e9b19c42db7753f9d59de16f0d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin, userportal: translations update (Korean only)
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update (Korean only)
......................................................................
webadmin, userportal: translations update (Korean only)
pulled merged translations from test Zanata env in which
'3.5' translations were merged onto 'master' translations.
Change-Id: I2d81289ebb1f19bdfb056f611a8dd9d5e9f9156e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242698
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M backend/manager/modules/welcome/src/main/resources/messages_ko_KR.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ko_KR.properties
13 files changed, 802 insertions(+), 519 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Einav Cohen: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d81289ebb1f19bdfb056f611a8dd9d5e9f9156e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: VM Host Device dialog double-click support
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: VM Host Device dialog double-click support
......................................................................
webadmin: VM Host Device dialog double-click support
1. SplitTable now allows items to be moved between both tables
by double-clicking the item. Moving items this way retains
selection in both tables, excluding the item that was moved.
To enable this feature on given SplitTable:
splitTable.enableDoubleClickItemMoving();
2. VM Host Device dialog's SplitTable now has above mentioned
feature enabled.
Change-Id: Ibc21c4d81ce13b67bf6377762e269af8ddf61aae
Bug-Url: https://bugzilla.redhat.com/1099760
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SplitTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java
3 files changed, 110 insertions(+), 13 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/43726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc21c4d81ce13b67bf6377762e269af8ddf61aae
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: fix javadoc for internal list
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: fix javadoc for internal list
......................................................................
webadmin: fix javadoc for internal list
- Fixed javadoc to properly state the nature of the list.
Change-Id: I6ae793b1dd04db10e67d82d0a231d3bfef90c515
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBox.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified; Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ae793b1dd04db10e67d82d0a231d3bfef90c515
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: allow multi select list box
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: allow multi select list box
......................................................................
webadmin: allow multi select list box
- Added UiCommon aware multi select list box.
- Updated VM host selection box to allow multiple hosts to be
selected at once.
- Fixed typo of defualt to default.
Change-Id: Ibc8ca743036ebef6a645dc3b77cb6992dbe1a5e8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1107512
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBox.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBoxEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/TakesConstrainedValueListEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/TakesListValue.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/DedicatedVmForVdsUnitToVmBaseBuilder.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java
18 files changed, 379 insertions(+), 80 deletions(-)
Approvals:
Dudi Maroshi: Looks good to me, but someone else must approve
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc8ca743036ebef6a645dc3b77cb6992dbe1a5e8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: an action/new event would cause system tree refresh
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: an action/new event would cause system tree refresh
......................................................................
webadmin: an action/new event would cause system tree refresh
- Any action/new event would cause the system tree refresh timer
to start and never stop even though models timer is disabled
on purpose. This causes unnecessary network traffic.
Change-Id: I2252e5b3a36d0bbab87d22f5c9c7c03bef58e90e
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
2 files changed, 47 insertions(+), 11 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2252e5b3a36d0bbab87d22f5c9c7c03bef58e90e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: frontend: Adjust graphics column name
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Adjust graphics column name
......................................................................
frontend: Adjust graphics column name
in main VM view.
Change-Id: Ibda16a4251022f869250f141019d3c90511ca91b
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1194287
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/38004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibda16a4251022f869250f141019d3c90511ca91b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine-sdk-java[master]: sdk: Register only relevant auth schemes
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Register only relevant auth schemes
......................................................................
sdk: Register only relevant auth schemes
Currently the SDK uses the default set of authentication scheme
factories, but some of them can't be used even if the server supports
them because the SDK may not have the required credentials. For example,
the caller may have initialized the SDK activating Kerberos but without
providing a user name and password:
Api api = new ApiBuilder()
.url("https://...")
.kerberos(true)
.build();
This is completely normal. But the server may support both Kerberos and
Basic authentication, responding with the following headers:
WWW-Authenticate: Negotiate
WWW-Authenticate: Basic realm="My realm"
In this case the underying HTTP library will first try to use the
Negotiate authentication scheme, and if it fails (there is no TGT in the
Kerberos credentials cache, for example) it will try Basic. But basic
will not work because the SDK doesn't have any valid credentials, and
will actually generate a NPE.
To avoid this issue this patch changes the SDK so that it only registers
the authentication schemes it has credentials for.
Change-Id: Iaafc13d9128a6e6072dbf02e85f7a3eedc1af838
Bug-Url: https://bugzilla.redhat.com/1243337
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/Makefile
M sdk/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java
2 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaafc13d9128a6e6072dbf02e85f7a3eedc1af838
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-host-deploy[master]: plugins: split pki into common group
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: plugins: split pki into common group
......................................................................
plugins: split pki into common group
modify default of vdsm to enrollment none as engine enforced this since
started to use host-deploy.
Change-Id: Ia165e1c3be5e7cc6daeeb195c3fe419e208237a1
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
M ovirt-host-deploy.spec.in
M po/POTFILES.in
M src/bin/executor.in
M src/interface-3/Makefile.am
M src/plugins/Makefile.am
A src/plugins/ovirt-host-common/Makefile.am
A src/plugins/ovirt-host-common/vdsm/Makefile.am
A src/plugins/ovirt-host-common/vdsm/__init__.py
R src/plugins/ovirt-host-common/vdsm/pki.py
A src/plugins/ovirt-host-common/vmconsole/Makefile.am
A src/plugins/ovirt-host-common/vmconsole/__init__.py
R src/plugins/ovirt-host-common/vmconsole/pki.py
M src/plugins/ovirt-host-deploy/vdsm/Makefile.am
M src/plugins/ovirt-host-deploy/vdsm/__init__.py
M src/plugins/ovirt-host-deploy/vmconsole/Makefile.am
M src/plugins/ovirt-host-deploy/vmconsole/__init__.py
17 files changed, 193 insertions(+), 8 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, approved; Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/43151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia165e1c3be5e7cc6daeeb195c3fe419e208237a1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in jenkins[master]: slf4j: require only specific rpms not entire repo
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: slf4j: require only specific rpms not entire repo
......................................................................
slf4j: require only specific rpms not entire repo
Change-Id: I023bb4d34a4995fe11f5e45b1cc8fdd3ce264791
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
David Caro: Verified; Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/43933
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I023bb4d34a4995fe11f5e45b1cc8fdd3ce264791
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
9 years, 5 months