Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Calling vdsm-tool configure after touching its conf files
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Calling vdsm-tool configure after touching its conf files
......................................................................
Calling vdsm-tool configure after touching its conf files
After changing vdsm configuration we explicitly have to call
vdsm-tool configure to make it effective cause simply reloading
the service is not enough.
Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235591
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
1 file changed, 33 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-hosted-engine-setup[master]: Calling vdsm-tool configure after touching its conf files
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Calling vdsm-tool configure after touching its conf files
......................................................................
Calling vdsm-tool configure after touching its conf files
After changing vdsm configuration we explicitly have to call
vdsm-tool configure to make it effective cause simply reloading
the service is not enough.
Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235591
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
1 file changed, 33 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c6f1efd71926c59082f20d841eeea2957dad656
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: bug fix in ImportVmFromExportDomainModel
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: bug fix in ImportVmFromExportDomainModel
......................................................................
webadmin: bug fix in ImportVmFromExportDomainModel
In the "Import Virtual Machine(s)" view, under the Disks sub tab, one
couldn't change a disk's destination storage domain since the drop down
list won't accept his selection.
This patch fixes this bug, so now one can change the storage domain.
Change-Id: I4f4cbb1128ff0032e48cfa7df99870f7dd757da6
Bug-Url: https://bugzilla.redhat.com/1217379
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/43943
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f4cbb1128ff0032e48cfa7df99870f7dd757da6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Disallow ISO on local host in a non-local DC
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disallow ISO on local host in a non-local DC
......................................................................
webadmin: Disallow ISO on local host in a non-local DC
Change-Id: I5af17652bcfa5b1adb511fed316d320ba9431d3b
Bug-Url: https://bugzilla.redhat.com/1243876
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved; Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/43805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5af17652bcfa5b1adb511fed316d320ba9431d3b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Removed local SD option for shared/none DCs
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Removed local SD option for shared/none DCs
......................................................................
webadmin: Removed local SD option for shared/none DCs
Change-Id: I775f9ca1ee4ed1b5e808aa28a64825cf34d3d30e
Bug-Url: https://bugzilla.redhat.com/1244479
Bug-Url: https://bugzilla.redhat.com/1243882
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
4 files changed, 44 insertions(+), 25 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved; Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/43751
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I775f9ca1ee4ed1b5e808aa28a64825cf34d3d30e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: StorageModel to inherit from Model
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: StorageModel to inherit from Model
......................................................................
webadmin: StorageModel to inherit from Model
Removed the inheritance from ListModel<IStorageModel> .
A list of IStorageModels is now a data member of the class.
Change-Id: If443951bcd21e1e0130b4141d808659060591155
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java
7 files changed, 34 insertions(+), 22 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved; Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/43439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If443951bcd21e1e0130b4141d808659060591155
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Align domain function items in import and new domain
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Align domain function items in import and new domain
......................................................................
webadmin: Align domain function items in import and new domain
The order of domain function item in the import view was wrong.
It is now the same as in the New Domain view.
Change-Id: I04e157754cc7be872898f0f1c0ba5708b820e64e
Bug-Url: https://bugzilla.redhat.com/1241576
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved; Passed CI tests
Maor Lipchuk: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/43438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04e157754cc7be872898f0f1c0ba5708b820e64e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Remove the "selectedItem" terminology from Storage...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Remove the "selectedItem" terminology from StorageModel.
......................................................................
webadmin: Remove the "selectedItem" terminology from StorageModel.
privateAvailableiStorageItems List now appears only behind the scenes. We have
StorageType and StorageDomainType lists seperatly now, which *are*
displayed. Though this list is no longer displayed, it plays a great logical
part. This patch removes the list.
This is the first setp in making StorageModel inherit from Model instead
of ListModel<IStorageModel> .
Change-Id: I5d16972f8155ccea4505fd268683cbe92b079a84
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
7 files changed, 145 insertions(+), 131 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/43317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d16972f8155ccea4505fd268683cbe92b079a84
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: engine: Branding warning message
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: engine: Branding warning message
......................................................................
engine: Branding warning message
- Branding was generating a repeating warning message
when logged into the web admin. This was due to a
forward to the services path without the services
having the locale filter configured.
Change-Id: Ia3ff42bcd884e23635facbc8763f9071ee79493e
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Verified; Passed CI tests
Einav Cohen: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
Omer Frenkel: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3ff42bcd884e23635facbc8763f9071ee79493e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Set VDS status to down after ssh shutdown
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Set VDS status to down after ssh shutdown
......................................................................
core: Set VDS status to down after ssh shutdown
Fix that the state was only set to down for the VDS instance which was
passed into the command. When querying for the VDS in the database it
still showed that the VDS was up.
Further the audit log did not show that the ssh shutdown was executed.
Now it logs USER_VDS_STOP on success and USER_FAILED_VDS_STOP otherwise.
Change-Id: I7f837e5d179a3ed0090fa76eef965a7df673940d
Bug-Url: https://bugzilla.redhat.com/1062228
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java
1 file changed, 11 insertions(+), 6 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43855
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f837e5d179a3ed0090fa76eef965a7df673940d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months