Change in ovirt-engine[master]: core: ProcessDownVmCommand.isRemovingVmPool() refactoring
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: ProcessDownVmCommand.isRemovingVmPool() refactoring
......................................................................
core: ProcessDownVmCommand.isRemovingVmPool() refactoring
In ProcessDownVmCommand.isRemovingVmPool() using getVmPoolCached()
instead of fetching VmPool instance from DB.
Change-Id: I1f0640aa7e36d001ae9d03925c15c807f9affd70
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f0640aa7e36d001ae9d03925c15c807f9affd70
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Keep stateless snapshot on VM down for VMs from manual...
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Keep stateless snapshot on VM down for VMs from manual pool
......................................................................
core: Keep stateless snapshot on VM down for VMs from manual pool
For VMs from manual pool do not run RestoreStatelessVmCommand from
ProcessDownVmCommand. It will be called later from
DetachUserFromVmFromPoolCommand, when the VM will be manually returned
to the pool.
Change-Id: I72104e2bbd1aa3a02267cb32b29e8f101002ec48
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1239153
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
1 file changed, 18 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72104e2bbd1aa3a02267cb32b29e8f101002ec48
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: tools: Added enabling option to config for AREM.
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: tools: Added enabling option to config for AREM.
......................................................................
tools: Added enabling option to config for AREM.
AREM (Affinity Rules Enforcement Manager) can be enabled or disabled
on engine startup using the engine-config tools.
To enabled/disable AREM, run in the shell:
engine-config -s AffinityRulesEnforcementManager=false #To disable AREM
engine-config -s AffinityRulesEnforcementManager=true #To enable AREM
*AREM is enabled by default.
Change-Id: I4f2dfaf240970fbf6595476a798cd5e8d03aa323
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
4 files changed, 12 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43462
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f2dfaf240970fbf6595476a798cd5e8d03aa323
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Allow importing hosted engine storage domain
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Allow importing hosted engine storage domain
......................................................................
core: Allow importing hosted engine storage domain
Allow importing the special storage domain of the hosted engine VM.
Change-Id: I79b3f1227ef99a778654dc83fc4530f602085d80
Bug-Url: https://bugzilla.redhat.com/1160094
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java
4 files changed, 4 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
Omer Frenkel: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79b3f1227ef99a778654dc83fc4530f602085d80
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in mom[master]: guest manager: reorganize internals
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: guest manager: reorganize internals
......................................................................
guest manager: reorganize internals
this apparently large patch reorganize
the internals of GuestManager with only renames
and code move inside the class, to
mark private methods as such and to make room
for another implementation using a single thread.
Change-Id: I8ecc6f56f326b2eb20ef84479387c4aaf3e7f147
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37825
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
---
M mom/GuestManager.py
1 file changed, 45 insertions(+), 45 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/37825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ecc6f56f326b2eb20ef84479387c4aaf3e7f147
Gerrit-PatchSet: 13
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in mom[master]: monitor: simplify should_run implementation
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: monitor: simplify should_run implementation
......................................................................
monitor: simplify should_run implementation
Make the method a couple of lines shorter.
Change-Id: Id41a43f430d09dfba7eded27f58f4036dcfa48a6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/41378
Reviewed-by: Adam Litke <alitke(a)redhat.com>
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
Continuous-Integration: Jenkins CI
---
M mom/Monitor.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Adam Litke: Looks good to me, approved
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/41378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id41a43f430d09dfba7eded27f58f4036dcfa48a6
Gerrit-PatchSet: 7
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in mom[master]: guest monitor: split monitor from thread
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: guest monitor: split monitor from thread
......................................................................
guest monitor: split monitor from thread
We have the GuestMonitor class which inherits from threading.Thread,
and takes care of the per-VM monitor book-keeping and of the monitoring
loop.
This patch splits the class in two, with an explicit monitoring thread,
decoupling the two responsabilities.
This is needed for better scalability, because this way we can now
optionally demand the actual invocation of the monitoring code to
the hypervisor, which can integrate it with its monitoring loop(s).
Moreover, this patch also adds explicit registration and deregistration
methods for Guest Monitor objects inside the Guest Manager.
Besides a little cleanup, this patch makes room for
a future patch want to optionally demand the collection of
the MOM stats to hypervisor.
The old behaviour is preserved through fallback code.
Change-Id: I224104f8b353d92a420723d3415df94aaf68da0c
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/31591
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
---
M mom/GuestManager.py
M mom/GuestMonitor.py
M mom/HostMonitor.py
M mom/Monitor.py
4 files changed, 65 insertions(+), 38 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/31591
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I224104f8b353d92a420723d3415df94aaf68da0c
Gerrit-PatchSet: 20
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Pavlásek <mpavlase(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: Reuse Affinity Group collision checking in the Affinity CRUD
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: Reuse Affinity Group collision checking in the Affinity CRUD
......................................................................
Reuse Affinity Group collision checking in the Affinity CRUD
Unify the code for checking Afffinity rule collisions used by AREM
and CRUD command.
Change-Id: Idc954ef95a2a8b79c2828ee3f4c455f66276eacf
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
3 files changed, 165 insertions(+), 185 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43502
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc954ef95a2a8b79c2828ee3f4c455f66276eacf
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-hosted-engine-setup[master]: packaging: spec: requires gluster packages
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: requires gluster packages
......................................................................
packaging: spec: requires gluster packages
requires gluster packages where available
Change-Id: If92916b6346120c5e03b974c1735c0a06833296e
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43528
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If92916b6346120c5e03b974c1735c0a06833296e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: move shouldVdsBeFenced() to VDS
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: move shouldVdsBeFenced() to VDS
......................................................................
core: move shouldVdsBeFenced() to VDS
Move shouldVdsBeFenced() method from HostValidator to the VDS class
where it should belong.
Change-Id: I3a2401c57375931f01c59037b070273702267829
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
5 files changed, 23 insertions(+), 42 deletions(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a2401c57375931f01c59037b070273702267829
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months