July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix Coverity warnings
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix Coverity warnings ...................................................................... core: fix Coverity warnings The patch fixes the following warnings : ** CID 1311515: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java: 473 in org.ovirt.engine.core.bll.RemoveSnapshotSingleDiskLiveCommand.handleAnyChildSPMTaskCompletion(boolean)() ________________________________________________________________________________________________________ *** CID 1311515: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java: 473 in org.ovirt.engine.core.bll.RemoveSnapshotSingleDiskLiveCommand.handleAnyChildSPMTaskCompletion(boolean)() 467 command.getParameters().setTaskGroupSuccess(false); 468 } 469 Backend.getInstance().endAction(VdcActionType.DestroyImage, 470 command.getParameters(), 471 cloneContextAndDetachFromParent()); 472 if (succeeded) { >>> CID 1311515: Null pointer dereferences (NULL_RETURNS) >>> Calling a method on null object >>> "org.ovirt.engine.core.bll.tasks.CommandCoordinatorUtil.getCommandEntity(currentChildId)". 473 CommandCoordinatorUtil.getCommandEntity(currentChildId).setCallbackNotified(true); 474 } 475 } 476 } 477 } 478 ** CID 1311514: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java: 131 in org.ovirt.engine.core.bll.MergeExtendCommand.handleAnyChildSPMTaskCompletion(boolean)() ________________________________________________________________________________________________________ *** CID 1311514: Null pointer dereferences (NULL_RETURNS) /backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java: 131 in org.ovirt.engine.core.bll.MergeExtendCommand.handleAnyChildSPMTaskCompletion(boolean)() 125 command.getParameters().setTaskGroupSuccess(false); 126 } 127 Backend.getInstance().endAction(VdcActionType.ExtendImageSize, 128 command.getParameters(), 129 cloneContextAndDetachFromParent()); 130 if (succeeded) { >>> CID 1311514: Null pointer dereferences (NULL_RETURNS) >>> Calling a method on null object >>> "org.ovirt.engine.core.bll.tasks.CommandCoordinatorUtil.getCommandEntity(currentChildId)". 131 CommandCoordinatorUtil.getCommandEntity(currentChildId).setCallbackNotified(true); 132 } 133 } 134 } 135 } 136 Change-Id: I2b570ebb029d82e9497b7c06f465b4012dec1ec0 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b570ebb029d82e9497b7c06f465b4012dec1ec0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: swap hostdev vendor and product columns
by tjelinek＠redhat.com 13 Jul '15

13 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: swap hostdev vendor and product columns ...................................................................... frontend: swap hostdev vendor and product columns We should follow the format set by lspci - having vendor column first and product column next. This leads to more consistent device display in linux ecosystem. Change-Id: I6d70a80c395e979f6ab44dba827777163668ad1b Signed-off-by: Martin Polednik <mpolednik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostDeviceModelBaseTable.java 2 files changed, 15 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/43508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d70a80c395e979f6ab44dba827777163668ad1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Temporary avoid creating OVF_STORE for Cinder.
by mlipchuk＠redhat.com 13 Jul '15

13 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Temporary avoid creating OVF_STORE for Cinder. ...................................................................... core: Temporary avoid creating OVF_STORE for Cinder. Avoid creating OVF_STORE disks for Cinder Storage Domains, until it will be supported with VDSM Change-Id: Ieb6a330c17b465dadd05010bccf985655a5038ad Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb6a330c17b465dadd05010bccf985655a5038ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: added check to disallow having the same graphics devic...
by tjelinek＠redhat.com 13 Jul '15

13 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added check to disallow having the same graphics device more times ...................................................................... core: added check to disallow having the same graphics device more times Change-Id: I9677d8ed3f8eecae580658135572832e892a2861 Bug-Url: https://bugzilla.redhat.com/1236497 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetGraphicsDevicesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 42 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9677d8ed3f8eecae580658135572832e892a2861 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: merge VdsValidator into HostValidator
by emesika＠redhat.com 13 Jul '15

13 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: core: merge VdsValidator into HostValidator ...................................................................... core: merge VdsValidator into HostValidator Merging VdsValidator into HostValidator Change-Id: Ie552cce3e5393e2429d40bd98afe8c4e746b68f3 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetHaMaintenanceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMomPolicyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java 9 files changed, 146 insertions(+), 20 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie552cce3e5393e2429d40bd98afe8c4e746b68f3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: guest agent network interfaces not shown
by masayag＠redhat.com 13 Jul '15

13 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: guest agent network interfaces not shown ...................................................................... engine: guest agent network interfaces not shown The patch fixes a problem where 'Guest Agent Data' under 'Network Interfaces' doesn't shows any data. Change-Id: I0aad873825761820d3d4794aec8b5ccc3f40020f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1190753 Signed-off-by: mmirecki <mmirecki(a)redhat.com> Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Marcin Mirecki: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0aad873825761820d3d4794aec8b5ccc3f40020f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: skip alert if unlock run from setup
by emesika＠redhat.com 13 Jul '15

13 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: tools: skip alert if unlock run from setup ...................................................................... tools: skip alert if unlock run from setup This patch introduce a new -i flag for the unlock_entity.sh If this flag is set, no alert will be inserted to audit_log. asynctasks.py was modified to include this flag in order to suppress alerts when unlock-entity.sh is called from engine-setup Change-Id: If12135790dd8e2d21106b1feb8b0118a1f9fb0fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209786 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/setup/dbutils/unlock_entity.sh M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 2 files changed, 23 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved; Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If12135790dd8e2d21106b1feb8b0118a1f9fb0fe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: external providers in import vm dialog
by ahadas＠redhat.com 13 Jul '15

13 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: external providers in import vm dialog ...................................................................... webadmin: external providers in import vm dialog Add the ability to select external provider when importing from VMware. In such case, the configuration is copied from the provider. Change-Id: I036bf10889af4478fb0afb0ffedcf5ddc2b3ac3b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 4 files changed, 120 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I036bf10889af4478fb0afb0ffedcf5ddc2b3ac3b Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: no way to set instance type
by tjelinek＠redhat.com 13 Jul '15

13 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: no way to set instance type ...................................................................... webadmin: no way to set instance type When selected an instance type it was reset to "custom" immediately. The regression has been introduced by https://gerrit.ovirt.org/#/c/41486/2 by call getListModel().setSelectedItem(null); from EntityModelCellTable which fires the events outside of the control of the models. Since this broke the VM dialog already second time the fix was to rewrite the priority to use list box instead of EntityModelCellTable. This patch also adds the callback to PriorityUtil so the caller can activate/deactivate the instance type manager as needed. Last change was to change the watchdog panel so it looks consistently with the rest of the dialog (the difference became obvious after changing the priority to list box). Change-Id: I6127fb69c8b201e56ab1f13e28448c9fdebc4196 Bug-Url: https://bugzilla.redhat.com/1241403 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PriorityUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 5 files changed, 68 insertions(+), 29 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6127fb69c8b201e56ab1f13e28448c9fdebc4196 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: scheduling: Add missing createMapOfVmToHost method to AREM
by rgolan＠redhat.com 13 Jul '15

13 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Add missing createMapOfVmToHost method to AREM ...................................................................... scheduling: Add missing createMapOfVmToHost method to AREM Add a method that was accidentally removed during merge cleanup. Change-Id: Iad63e49bd4d766d7b845c70ce822021743b9b737 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad63e49bd4d766d7b845c70ce822021743b9b737 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0