Change in ovirt-engine-sdk[master]: sdk: Regenerate against the latest API
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Regenerate against the latest API
......................................................................
sdk: Regenerate against the latest API
This patch regenerates the SDK using the latest API obtained from the
engine built from commit 9eca55a.
Change-Id: Idf487d81814cf7f24196a0d32a6f940612b0da4a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M generator/src/main/resources/api.xsd
M generator/src/main/resources/rsdl.xml
M setup.py
M src/ovirtsdk/api.py
M src/ovirtsdk/infrastructure/brokers.py
M src/ovirtsdk/xml/params.py
7 files changed, 1,314 insertions(+), 259 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43470
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf487d81814cf7f24196a0d32a6f940612b0da4a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Remove getStorageServerConnectionsByDomain
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove getStorageServerConnectionsByDomain
......................................................................
core: Remove getStorageServerConnectionsByDomain
All the calls to
IStorageHelper.getStorageServerConnectionsByDomain(StorageDomainStatic)
were removed in commit cb69a5be696c16df57a2839a15ebe4dbd7a892e2 during
oVirt 3.5.0's development. Since then, this function has not been used,
and thus should be removed, along with its various implementations.
Change-Id: I7996a92013d4460e30e0f33e5fc5249d8be721ad
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
4 files changed, 0 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7996a92013d4460e30e0f33e5fc5249d8be721ad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: Check PV size for available LUN size
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Check PV size for available LUN size
......................................................................
webadmin: Check PV size for available LUN size
When calculating available additional size of a LUN, we need to check if
the PV is not zero.
It can happen on LUNs that don't have PVs or in case the VDSM is older
than 3.6 .
Change-Id: I3b67bccfa5940f62449ebe473dee1d98504e47c7
Relates-To: https://bugzilla.redhat.com/609689
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/43372
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b67bccfa5940f62449ebe473dee1d98504e47c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: engine: Sysprep attached by default on new Windows VMs
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Sysprep attached by default on new Windows VMs
......................................................................
engine: Sysprep attached by default on new Windows VMs
By default we attach Sysprep to a new Windows VM - now that we have
"Initial Run" we will attach Sysprep only to a VM that set this option
on.
Bug-Url: https://bugzilla.redhat.com/1240900
Change-Id: Ia2a1142457df45843b57483913c8ea518aec0d0b
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
2 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2a1142457df45843b57483913c8ea518aec0d0b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: core: handle Live Merge when top volume is larger than base
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: handle Live Merge when top volume is larger than base
......................................................................
core: handle Live Merge when top volume is larger than base
When a Live Merge is perfomed today, it internally performs a block
commit operation to copy data from a volume to its parent. If the disk
had been extended after the snapshot was created, the sizes of the two
volumes will not match.
In most cases the size is adjusted properly by the underlying processes
performing the merge; to account for this, engine will update the size
of the volume in the database to reflect the new, correct size.
In the case of a raw volume on block storage, an explicit extension
needs to take place before the merge. For this, a new child command of
Live Merge has been added to run before the merge starts.
For further detail, see comments to:
https://bugzilla.redhat.com/show_bug.cgi?id=1232481
Change-Id: I628323b799a37691c40ea97590d4967f3ebf4a2b
Bug-Url: https://bugzilla.redhat.com/1241433
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExtendImageSizeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotSingleDiskLiveStep.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
7 files changed, 212 insertions(+), 3 deletions(-)
Approvals:
Greg Padgett: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I628323b799a37691c40ea97590d4967f3ebf4a2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: engine: allowing prefix as mask staticIP conf in HostSetupNe...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: allowing prefix as mask staticIP conf in HostSetupNetworksVDSCommand
......................................................................
engine: allowing prefix as mask staticIP conf in HostSetupNetworksVDSCommand
Change-Id: If9ff4b9f5eda9d3c8127ac19bf24b4b35317e86b
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/39861
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ff4b9f5eda9d3c8127ac19bf24b4b35317e86b
Gerrit-PatchSet: 49
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: missing audit log variables definition
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: missing audit log variables definition
......................................................................
core: missing audit log variables definition
produced auditlog messages for labelling / unlabelling nics contains
variables, which are unset and thus substituted as <UNKNOWN>.
Change-Id: I075340bce87ec71443e7afa3db7bbab8916b7146
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnlabelNicCommand.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I075340bce87ec71443e7afa3db7bbab8916b7146
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: fixing unset nicId. when adding new bond and attaching...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: fixing unset nicId. when adding new bond and attaching network to it, given network attachment will not have nicId set and only here we can set it.
......................................................................
core: fixing unset nicId.
when adding new bond and attaching network to it, given network
attachment will not have nicId set and only here we can set it.
Change-Id: Idbfec4ec783a0db19b0079b79d0ae28dd5a76280
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43104
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbfec4ec783a0db19b0079b79d0ae28dd5a76280
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: error fix: cannot add network to nic and use this nic ...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: error fix: cannot add network to nic and use this nic as a slave in one request
......................................................................
core: error fix: cannot add network to nic and use this nic as a slave in one request
Change-Id: I3230f54a3b4f765bb63285d86faf8317ed5c8254
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 82 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3230f54a3b4f765bb63285d86faf8317ed5c8254
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: missing translation in ExecutionMessages.properties
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: missing translation in ExecutionMessages.properties
......................................................................
core: missing translation in ExecutionMessages.properties
Change-Id: I6c816cfeccd2ed10909dc6b1eeb1d979a056814a
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42659
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c816cfeccd2ed10909dc6b1eeb1d979a056814a
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months