Change in ovirt-engine[master]: webadmin: increase providers popup height
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: increase providers popup height
......................................................................
webadmin: increase providers popup height
Increase the height of the external providers popup dialog so there
will be no scroll bar displayed for defining/editing an external
provider of type VMware.
Change-Id: I8c73b94d3fc7fbc0acb4e711c974f42d12b1e91a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/44126
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c73b94d3fc7fbc0acb4e711c974f42d12b1e91a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin, userportal: Use "[N/A]" for empty values in forms
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: webadmin,userportal: Use "[N/A]" for empty values in forms
......................................................................
webadmin,userportal: Use "[N/A]" for empty values in forms
In all forms based on FormBuilder / FormItem API (including
all "General" sub-tabs), the value "[N/A]" is used when the
resolved (actual or default) text is either null or empty.
Consider following example:
// Value widgets bound to corresponding model,
// typically managed via GWT Editor framework
TextBoxLabel fooValueWidget = new TextBoxLabel();
TextBoxLabel barValueWidget = new TextBoxLabel();
// Form item "Foo"
formBuilder.addFormItem(
new FormItem("Foo Label", fooValueWidget, 0, 0)
.withEmptyValue("[Empty]") // overrides "[N/A]"
);
// Form item "Bar"
formBuilder.addFormItem(
new FormItem("Bar Label", barValueWidget, 0, 1)
.withDefaultValue("Qux", defaultValueCondition)
);
When rendering "Foo" item:
* if fooValueWidget's text is null or empty,
the value will be rendered as "[Empty]"
When rendering "Bar" item:
* if barValueWidget's text is null or empty
and defaultValueCondition doesn't hold true,
the value will be rendered as "[N/A]"
* if barValueWidget's text is null or empty
and defaultValueCondition does hold true,
the value will be rendered as "Qux"
Change-Id: Ifde07366b36aca6adeeb880539c0aa6fc92d119c
Bug-Url: https://bugzilla.redhat.com/1191484
Signed-off-by: emesika <emesika(a)redhat.com>
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java
1 file changed, 28 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifde07366b36aca6adeeb880539c0aa6fc92d119c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: Filling bonds slaves when creating the setup netwo...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Filling bonds slaves when creating the setup networks params
......................................................................
webadmin: Filling bonds slaves when creating the setup networks params
Having the nic list, the bond slaves can be calculated. There is no need to
update them after each operation, updating the 'isBonded' and
'bondName' fields if enough.
Change-Id: I237332a9cd27e8bb4da6455bcc1051a900551c2b
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java
5 files changed, 12 insertions(+), 25 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44118
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I237332a9cd27e8bb4da6455bcc1051a900551c2b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: engine: Introducing NetworkCommonUtils
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Introducing NetworkCommonUtils
......................................................................
engine: Introducing NetworkCommonUtils
Common network methods that can be use via the backend and the ui.
Change-Id: I74f545c5fa5054e95260dd5405bbffb4472168f1
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetHostBondsByHostIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NetworkCommonUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
4 files changed, 58 insertions(+), 58 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74f545c5fa5054e95260dd5405bbffb4472168f1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: PropertiesTestUtils -> AbstractPropertiesTestBase
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: PropertiesTestUtils -> AbstractPropertiesTestBase
......................................................................
core: PropertiesTestUtils -> AbstractPropertiesTestBase
Converted PropertiesTestUtils to AbstractPropertiesTestBase as the tests
using it were just copy-pasting the content except for the path.
Converting PropertiesTestUtils to AbstractPropertiesTestBase allows us
to move the actual tests there, and have each concrete class just extend
it and specify the path.
Change-Id: I129dbfab8590fc6b6cecd054ac63a7c2d84be812
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java
4 files changed, 32 insertions(+), 57 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I129dbfab8590fc6b6cecd054ac63a7c2d84be812
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: engine: Remove unused AppErrors
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Remove unused AppErrors
......................................................................
engine: Remove unused AppErrors
The various AppErrors in the project contain many deprecated errors that
are no longer used. This patch clears them up and adds tests to assure
this situation doesn't repeat in the future.
The patch contains:
1. Adding the capability to detect keys that aren't present in the
EngineMessage and EngineError enums to DuplicateKeysCheck.
2. Rename DuplicateKeysCheck to PropertiesTestUtils which better
represents its current functionality.
3. Rename DuplicateKeysTest classes to ErrorMessagesTest to better
represent their new capabilities.
4. Remove unused keys from:
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5. Remove keys from AppErrors.java that were removed from the properties
files. Note that the tests do not validate this class, so they may
still be unused keys in it.
6. AppErrors keys that were in fact in use (found by grep) but did not
appear in one of the aforementioned classes were added to
EngineMessage so they could be properly managed.
7. Some Malformed multiline values in the various AppErrors.properties
files that broke its loading by java.util.Properties were fixed so
to make their value contained in a singleline with inline
linebreaks.
8. When a key could not be added to EngineMessages since it contained a
"." it was renamed to replace "." with "_", and then added.
Relates-to: https://bugzilla.redhat.com/1244766
Change-Id: Ide734305c7f417967f05b37bca48dbb0e595728c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromSnapshotParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/CreateGlusterVolumeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterClusterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeBricksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeOptionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeRemoveBricksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Tags.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceAgent.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Image.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ServerParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookContentQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumTranslationProperties.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MissingEnumTranslationException.java
R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/PropertiesTestUtils.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
D frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/DuplicateKeysTest.java
A frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
D frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java
A frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java
52 files changed, 400 insertions(+), 936 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide734305c7f417967f05b37bca48dbb0e595728c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Extract DuplicateKeysChecks#loadFileFromPath
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Extract DuplicateKeysChecks#loadFileFromPath
......................................................................
core: Extract DuplicateKeysChecks#loadFileFromPath
Extract the common code in the various tests to a utility method that
load a properties file from a relative path.
Change-Id: I05406cacf6cf9379aab969772205aaa395f38783
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/DuplicateKeysTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java
4 files changed, 18 insertions(+), 27 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05406cacf6cf9379aab969772205aaa395f38783
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: Distinguish duplicates props from IO errors
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Distinguish duplicates props from IO errors
......................................................................
core: Distinguish duplicates props from IO errors
This patch enhances the DuplicateKeysCheck so it may distinguish between
errors loading a properties file (which should be an error) and
duplicate properties within those properties (which should be a test
failure).
Change-Id: I9baeed9d528e07e4256ef8bc2221f7522405285b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicatePropertyException.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java
M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/DuplicateKeysTest.java
M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java
6 files changed, 17 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9baeed9d528e07e4256ef8bc2221f7522405285b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: webadmin: edit template dialog not working
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: edit template dialog not working
......................................................................
webadmin: edit template dialog not working
Regression introduced by b5295bc which added the handling of the case when the
custom CPU is changed but did not add the same handling when not.
Change-Id: I5fcc9d6c94c12a3dfc13f2bf81ad024fd0268492
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fcc9d6c94c12a3dfc13f2bf81ad024fd0268492
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months
Change in ovirt-engine[master]: core: adding freeze vm and thaw vm commands
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: adding freeze vm and thaw vm commands
......................................................................
core: adding freeze vm and thaw vm commands
Introduced new commands for freezing and thawing guest file-systems
using qemu guest agent (see more details at [1-3]).
[1] http://wiki.libvirt.org/page/Qemu_guest_agent
[2] http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSFreeze
[3] http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSThaw
Change-Id: I51fa7634a91f3b47644cb2e0cac096284f21ecf2
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FreezeVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ThawVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 139 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43998
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51fa7634a91f3b47644cb2e0cac096284f21ecf2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 2 months