August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: change GetErrataForVm to use VdsDynamic as well
by oourfali＠redhat.com 12 Aug '15

12 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: change GetErrataForVm to use VdsDynamic as well ...................................................................... core: change GetErrataForVm to use VdsDynamic as well Change-Id: Ic1930cdb1007e3a068f9f1e834238e0d46eb9aa4 Bug-Url: https://bugzilla.redhat.com/1252317 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> (cherry picked from commit 994de8f02329e8e4fe6f4f6b193a1d906f76ebf4) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForVmQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1930cdb1007e3a068f9f1e834238e0d46eb9aa4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix findBugs warning DC_DOUBLECHECK
by ofrenkel＠redhat.com 12 Aug '15

12 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine: fix findBugs warning DC_DOUBLECHECK ...................................................................... engine: fix findBugs warning DC_DOUBLECHECK Fix findBugs warning DC_DOUBLECHECK. Possible doublecheck on instance in GlusterSyncJob.getInstance(). This method may contain an instance of double-checked locking. This idiom is not correct according to the semantics of the Java memory model. For more information, see the web page http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html. Change-Id: I9a7128bde99e0284dd5f06c7bf5ad5f02b3afd93 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/44682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a7128bde99e0284dd5f06c7bf5ad5f02b3afd93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: frontend: Fix NPE in edit host dialog
by oourfali＠redhat.com 12 Aug '15

12 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Fix NPE in edit host dialog ...................................................................... frontend: Fix NPE in edit host dialog EntityModel<Boolean> was not initialized which resulted in null being implicitly converted to primitive boolean. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251937 Change-Id: I8877632678ec91b7a4edabf32e71f30bc3975d8c Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/44691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8877632678ec91b7a4edabf32e71f30bc3975d8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Resetting to parent commit instead of master
by dcaroest＠redhat.com 11 Aug '15

11 Aug '15

David Caro has submitted this change and it was merged. Change subject: Resetting to parent commit instead of master ...................................................................... Resetting to parent commit instead of master As this script runs on merged patches, master holds the same as the patch, so it makes no sense resetting to it Change-Id: I366cae354d797fff1e95e9b6b07ea5d4c990b77a Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/jenkins_cleanup_yaml.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Eyal Edri: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/44656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366cae354d797fff1e95e9b6b07ea5d4c990b77a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-reports[master]: build: after build reports for 3.6.0 beta 2
by ydary＠redhat.com 11 Aug '15

11 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: after build reports for 3.6.0 beta 2 ...................................................................... build: after build reports for 3.6.0 beta 2 Change-Id: Ifeb1aef66fdef53f55f797f3891273b6a44c91dc Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifeb1aef66fdef53f55f797f3891273b6a44c91dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: build: build reports for 3.6.0 beta 2
by ydary＠redhat.com 11 Aug '15

11 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: build reports for 3.6.0 beta 2 ...................................................................... build: build reports for 3.6.0 beta 2 Change-Id: I8cd567766bb26184c1a031b1b609ae35b231694a Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cd567766bb26184c1a031b1b609ae35b231694a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: after build dwh for 3.6 beta2
by ydary＠redhat.com 11 Aug '15

11 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: after build dwh for 3.6 beta2 ...................................................................... build: after build dwh for 3.6 beta2 Change-Id: I297af7ff321ecbd870481c283872feb1584f0a0f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I297af7ff321ecbd870481c283872feb1584f0a0f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: build dwh for 3.6 beta2
by ydary＠redhat.com 11 Aug '15

11 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: build dwh for 3.6 beta2 ...................................................................... build: build dwh for 3.6 beta2 Change-Id: I2bd946485d9b55ccf8a447f7e843559aae0d2e4d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bd946485d9b55ccf8a447f7e843559aae0d2e4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add missing null check on proceedBalloonCheck
by ofrenkel＠redhat.com 11 Aug '15

11 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: add missing null check on proceedBalloonCheck ...................................................................... core: add missing null check on proceedBalloonCheck When host has balloon enabled, and vm is not reported by vdsm, there is NPE in proceedBalloonCheck because vdsmVm is null. also log monitoring exceptions stack trace in error, these errors are important enough to be fully logged when happen. Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252012 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding extraction of manifests from this iso
by tlitovsk＠redhat.com 11 Aug '15

11 Aug '15

Anatoly Litovsky has submitted this change and it was merged. Change subject: Adding extraction of manifests from this iso ...................................................................... Adding extraction of manifests from this iso Change-Id: I7acc8550c8d49bc19152c2bd7d6f28f394b94742 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/shell-scripts/build-local-ovirt-node-iso.sh 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/44577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7acc8550c8d49bc19152c2bd7d6f28f394b94742 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>

1 0