August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageDomainCommandBaseTest modifiers
by amureini＠redhat.com 12 Aug '15

12 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainCommandBaseTest modifiers ...................................................................... core: StorageDomainCommandBaseTest modifiers Made private utility classes static, as per proper Java conventions. Change-Id: I9b73d6ca4599313e20fde89916791c664a7cb88c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBaseTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b73d6ca4599313e20fde89916791c664a7cb88c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ConfiguredRangeValidatorTest modifiers
by amureini＠redhat.com 12 Aug '15

12 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ConfiguredRangeValidatorTest modifiers ...................................................................... core: ConfiguredRangeValidatorTest modifiers Made private utility classes static, as per proper Java conventions. Change-Id: I2d6d4eb1d3929a9a1c21a3423633f943fcc18605 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ConfiguredRangeValidatorTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d6d4eb1d3929a9a1c21a3423633f943fcc18605 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: RM GetErrataCountsForHostQueryTest casts
by amureini＠redhat.com 12 Aug '15

12 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RM GetErrataCountsForHostQueryTest casts ...................................................................... core: RM GetErrataCountsForHostQueryTest casts Change-Id: Iab8e9cbc0c48e9389f67e795e338377cd63903b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8e9cbc0c48e9389f67e795e338377cd63903b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove unused VmsMonitoringTest
by amureini＠redhat.com 12 Aug '15

12 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused VmsMonitoringTest ...................................................................... core: Remove unused VmsMonitoringTest Patch 9111589045bc8071bce35112c7fc798cf4659bbd removed all the content from VmsMonitoringTest and moved it to HostMonitoringTest. This patch finishes the job and just removed this useless, @Ignored, test. Change-Id: I5d6c61a2eb05ddf02bbfef08ccf2e71be701add9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java 2 files changed, 1 insertion(+), 154 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6c61a2eb05ddf02bbfef08ccf2e71be701add9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetErrataCountsForHostQueryTest setup order
by amureini＠redhat.com 12 Aug '15

12 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetErrataCountsForHostQueryTest setup order ...................................................................... core: GetErrataCountsForHostQueryTest setup order AbstractQueryTest contains a setUp() (note the upper case U) method annotated with @Before, and this class introduced a setup() (note the lower case u) method also annotated with @Before. This causes the class to have two @Before methods which may cause test failures as JUnit does nto assure any order between multiple initializers. This patch renames the method to setUp() and explicitly calls super's method in order to make the test's execution deterministically and prevent potential test failures. Note: This patch solves Coverity CID 1292837. Change-Id: Ibcfebf5ddbebc9cc2e4a613841b2d870fd6fc1f0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcfebf5ddbebc9cc2e4a613841b2d870fd6fc1f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: cancel vm conversion - bll
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: cancel vm conversion - bll ...................................................................... core: cancel vm conversion - bll Change-Id: Ic8fe880c4c0bea99bd6fb05dd32d163ddb5d92e4 Bug-Url: https://bugzilla.redhat.com/1236075 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CancelConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 109 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fe880c4c0bea99bd6fb05dd32d163ddb5d92e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: initialize conversion progress properly
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: initialize conversion progress properly ...................................................................... core: initialize conversion progress properly The conversion progress that is stored in VmManager should be initialized with -1 which indicates that the VM is not being converted (0 means that there is a conversion going on) Change-Id: I396e4eebf8710e42876bd94f4e5a82c88f0d35af Bug-Url: https://bugzilla.redhat.com/1236075 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I396e4eebf8710e42876bd94f4e5a82c88f0d35af Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: pki fix breakage introduced by Idca016
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: pki fix breakage introduced by Idca016 ...................................................................... packaging: setup: pki fix breakage introduced by Idca016 conditional renew should be only for RENEW! Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860 Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Passed CI tests Sandro Bonazzola: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: XmlRpcStringUtilsTest members modifiers
by amureini＠redhat.com 12 Aug '15

12 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: XmlRpcStringUtilsTest members modifiers ...................................................................... core: XmlRpcStringUtilsTest members modifiers Made constant strings private static final, as per proper Java conventions. Change-Id: Ic83975d5ea78059722d9537b7302a60c61b53f40 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcStringUtilsTest.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic83975d5ea78059722d9537b7302a60c61b53f40 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: avoid disks lock check on create snapshot while LSM
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: avoid disks lock check on create snapshot while LSM ...................................................................... core: avoid disks lock check on create snapshot while LSM Restored the logic [*] that ignores locked disks while performing LSM (on CreateAllSnapshotsFromVmCommand). [*] logic removed on: - I9f42f387781425d16f53a0e8a34d859365808ec0 - I085d49dc90053e375f829900c75d2fe72c263161 Change-Id: I8eaf480f9ac855f48cc93066e9c849052865cef5 Bug-Url: https://bugzilla.redhat.com/1251956 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 2 files changed, 29 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eaf480f9ac855f48cc93066e9c849052865cef5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0