Change in ovirt-engine[master]: packaging: setup: pki fix breakage introduced by Idca016
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: pki fix breakage introduced by Idca016
......................................................................
packaging: setup: pki fix breakage introduced by Idca016
conditional renew should be only for RENEW!
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860
Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 22 insertions(+), 22 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44743
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: frontend: Tests for ConstantsWithLookup classes
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: frontend: Tests for ConstantsWithLookup classes
......................................................................
frontend: Tests for ConstantsWithLookup classes
oVirt engine's classes that inherit from ConstantsWithLookup
(AppErrors and VdsmErrors) are used to translate enum constants
(EngineMessage and EngineError, accordingly).
This patch completes the work done in previous patches and adds
tests to make sure these classes don't contain translations for keys
that have been removed from the enumss.
This patch contains:
* A new base class AbstractConstantsWithLookupTestCase with the
testing functionality.
* New tests based on this functionality - AppErrorsTest and
VdsmErrorsTest.
* Cleaning up AppErrors from redundant constants to make the test
pass.
Change-Id: Ibb65dfe76e3284fac24f4d63e311c068107fc276
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AbstractConstantsWithLookupTestCase.java
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AppErrorsTest.java
A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/VdsmErrorsTest.java
4 files changed, 63 insertions(+), 24 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/44734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb65dfe76e3284fac24f4d63e311c068107fc276
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-hosted-engine-ha[master]: Fill VDSM volumes with zeros before using them for the first...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Fill VDSM volumes with zeros before using them for the first time
......................................................................
Fill VDSM volumes with zeros before using them for the first time
VDSM does not initialize iSCSI volumes to clean state and that
causes issues when trying to read the metadata from it. The agent
fails to parse random blocks since there are some random data
and the checksum does not match.
Change-Id: Ifa35e575c7e9405474562813aaa56d71b27791d6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238823
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/storage_backends.py
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa35e575c7e9405474562813aaa56d71b27791d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in jenkins[master]: nsis-simple-service-plugin: new job
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: nsis-simple-service-plugin: new job
......................................................................
nsis-simple-service-plugin: new job
added nsis-simple-service-plugin job.
Artifacts will be published on 3.6 and master repos.
Change-Id: I3f1877e0a837ef3c6cfacd20d860d783e1362b6b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/projects/nsis-simple-service-plugin/nsis-simple-service-plugin.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
3 files changed, 22 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Looks good to me
Sandro Bonazzola: Verified; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f1877e0a837ef3c6cfacd20d860d783e1362b6b
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
9 years, 5 months
Change in jenkins[master]: ovirt-engine: dropping ovirt-engine_create-rpms
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: ovirt-engine: dropping ovirt-engine_create-rpms
......................................................................
ovirt-engine: dropping ovirt-engine_create-rpms
we already moved to standard CI jobs, dropping this.
Change-Id: I6464252404c3448fc8921188a075d472f26a464a
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
D jobs/confs/projects/ovirt-engine/ovirt-engine_create-rpms.yaml
1 file changed, 0 insertions(+), 53 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
David Caro: Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/44735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6464252404c3448fc8921188a075d472f26a464a
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[master]: core: move initialization code to init
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: move initialization code to init
......................................................................
core: move initialization code to init
add/update cluster commands are calling CpuFlagsManagerHandler in the
constructor, but since it is now injected, it is not yet available.
moved the code to init that is called in postConstruct, as it should.
Change-Id: I269025c7311b3c3afdec7c1cadb20c6268e846d1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252475
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I269025c7311b3c3afdec7c1cadb20c6268e846d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in jenkins[master]: ovirt-hosted-engine-setup: move 3.5 to standard
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-hosted-engine-setup: move 3.5 to standard
......................................................................
ovirt-hosted-engine-setup: move 3.5 to standard
moving ovirt-hosted-engine-setup 3.5 jobs to standard CI.
Change-Id: I70bd91aa8673927d8ace2b8b081233a1407e47a1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
D jobs/confs/projects/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup_create-rpms.yaml
M jobs/confs/projects/ovirt-hosted-engine-setup/ovirt-hosted-engine_stardard.yaml
2 files changed, 19 insertions(+), 25 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for merge
Sharon Naftaly: Verified; Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70bd91aa8673927d8ace2b8b081233a1407e47a1
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Allow using Collection in ReplacementUtils.replaceWith
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Allow using Collection in ReplacementUtils.replaceWith
......................................................................
core: Allow using Collection in ReplacementUtils.replaceWith
Allow using Collection in ReplacementUtils.replaceWith instead of List.
Change-Id: Ifa2aa70b2e451f4f316856960918d74a135e554f
Bug-Url: https://bugzilla.redhat.com/1115098
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java
2 files changed, 16 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/44405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa2aa70b2e451f4f316856960918d74a135e554f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: automation: fix repos
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: fix repos
......................................................................
automation: fix repos
use 3.5 repos and not 3.6 ones.
Change-Id: I6a21051942f455ac2b8f6eba99b558db8122cb62
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.repos
M automation/check-merged.repos
M automation/check-patch.repos
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a21051942f455ac2b8f6eba99b558db8122cb62
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[master]: scheduling: fix logging level
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduling: fix logging level
......................................................................
scheduling: fix logging level
Change-Id: I5753b338b79727b65d64815c588c32d35a7ba17b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1240268
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationWeightPolicyUnit.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/44084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5753b338b79727b65d64815c588c32d35a7ba17b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejčír <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months