August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: HAClient: allow overriding broker connection parameters
by msivak＠redhat.com 12 Aug '15

12 Aug '15

Martin Sivák has submitted this change and it was merged. Change subject: HAClient: allow overriding broker connection parameters ...................................................................... HAClient: allow overriding broker connection parameters Change-Id: I24278a918b887e95ace1d494879c2c0144466675 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1172511 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/client/client.py M ovirt_hosted_engine_ha/lib/brokerlink.py 2 files changed, 9 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Verified; Looks good to me, but someone else must approve Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/36194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24278a918b887e95ace1d494879c2c0144466675 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: after respin dwh for 3.6 beta2
by ydary＠redhat.com 12 Aug '15

12 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: after respin dwh for 3.6 beta2 ...................................................................... build: after respin dwh for 3.6 beta2 Change-Id: Iedfa5769a12fe01c1d2db0b3c1b4cc26ca9c2c17 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfa5769a12fe01c1d2db0b3c1b4cc26ca9c2c17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: respin dwh for 3.6 beta2
by ydary＠redhat.com 12 Aug '15

12 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: build: respin dwh for 3.6 beta2 ...................................................................... build: respin dwh for 3.6 beta2 Change-Id: If9d91d2bb5b9211d597f11682f51f08b41011984 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9d91d2bb5b9211d597f11682f51f08b41011984 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: dwh: fixed column schema mis-match in config sync
by ydary＠redhat.com 12 Aug '15

12 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: dwh: fixed column schema mis-match in config sync ...................................................................... dwh: fixed column schema mis-match in config sync Change-Id: I9bf9121dc46f5e264704bd8c55e0b61dff376586 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1233193 --- M etl_export/src/ovirt_engine_dwh/configurationsync_3_6/ConfigurationSync.java M tos_project/process/ConfigurationSync_3.6.item M tos_project/process/ConfigurationSync_3.6.properties 3 files changed, 175 insertions(+), 175 deletions(-) Approvals: Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bf9121dc46f5e264704bd8c55e0b61dff376586 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: pki fix breakage introduced by Idca016
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: pki fix breakage introduced by Idca016 ...................................................................... packaging: setup: pki fix breakage introduced by Idca016 conditional renew should be only for RENEW! Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1214860 Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica6680f5d8feae3cc9a2b4782c2adbd993f77d17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add missing null check on proceedBalloonCheck
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: add missing null check on proceedBalloonCheck ...................................................................... core: add missing null check on proceedBalloonCheck When host has balloon enabled, and vm is not reported by vdsm, there is NPE in proceedBalloonCheck because vdsmVm is null. also log monitoring exceptions stack trace in error, these errors are important enough to be fully logged when happen. Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252012 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc08dbb8e8448049b07bee5130a5654501df28fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Use proper substitution in HostDev commands' canDoActions
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Use proper substitution in HostDev commands' canDoActions ...................................................................... core: Use proper substitution in HostDev commands' canDoActions Added missing action message parameters and status localization to Add/Remove Host Device Commands. Also added missing type HOST_DEVICES to webadmin's AppErrors. Change-Id: Ib68484f0d363203aedff3d49a7ae453246e4acd1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1247041 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AddVmHostDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RemoveVmHostDevicesCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 20 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib68484f0d363203aedff3d49a7ae453246e4acd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix copyCollapse ambiguity when there are no snapshots
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix copyCollapse ambiguity when there are no snapshots ...................................................................... core: Fix copyCollapse ambiguity when there are no snapshots Import VMs with no snapshots were blocked if copyCollapse was false. This parameter is now ignored when there are no snapshots. Also added localized error message. Change-Id: I0740b28452ef859d22f8a781af6fb818382cf85e Bug-Url: https://bugzilla.redhat.com/1147011 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 91 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/44658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0740b28452ef859d22f8a781af6fb818382cf85e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: Fix Deadlock in multiple hostdev RunVmCommands
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: Fix Deadlock in multiple hostdev RunVmCommands ...................................................................... backend: Fix Deadlock in multiple hostdev RunVmCommands The eager synchronous instantiation of Commands in MultipleActionsRunner combined with host device lock being obtained in @PostConstruct of RunVmCommand resulted in deadlock in initCommandsAndReturnValues() method. The deadlock was resolved by moving the acquireHostDeviceLock() to RunVmCommand#canDoAction() and releasing it immediately after check with cooperation of the runVm() method that obtains it again and holds it during the actual host device operations. Change-Id: I64135e46be0dfb6dd71dde862d44f5afa1f1a7b9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248104 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M packaging/dbscripts/host_device_sp.sql 7 files changed, 43 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64135e46be0dfb6dd71dde862d44f5afa1f1a7b9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: backend: Fix incorrect allocation of Host Devices
by tnisan＠redhat.com 12 Aug '15

12 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: backend: Fix incorrect allocation of Host Devices ...................................................................... backend: Fix incorrect allocation of Host Devices It was possible for the MarkHostDevicesUsedByVmId to accidentally allocate same host device on multiple hosts if there existed such host devices in DB. This patch adds the host id to the stored procedure parameter to ensure the allocation is only performed on given host's devices. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1250363 Change-Id: I390452251e33b487a5d815c71d8a29958ff23db8 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java M packaging/dbscripts/host_device_sp.sql 6 files changed, 12 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I390452251e33b487a5d815c71d8a29958ff23db8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0